From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3AE0F439A1
	for <public@inbox.dpdk.org>; Tue, 23 Jan 2024 01:18:54 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 2C13240E72;
	Tue, 23 Jan 2024 01:18:54 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 8C86740273
 for <test-report@dpdk.org>; Tue, 23 Jan 2024 01:18:52 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 865B3122B9C; Tue, 23 Jan 2024 01:18:52 +0100 (CET)
Subject: |WARNING| pw136052 [PATCH 4/7] net/gve: RSS configuration update
 support
In-Reply-To: <20240123001645.1507779-5-joshwash@google.com>
References: <20240123001645.1507779-5-joshwash@google.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Joshua Washington <joshwash@google.com>
Message-Id: <20240123001852.865B3122B9C@dpdk.org>
Date: Tue, 23 Jan 2024 01:18:52 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136052

_coding style issues_


ERROR:C99_COMMENTS: do not use C99 // comments
#134: FILE: drivers/net/gve/gve_ethdev.c:101:
+	// Reset RSS RETA in case number of queues changed.

ERROR:C99_COMMENTS: do not use C99 // comments
#225: FILE: drivers/net/gve/gve_ethdev.c:730:
+	// Set redirection table to default or preexisting.

WARNING:TYPO_SPELLING: 'defualt' may be misspelled - perhaps 'default'?
#258: FILE: drivers/net/gve/gve_ethdev.c:763:
+			PMD_DRV_LOG(ERR, "Unable to retrieve defualt RSS hash key.");

ERROR:CODE_INDENT: code indent should use tabs where possible
#308: FILE: drivers/net/gve/gve_ethdev.h:297:
+        struct gve_rss_config rss_config;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#308: FILE: drivers/net/gve/gve_ethdev.h:297:
+        struct gve_rss_config rss_config;$

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 4 errors, 2 warnings, 0 checks, 194 lines checked