|WARNING| pw136051 [PATCH 3/7] net/gve: add gve_rss library for handling RSS-related behaviors

|WARNING| pw136051 [PATCH 3/7] net/gve: add gve_rss library for handling RSS-related behaviors

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136051

_coding style issues_


ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#146: FILE: drivers/net/gve/gve_ethdev.h:36:
+#define GVE_RTE_RSS_OFFLOAD_ALL (	\
 	RTE_ETH_RSS_IPV4 |		\
 	RTE_ETH_RSS_NONFRAG_IPV4_TCP |	\
 	RTE_ETH_RSS_IPV6 |		\

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#172: FILE: drivers/net/gve/gve_rss.c:8:
+gve_generate_rss_reta(struct rte_eth_dev *dev, struct gve_rss_config* config)

WARNING:BRACES: braces {} are not necessary for single statement blocks
#175: FILE: drivers/net/gve/gve_rss.c:11:
+	if (!config || !config->indir) {
+		return -EINVAL;
+	}

WARNING:BRACES: braces {} are not necessary for single statement blocks
#198: FILE: drivers/net/gve/gve_rss.c:34:
+	if (!gve_rss_conf->key) {
+		return -ENOMEM;
+	}

ERROR:C99_COMMENTS: do not use C99 // comments
#316: FILE: drivers/net/gve/gve_rss.c:152:
+	// Initialize to 0 before modifying.

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#327: FILE: drivers/net/gve/gve_rss.c:163:
+void
+rte_to_gve_rss_hf(uint64_t rte_rss_hf, struct gve_rss_config *gve_rss_conf) {

ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#349: FILE: drivers/net/gve/gve_rss.c:185:
+void
+gve_to_rte_rss_hf(uint16_t gve_rss_types, struct rte_eth_rss_conf *rss_conf) {

ERROR:POINTER_LOCATION: "foo* bar" should be "foo *bar"
#411: FILE: drivers/net/gve/gve_rss.h:35:
+gve_generate_rss_reta(struct rte_eth_dev *dev, struct gve_rss_config* config);

WARNING:TYPO_SPELLING: 'retreive' may be misspelled - perhaps 'retrieve'?
#454: FILE: drivers/net/gve/gve_rss.h:78:
+ *	1) retreive from `rss_conf`, if set

CHECK:SPACING: spaces preferred around that '&' (ctx:WxO)
#467: FILE: drivers/net/gve/gve_rss.h:91:
+	return rte_rss_hf &~ GVE_RTE_RSS_OFFLOAD_ALL;
 	                  ^

ERROR:SPACING: space prohibited after that '~' (ctx:OxW)
#467: FILE: drivers/net/gve/gve_rss.h:91:
+	return rte_rss_hf &~ GVE_RTE_RSS_OFFLOAD_ALL;
 	                   ^

ERROR:MISSING_SIGN_OFF: Missing Signed-off-by: line(s)

total: 8 errors, 3 warnings, 1 checks, 365 lines checked