From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw136219 [RFC 2/2] tap: rework BPF handling
Date: Tue, 30 Jan 2024 11:48:25 +0100 (CET) [thread overview]
Message-ID: <20240130104825.42976121F08@dpdk.org> (raw)
In-Reply-To: <20240130034925.44869-3-stephen@networkplumber.org>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136219
_coding style issues_
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1009: FILE: drivers/net/tap/bpf/tap_rss.c:92:
+ return 0;
+ } else {
WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1014: FILE: drivers/net/tap/bpf/tap_rss.c:97:
+ &src_dst_port, sizeof(src_dst_port), BPF_HDR_START_NET))
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1044: FILE: drivers/net/tap/bpf/tap_rss.c:127:
+ if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))
WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1051: FILE: drivers/net/tap/bpf/tap_rss.c:134:
+ if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))
WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1099: FILE: drivers/net/tap/bpf/tap_rss.c:182:
+ return 0;
+ } else {
WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1141: FILE: drivers/net/tap/bpf/tap_rss.c:224:
+ __u16 slave_dev_queue_mapping;
WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rss_flow_action', this function's name, in a string
#1160: FILE: drivers/net/tap/bpf/tap_rss.c:243:
+ char fmt[] = "rss_flow_action classid:%u
";
ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - struct tap_rss *open_and_load() should probably be struct tap_rss *open_and_load(void)
#3973: FILE: drivers/net/tap/tap_rss.skel.h:28:
+ static inline struct tap_rss *open_and_load();
WARNING:LINE_CONTINUATIONS: Avoid line continuations in quoted strings
#4125: FILE: drivers/net/tap/tap_rss.skel.h:180:
+ return (const void *)"\
WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#15550: FILE: drivers/net/tap/tap_rss.skel.h:11605:
+struct tap_rss *tap_rss::open(const struct bpf_object_open_opts *opts) { return tap_rss__open_opts(opts); }
CHECK:CAMELCASE: Avoid CamelCase: <_Static_assert>
#15563: FILE: drivers/net/tap/tap_rss.skel.h:11618:
+#define _Static_assert static_assert
total: 1 errors, 9 warnings, 1 checks, 12742 lines checked
prev parent reply other threads:[~2024-01-30 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240130034925.44869-3-stephen@networkplumber.org>
2024-01-30 10:14 ` |FAILURE| pw136209-136219 " qemudev
2024-01-30 10:48 ` checkpatch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130104825.42976121F08@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).