|FAILURE| pw136209-136219 [RFC 2/2] tap: rework BPF handling

|FAILURE| pw136209-136219 [RFC 2/2] tap: rework BPF handling

[qemudev]

Test-Label: loongarch-compilation
Test-Status: FAILURE
http://dpdk.org/patch/136219

_ninja build failure_

Submitter: Stephen Hemminger <stephen@networkplumber.org>
Date: Mon, 29 Jan 2024 19:46:51 -0800
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 906d2c06b3cfc61620453c6909266fe771f8ccfb

136209-136219 --> ninja build failed

Test environment and result as below:

+---------------------+----------------+
|     Environment     | compilation    |
+---------------------+----------------+
| Loongnix-Server 8.3 | FAIL           |
+---------------------+----------------+

Loongnix-Server 8.3
    Kernel: 4.19.190+
    Compiler: gcc 8.3


Ninja build logs:
-------------------------------BEGIN LOGS----------------------------
FAILED: drivers/libtmp_rte_net_tap.a.p/net_tap_tap_tcmsgs.c.o
cc -Idrivers/libtmp_rte_net_tap.a.p -Idrivers -I../drivers -Idrivers/net/tap -I../drivers/net/tap -Idrivers/bus/vdev -I../drivers/bus/vdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/gso -I../lib/gso -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definit
 ion -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DTAP_MAX_QUEUES=16 -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.tap -MD -MQ drivers/libtmp_rte_net_tap.a.p/net_tap_tap_tcmsgs.c.o -MF drivers/libtmp_rte_net_tap.a.p/net_tap_tap_tcmsgs.c.o.d -o drivers/libtmp_rte_net_tap.a.p/net_tap_tap_tcmsgs.c.o -c ../drivers/net/tap/tap_tcmsgs.c
In file included from ../drivers/net/tap/tap_tcmsgs.c:12:
./drivers/net/tap/tap_tcmsgs.h:9:10: fatal error: tap_autoconf.h: No such file or directory
#include <tap_autoconf.h>
^~~~~~~~~~~~~~~~
compilation terminated.
[1555/2423] Compiling C object drivers/libtmp_rte_net_tap.a.p/net_tap_tap_flow.c.o
FAILED: drivers/libtmp_rte_net_tap.a.p/net_tap_tap_flow.c.o
cc -Idrivers/libtmp_rte_net_tap.a.p -Idrivers -I../drivers -Idrivers/net/tap -I../drivers/net/tap -Idrivers/bus/vdev -I../drivers/bus/vdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/gso -I../lib/gso -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definit
 ion -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DTAP_MAX_QUEUES=16 -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.tap -MD -MQ drivers/libtmp_rte_net_tap.a.p/net_tap_tap_flow.c.o -MF drivers/libtmp_rte_net_tap.a.p/net_tap_tap_flow.c.o.d -o drivers/libtmp_rte_net_tap.a.p/net_tap_tap_flow.c.o -c ../drivers/net/tap/tap_flow.c
In file included from ../drivers/net/tap/tap_flow.c:19:
./drivers/net/tap/tap_tcmsgs.h:9:10: fatal error: tap_autoconf.h: No such file or directory
#include <tap_autoconf.h>
^~~~~~~~~~~~~~~~
compilation terminated.
[1556/2423] Compiling C object drivers/libtmp_rte_net_tap.a.p/net_tap_tap_netlink.c.o
[1557/2423] Compiling C object drivers/libtmp_rte_net_softnic.a.p/net_softnic_rte_eth_softnic_swq.c.o
[1558/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_vf.c.o
[1559/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_init_fw_funcs.c.o
[1560/2423] Compiling C object drivers/libtmp_rte_net_tap.a.p/net_tap_tap_intr.c.o
[1561/2423] Compiling C object drivers/net/thunderx/base/libnicvf_base.a.p/nicvf_bsvf.c.o
[1562/2423] Generating rte_net_octeontx.pmd.c with a custom command
[1563/2423] Compiling C object drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o
FAILED: drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o
cc -Idrivers/libtmp_rte_net_tap.a.p -Idrivers -I../drivers -Idrivers/net/tap -I../drivers/net/tap -Idrivers/bus/vdev -I../drivers/bus/vdev -I. -I.. -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/loongarch/include -I../lib/eal/loongarch/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/log -I../lib/log -Ilib/metrics -I../lib/metrics -Ilib/telemetry -I../lib/telemetry -Ilib/gso -I../lib/gso -Ilib/ethdev -I../lib/ethdev -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -std=c11 -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definit
 ion -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=loongarch64 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DTAP_MAX_QUEUES=16 -DRTE_LOG_DEFAULT_LOGTYPE=pmd.net.tap -MD -MQ drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o -MF drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o.d -o drivers/libtmp_rte_net_tap.a.p/net_tap_rte_eth_tap.c.o -c ../drivers/net/tap/rte_eth_tap.c
In file included from ../drivers/net/tap/rte_eth_tap.c:47:
./drivers/net/tap/tap_tcmsgs.h:9:10: fatal error: tap_autoconf.h: No such file or directory
#include <tap_autoconf.h>
^~~~~~~~~~~~~~~~
compilation terminated.
[1564/2423] Generating rte_net_pfe.pmd.c with a custom command
[1565/2423] Generating rte_net_ice.sym_chk with a custom command (wrapped by meson to capture output)
[1566/2423] Compiling C object drivers/libtmp_rte_net_softnic.a.p/net_softnic_rte_eth_softnic.c.o
[1567/2423] Compiling C object drivers/libtmp_rte_net_softnic.a.p/net_softnic_rte_eth_softnic_thread.c.o
[1568/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_int.c.o
[1569/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_cxt.c.o
[1570/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_l2.c.o
[1571/2423] Generating rte_net_octeon_ep.pmd.c with a custom command
[1572/2423] Compiling C object drivers/libtmp_rte_net_softnic.a.p/net_softnic_rte_eth_softnic_cli.c.o
[1573/2423] Compiling C object drivers/libtmp_rte_net_ring.a.p/net_ring_rte_eth_ring.c.o
[1574/2423] Compiling C object drivers/net/thunderx/base/libnicvf_base.a.p/nicvf_mbox.c.o
[1575/2423] Compiling C object drivers/libtmp_rte_net_pcap.a.p/net_pcap_pcap_ethdev.c.o
[1576/2423] Compiling C object drivers/libtmp_rte_net_ixgbe.a.p/net_ixgbe_ixgbe_rxtx.c.o
[1577/2423] Compiling C object drivers/net/thunderx/base/libnicvf_base.a.p/nicvf_hw.c.o
[1578/2423] Compiling C object drivers/libtmp_rte_net_qede.a.p/net_qede_qede_ethdev.c.o
[1579/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_mcp.c.o
[1580/2423] Generating rte_net_nfp.pmd.c with a custom command
[1581/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_sriov.c.o
[1582/2423] Compiling C object drivers/libtmp_rte_net_ngbe.a.p/net_ngbe_ngbe_rxtx.c.o
[1583/2423] Compiling C object drivers/libtmp_rte_net_qede.a.p/net_qede_qede_rxtx.c.o
[1584/2423] Compiling C object drivers/libtmp_rte_net_thunderx.a.p/net_thunderx_nicvf_ethdev.c.o
[1585/2423] Compiling C object drivers/net/qede/base/libqede_base.a.p/ecore_dev.c.o
[1586/2423] Compiling C object drivers/libtmp_rte_net_qede.a.p/net_qede_qede_debug.c.o
[1587/2423] Generating rte_common_cnxk.sym_chk with a custom command (wrapped by meson to capture output)
ninja: build stopped: subcommand failed.
-------------------------------END LOGS------------------------------

|WARNING| pw136219 [RFC 2/2] tap: rework BPF handling

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136219

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1009: FILE: drivers/net/tap/bpf/tap_rss.c:92:
+		return 0;
+	} else {

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1014: FILE: drivers/net/tap/bpf/tap_rss.c:97:
+						&src_dst_port, sizeof(src_dst_port), BPF_HDR_START_NET))

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1044: FILE: drivers/net/tap/bpf/tap_rss.c:127:
+			if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1051: FILE: drivers/net/tap/bpf/tap_rss.c:134:
+			if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1099: FILE: drivers/net/tap/bpf/tap_rss.c:182:
+		return 0;
+	} else {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1141: FILE: drivers/net/tap/bpf/tap_rss.c:224:
+		__u16		slave_dev_queue_mapping;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rss_flow_action', this function's name, in a string
#1160: FILE: drivers/net/tap/bpf/tap_rss.c:243:
+	char fmt[] = "rss_flow_action classid:%u
";

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - struct tap_rss *open_and_load() should probably be struct tap_rss *open_and_load(void)
#3973: FILE: drivers/net/tap/tap_rss.skel.h:28:
+	static inline struct tap_rss *open_and_load();

WARNING:LINE_CONTINUATIONS: Avoid line continuations in quoted strings
#4125: FILE: drivers/net/tap/tap_rss.skel.h:180:
+	return (const void *)"\

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#15550: FILE: drivers/net/tap/tap_rss.skel.h:11605:
+struct tap_rss *tap_rss::open(const struct bpf_object_open_opts *opts) { return tap_rss__open_opts(opts); }

CHECK:CAMELCASE: Avoid CamelCase: <_Static_assert>
#15563: FILE: drivers/net/tap/tap_rss.skel.h:11618:
+#define _Static_assert static_assert

total: 1 errors, 9 warnings, 1 checks, 12742 lines checked