From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3413043A0A
	for <public@inbox.dpdk.org>; Tue, 30 Jan 2024 11:48:26 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3051D402CE;
	Tue, 30 Jan 2024 11:48:26 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 57DD5402AC
 for <test-report@dpdk.org>; Tue, 30 Jan 2024 11:48:25 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 42976121F08; Tue, 30 Jan 2024 11:48:25 +0100 (CET)
Subject: |WARNING| pw136219 [RFC 2/2] tap: rework BPF handling
In-Reply-To: <20240130034925.44869-3-stephen@networkplumber.org>
References: <20240130034925.44869-3-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20240130104825.42976121F08@dpdk.org>
Date: Tue, 30 Jan 2024 11:48:25 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136219

_coding style issues_


WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1009: FILE: drivers/net/tap/bpf/tap_rss.c:92:
+		return 0;
+	} else {

WARNING:LONG_LINE: line length of 104 exceeds 100 columns
#1014: FILE: drivers/net/tap/bpf/tap_rss.c:97:
+						&src_dst_port, sizeof(src_dst_port), BPF_HDR_START_NET))

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1044: FILE: drivers/net/tap/bpf/tap_rss.c:127:
+			if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))

WARNING:LONG_LINE: line length of 103 exceeds 100 columns
#1051: FILE: drivers/net/tap/bpf/tap_rss.c:134:
+			if (bpf_skb_load_bytes_relative(skb, *off, &xh, sizeof(xh), BPF_HDR_START_NET))

WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#1099: FILE: drivers/net/tap/bpf/tap_rss.c:182:
+		return 0;
+	} else {

WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'?
#1141: FILE: drivers/net/tap/bpf/tap_rss.c:224:
+		__u16		slave_dev_queue_mapping;

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rss_flow_action', this function's name, in a string
#1160: FILE: drivers/net/tap/bpf/tap_rss.c:243:
+	char fmt[] = "rss_flow_action classid:%u
";

ERROR:FUNCTION_WITHOUT_ARGS: Bad function definition - struct tap_rss *open_and_load() should probably be struct tap_rss *open_and_load(void)
#3973: FILE: drivers/net/tap/tap_rss.skel.h:28:
+	static inline struct tap_rss *open_and_load();

WARNING:LINE_CONTINUATIONS: Avoid line continuations in quoted strings
#4125: FILE: drivers/net/tap/tap_rss.skel.h:180:
+	return (const void *)"\

WARNING:LONG_LINE: line length of 107 exceeds 100 columns
#15550: FILE: drivers/net/tap/tap_rss.skel.h:11605:
+struct tap_rss *tap_rss::open(const struct bpf_object_open_opts *opts) { return tap_rss__open_opts(opts); }

CHECK:CAMELCASE: Avoid CamelCase: <_Static_assert>
#15563: FILE: drivers/net/tap/tap_rss.skel.h:11618:
+#define _Static_assert static_assert

total: 1 errors, 9 warnings, 1 checks, 12742 lines checked