From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Alan Elder <alan.elder@microsoft.com>
Subject: |WARNING| pw136534 [PATCH] net/netvsc: fix parsing of VLAN metadata
Date: Thu, 8 Feb 2024 15:16:19 +0100 (CET) [thread overview]
Message-ID: <20240208141619.A8BA8121F0B@dpdk.org> (raw)
In-Reply-To: <PA4PR83MB0526398D23186AB50C38D0EF97442@PA4PR83MB0526.EURPRD83.prod.outlook.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136534
_coding style issues_
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/net/netvsc/hn_rxtx.c:51:
+ struct ndis_pkt_vlan_info vlan_info;$
ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+ info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+ info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: drivers/net/netvsc/hn_rxtx.c:619:
+ if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {$
WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (3, 7)
#178: FILE: drivers/net/netvsc/hn_rxtx.c:619:
+ if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {
+ m->vlan_tci = info->vlan_info.vlanid |
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: drivers/net/netvsc/hn_rxtx.c:620:
+ m->vlan_tci = info->vlan_info.vlanid |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#180: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+ (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#180: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+ (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#181: FILE: drivers/net/netvsc/hn_rxtx.c:622:
+ (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: drivers/net/netvsc/hn_rxtx.c:622:
+ (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: drivers/net/netvsc/hn_rxtx.c:679:
+ .vlan_info.value = HN_NDIS_VLAN_INFO_INVALID,$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: drivers/net/netvsc/hn_rxtx.c:1342:
+ struct ndis_pkt_vlan_info *vlan = (struct ndis_pkt_vlan_info *)pi_data;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: drivers/net/netvsc/hn_rxtx.c:1343:
+ vlan->value = 0;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: drivers/net/netvsc/hn_rxtx.c:1344:
+ vlan->vlanid = (m->vlan_tci & HN_VLAN_VID_MASK);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: drivers/net/netvsc/hn_rxtx.c:1345:
+ vlan->cfi = (!!(m->vlan_tci & HN_VLAN_CFI_MASK));$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: drivers/net/netvsc/hn_rxtx.c:1346:
+ vlan->pri = ((m->vlan_tci & HN_VLAN_PRIO_MASK) >> HN_VLAN_PRIO_SHIFT);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: drivers/net/netvsc/ndis.h:320:
+ union {$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: drivers/net/netvsc/ndis.h:321:
+ struct {$
ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: drivers/net/netvsc/ndis.h:322:
+ uint32_t pri:3; /* User Priority */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: drivers/net/netvsc/ndis.h:322:
+ uint32_t pri:3; /* User Priority */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: drivers/net/netvsc/ndis.h:323:
+ uint32_t cfi:1; /* Canonical Format ID / DEI */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: drivers/net/netvsc/ndis.h:323:
+ uint32_t cfi:1; /* Canonical Format ID / DEI */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: drivers/net/netvsc/ndis.h:324:
+ uint32_t vlanid:12; /* VLAN ID */$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: drivers/net/netvsc/ndis.h:324:
+ uint32_t vlanid:12; /* VLAN ID */$
ERROR:CODE_INDENT: code indent should use tabs where possible
#231: FILE: drivers/net/netvsc/ndis.h:325:
+ uint32_t reserved:16;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: drivers/net/netvsc/ndis.h:325:
+ uint32_t reserved:16;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#232: FILE: drivers/net/netvsc/ndis.h:326:
+ };$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#233: FILE: drivers/net/netvsc/ndis.h:327:
+ uint32_t value;$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: drivers/net/netvsc/ndis.h:328:
+ };$
ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Alan Elder <alan.elder@microsoft.com>'
total: 8 errors, 22 warnings, 0 checks, 90 lines checked
next prev parent reply other threads:[~2024-02-08 14:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PA4PR83MB0526398D23186AB50C38D0EF97442@PA4PR83MB0526.EURPRD83.prod.outlook.com>
2024-02-08 13:51 ` qemudev
2024-02-08 14:16 ` checkpatch [this message]
2024-02-08 14:32 dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240208141619.A8BA8121F0B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=alan.elder@microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).