|WARNING| pw136534 [PATCH] net/netvsc: fix parsing of VLAN metadata

|WARNING| pw136534 [PATCH] net/netvsc: fix parsing of VLAN metadata

[qemudev]

Test-Label: loongarch-compilation
Test-Status: WARNING
http://dpdk.org/patch/136534

_apply patch failure_

Submitter: Alan Elder <alan.elder@microsoft.com>
Date: Thu, 8 Feb 2024 14:12:38 +0000
DPDK git baseline: Repo:dpdk-next-net
  Branch: main
  CommitID: 805c5507267b6ef7a0cdcfc33aa326bc1de8c80b

Apply patch set 136534 failed:

Checking patch .mailmap...
error: while searching for:
Alain Leon xerebz@gmail.com<mailto:xerebz@gmail.com>
Alan Carew alan.carew@intel.com<mailto:alan.carew@intel.com>
Alan Dewar alan.dewar@att.com<mailto:alan.dewar@att.com> adewar@brocade.com<mailto:adewar@brocade.com>
Alan Liu zaoxingliu@gmail.com<mailto:zaoxingliu@gmail.com>
Alan Winkowski walan@marvell.com<mailto:walan@marvell.com>
Alejandro Lucero alejandro.lucero@netronome.com<mailto:alejandro.lucero@netronome.com>

error: patch failed: .mailmap:32
error: .mailmap: patch does not apply
Checking patch drivers/net/netvsc/hn_rxtx.c...
error: while searching for:
#define HN_TXD_CACHE_SIZE  32 /* per cpu tx_descriptor pool cache */
#define HN_RXQ_EVENT_DEFAULT   2048

struct hn_rxinfo {
   uint32_t    vlan_info;
   uint32_t    csum_info;
   uint32_t    hash_info;
   uint32_t    hash_value;

error: patch failed: drivers/net/netvsc/hn_rxtx.c:42
error: drivers/net/netvsc/hn_rxtx.c: patch does not apply
Checking patch drivers/net/netvsc/ndis.h...
error: while searching for:
 */

/* VLAN */
#define    NDIS_VLAN_INFO_SIZE     sizeof(uint32_t)
#define    NDIS_VLAN_INFO_PRI_MASK     0x0007
#define    NDIS_VLAN_INFO_CFI_MASK     0x0008
#define    NDIS_VLAN_INFO_ID_MASK      0xfff0
#define    NDIS_VLAN_INFO_MAKE(id, pri, cfi)   \
   (((pri) & NDIS_VLAN_INFO_PRI_MASK) |    \
    (((cfi) & 0x1) << 3) | (((id) & 0xfff) << 4))
#define    NDIS_VLAN_INFO_ID(inf)      (((inf) & NDIS_VLAN_INFO_ID_MASK) >> 4)
#define    NDIS_VLAN_INFO_CFI(inf)     (((inf) & NDIS_VLAN_INFO_CFI_MASK) >> 3)
#define    NDIS_VLAN_INFO_PRI(inf)     ((inf) & NDIS_VLAN_INFO_PRI_MASK)

/* Reception checksum */
#define    NDIS_RXCSUM_INFO_SIZE       sizeof(uint32_t)

error: patch failed: drivers/net/netvsc/ndis.h:316
error: drivers/net/netvsc/ndis.h: patch does not apply

|WARNING| pw136534 [PATCH] net/netvsc: fix parsing of VLAN metadata

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136534

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#159: FILE: drivers/net/netvsc/hn_rxtx.c:51:
+   struct ndis_pkt_vlan_info vlan_info;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#168: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+           info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#168: FILE: drivers/net/netvsc/hn_rxtx.c:485:
+           info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#178: FILE: drivers/net/netvsc/hn_rxtx.c:619:
+   if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {$

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (3, 7)
#178: FILE: drivers/net/netvsc/hn_rxtx.c:619:
+   if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {
+       m->vlan_tci = info->vlan_info.vlanid |

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#179: FILE: drivers/net/netvsc/hn_rxtx.c:620:
+       m->vlan_tci = info->vlan_info.vlanid |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#180: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+               (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#180: FILE: drivers/net/netvsc/hn_rxtx.c:621:
+               (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#181: FILE: drivers/net/netvsc/hn_rxtx.c:622:
+               (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: drivers/net/netvsc/hn_rxtx.c:622:
+               (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#190: FILE: drivers/net/netvsc/hn_rxtx.c:679:
+       .vlan_info.value = HN_NDIS_VLAN_INFO_INVALID,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#199: FILE: drivers/net/netvsc/hn_rxtx.c:1342:
+       struct ndis_pkt_vlan_info *vlan = (struct ndis_pkt_vlan_info *)pi_data;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#200: FILE: drivers/net/netvsc/hn_rxtx.c:1343:
+       vlan->value = 0;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#201: FILE: drivers/net/netvsc/hn_rxtx.c:1344:
+       vlan->vlanid = (m->vlan_tci & HN_VLAN_VID_MASK);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#202: FILE: drivers/net/netvsc/hn_rxtx.c:1345:
+       vlan->cfi = (!!(m->vlan_tci & HN_VLAN_CFI_MASK));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#203: FILE: drivers/net/netvsc/hn_rxtx.c:1346:
+       vlan->pri = ((m->vlan_tci & HN_VLAN_PRIO_MASK) >> HN_VLAN_PRIO_SHIFT);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#226: FILE: drivers/net/netvsc/ndis.h:320:
+   union {$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#227: FILE: drivers/net/netvsc/ndis.h:321:
+       struct {$

ERROR:CODE_INDENT: code indent should use tabs where possible
#228: FILE: drivers/net/netvsc/ndis.h:322:
+           uint32_t pri:3; /* User Priority */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#228: FILE: drivers/net/netvsc/ndis.h:322:
+           uint32_t pri:3; /* User Priority */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#229: FILE: drivers/net/netvsc/ndis.h:323:
+           uint32_t cfi:1; /* Canonical Format ID / DEI */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#229: FILE: drivers/net/netvsc/ndis.h:323:
+           uint32_t cfi:1; /* Canonical Format ID / DEI */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: drivers/net/netvsc/ndis.h:324:
+           uint32_t vlanid:12; /* VLAN ID */$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#230: FILE: drivers/net/netvsc/ndis.h:324:
+           uint32_t vlanid:12; /* VLAN ID */$

ERROR:CODE_INDENT: code indent should use tabs where possible
#231: FILE: drivers/net/netvsc/ndis.h:325:
+           uint32_t reserved:16;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#231: FILE: drivers/net/netvsc/ndis.h:325:
+           uint32_t reserved:16;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#232: FILE: drivers/net/netvsc/ndis.h:326:
+       };$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#233: FILE: drivers/net/netvsc/ndis.h:327:
+       uint32_t value;$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#234: FILE: drivers/net/netvsc/ndis.h:328:
+   };$

ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Alan Elder <alan.elder@microsoft.com>'

total: 8 errors, 22 warnings, 0 checks, 90 lines checked

|WARNING| pw136534 [PATCH] net/netvsc: fix parsing of VLAN metadata

[dpdklab]

Test-Label: iol-testing
Test-Status: WARNING
http://dpdk.org/patch/136534

_apply patch failure_

Submitter: Alan Elder <alan.elder@microsoft.com>
Date: Thursday, February 08 2024 14:12:38 
Applied on: CommitID:805c5507267b6ef7a0cdcfc33aa326bc1de8c80b
Apply patch set 136534 failed:

Cloning the DPDK mirror at: https://github.com/DPDK/dpdk.git (Attempt 1 of 3)
Trying to checkout branch: main
Checked out to main (a4ce111cc89f580b8c4aad51bdb061acbdfde86b)
Done: main commit a4ce111cc89f580b8c4aad51bdb061acbdfde86b
Trying to checkout branch: origin/next-net-for-main
Checked out to next-net-for-main (805c5507267b6ef7a0cdcfc33aa326bc1de8c80b)
Applying patch...

Failed to apply patch:
Applying: net/netvsc: fix parsing of VLAN metadata
error: patch failed: .mailmap:32
error: .mailmap: patch does not apply
error: patch failed: drivers/net/netvsc/hn_rxtx.c:42
error: drivers/net/netvsc/hn_rxtx.c: patch does not apply
error: patch failed: drivers/net/netvsc/ndis.h:316
error: drivers/net/netvsc/ndis.h: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Using index info to reconstruct a base tree...
M	.mailmap
M	drivers/net/netvsc/hn_rxtx.c
Patch failed at 0001 net/netvsc: fix parsing of VLAN metadata
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


Trying to checkout branch: main
Checked out to main (805c5507267b6ef7a0cdcfc33aa326bc1de8c80b)
Applying patch...

Failed to apply patch:
Applying: net/netvsc: fix parsing of VLAN metadata
error: patch failed: .mailmap:32
error: .mailmap: patch does not apply
error: patch failed: drivers/net/netvsc/hn_rxtx.c:42
error: drivers/net/netvsc/hn_rxtx.c: patch does not apply
error: patch failed: drivers/net/netvsc/ndis.h:316
error: drivers/net/netvsc/ndis.h: patch does not apply
error: Did you hand edit your patch?
It does not apply to blobs recorded in its index.
hint: Use 'git am --show-current-patch' to see the failed patch
Using index info to reconstruct a base tree...
M	.mailmap
M	drivers/net/netvsc/hn_rxtx.c
Patch failed at 0001 net/netvsc: fix parsing of VLAN metadata
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".


https://lab.dpdk.org/results/dashboard/patchsets/29094/

UNH-IOL DPDK Community Lab