From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4A5A43ADF for ; Thu, 8 Feb 2024 15:16:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0A014028B; Thu, 8 Feb 2024 15:16:20 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id B752F40278 for ; Thu, 8 Feb 2024 15:16:19 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id A8BA8121F0B; Thu, 8 Feb 2024 15:16:19 +0100 (CET) Subject: |WARNING| pw136534 [PATCH] net/netvsc: fix parsing of VLAN metadata In-Reply-To: References: To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Alan Elder Message-Id: <20240208141619.A8BA8121F0B@dpdk.org> Date: Thu, 8 Feb 2024 15:16:19 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/136534 _coding style issues_ WARNING:LEADING_SPACE: please, no spaces at the start of a line #159: FILE: drivers/net/netvsc/hn_rxtx.c:51: + struct ndis_pkt_vlan_info vlan_info;$ ERROR:CODE_INDENT: code indent should use tabs where possible #168: FILE: drivers/net/netvsc/hn_rxtx.c:485: + info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #168: FILE: drivers/net/netvsc/hn_rxtx.c:485: + info->vlan_info = *((const struct ndis_pkt_vlan_info *)data);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #178: FILE: drivers/net/netvsc/hn_rxtx.c:619: + if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) {$ WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (3, 7) #178: FILE: drivers/net/netvsc/hn_rxtx.c:619: + if (info->vlan_info.value != HN_NDIS_VLAN_INFO_INVALID) { + m->vlan_tci = info->vlan_info.vlanid | WARNING:LEADING_SPACE: please, no spaces at the start of a line #179: FILE: drivers/net/netvsc/hn_rxtx.c:620: + m->vlan_tci = info->vlan_info.vlanid |$ ERROR:CODE_INDENT: code indent should use tabs where possible #180: FILE: drivers/net/netvsc/hn_rxtx.c:621: + (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #180: FILE: drivers/net/netvsc/hn_rxtx.c:621: + (info->vlan_info.pri << HN_VLAN_PRIO_SHIFT) |$ ERROR:CODE_INDENT: code indent should use tabs where possible #181: FILE: drivers/net/netvsc/hn_rxtx.c:622: + (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #181: FILE: drivers/net/netvsc/hn_rxtx.c:622: + (info->vlan_info.cfi ? HN_VLAN_CFI_MASK : 0);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #190: FILE: drivers/net/netvsc/hn_rxtx.c:679: + .vlan_info.value = HN_NDIS_VLAN_INFO_INVALID,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #199: FILE: drivers/net/netvsc/hn_rxtx.c:1342: + struct ndis_pkt_vlan_info *vlan = (struct ndis_pkt_vlan_info *)pi_data;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #200: FILE: drivers/net/netvsc/hn_rxtx.c:1343: + vlan->value = 0;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #201: FILE: drivers/net/netvsc/hn_rxtx.c:1344: + vlan->vlanid = (m->vlan_tci & HN_VLAN_VID_MASK);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #202: FILE: drivers/net/netvsc/hn_rxtx.c:1345: + vlan->cfi = (!!(m->vlan_tci & HN_VLAN_CFI_MASK));$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #203: FILE: drivers/net/netvsc/hn_rxtx.c:1346: + vlan->pri = ((m->vlan_tci & HN_VLAN_PRIO_MASK) >> HN_VLAN_PRIO_SHIFT);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #226: FILE: drivers/net/netvsc/ndis.h:320: + union {$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #227: FILE: drivers/net/netvsc/ndis.h:321: + struct {$ ERROR:CODE_INDENT: code indent should use tabs where possible #228: FILE: drivers/net/netvsc/ndis.h:322: + uint32_t pri:3; /* User Priority */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #228: FILE: drivers/net/netvsc/ndis.h:322: + uint32_t pri:3; /* User Priority */$ ERROR:CODE_INDENT: code indent should use tabs where possible #229: FILE: drivers/net/netvsc/ndis.h:323: + uint32_t cfi:1; /* Canonical Format ID / DEI */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #229: FILE: drivers/net/netvsc/ndis.h:323: + uint32_t cfi:1; /* Canonical Format ID / DEI */$ ERROR:CODE_INDENT: code indent should use tabs where possible #230: FILE: drivers/net/netvsc/ndis.h:324: + uint32_t vlanid:12; /* VLAN ID */$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #230: FILE: drivers/net/netvsc/ndis.h:324: + uint32_t vlanid:12; /* VLAN ID */$ ERROR:CODE_INDENT: code indent should use tabs where possible #231: FILE: drivers/net/netvsc/ndis.h:325: + uint32_t reserved:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #231: FILE: drivers/net/netvsc/ndis.h:325: + uint32_t reserved:16;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #232: FILE: drivers/net/netvsc/ndis.h:326: + };$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #233: FILE: drivers/net/netvsc/ndis.h:327: + uint32_t value;$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #234: FILE: drivers/net/netvsc/ndis.h:328: + };$ ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author 'Alan Elder ' total: 8 errors, 22 warnings, 0 checks, 90 lines checked