From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: |WARNING| pw136677 [PATCH v3] mbuf: deprecate GCC marker in rte mbuf struct
Date: Wed, 14 Feb 2024 00:34:39 +0100 (CET) [thread overview]
Message-ID: <20240213233439.9FDA2121F0B@dpdk.org> (raw)
In-Reply-To: <1707867209-1901-2-git-send-email-roretzla@linux.microsoft.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/136677
_coding style issues_
ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#80: FILE: lib/eal/include/rte_common.h:585:
+#define __rte_marker(type, name) type name /* __rte_deprecated */
WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#184: FILE: lib/mbuf/rte_mbuf_core.h:502:
+ * Reference counter. Its size should at least equal to the size
WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#188: FILE: lib/mbuf/rte_mbuf_core.h:506:
+ * rte_mbuf_refcnt_set(). The functionality of these functions (atomic,
WARNING:LONG_LINE_COMMENT: line length of 107 exceeds 100 columns
#189: FILE: lib/mbuf/rte_mbuf_core.h:507:
+ * or non-atomic) is controlled by the RTE_MBUF_REFCNT_ATOMIC flag.
WARNING:LONG_LINE_COMMENT: line length of 106 exceeds 100 columns
#194: FILE: lib/mbuf/rte_mbuf_core.h:512:
+ * Number of segments. Only valid for the first segment of an mbuf
WARNING:LONG_LINE_COMMENT: line length of 104 exceeds 100 columns
#199: FILE: lib/mbuf/rte_mbuf_core.h:517:
+ /** Input port (16 bits to support more than 256 virtual ports).
WARNING:LONG_LINE_COMMENT: line length of 111 exceeds 100 columns
#200: FILE: lib/mbuf/rte_mbuf_core.h:518:
+ * The event eth Tx adapter uses this field to specify the output port.
WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#241: FILE: lib/mbuf/rte_mbuf_core.h:532:
+ * The packet type, which is the combination of outer/inner L2, L3, L4
WARNING:LONG_LINE_COMMENT: line length of 112 exceeds 100 columns
#242: FILE: lib/mbuf/rte_mbuf_core.h:533:
+ * and tunnel types. The packet_type is about data really present in the
WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#243: FILE: lib/mbuf/rte_mbuf_core.h:534:
+ * mbuf. Example: if vlan stripping is enabled, a received vlan packet
WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#244: FILE: lib/mbuf/rte_mbuf_core.h:535:
+ * would have RTE_PTYPE_L2_ETHER and not RTE_PTYPE_L2_VLAN because the
WARNING:LONG_LINE_COMMENT: line length of 110 exceeds 100 columns
#248: FILE: lib/mbuf/rte_mbuf_core.h:539:
+ uint32_t packet_type; /**< L2/L3/L4 and tunnel information. */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#251: FILE: lib/mbuf/rte_mbuf_core.h:542:
+ uint8_t l2_type:4; /**< (Outer) L2 type. */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#252: FILE: lib/mbuf/rte_mbuf_core.h:543:
+ uint8_t l3_type:4; /**< (Outer) L3 type. */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#253: FILE: lib/mbuf/rte_mbuf_core.h:544:
+ uint8_t l4_type:4; /**< (Outer) L4 type. */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#257: FILE: lib/mbuf/rte_mbuf_core.h:548:
+ /**< ESP next protocol type, valid if
WARNING:LONG_LINE_COMMENT: line length of 106 exceeds 100 columns
#258: FILE: lib/mbuf/rte_mbuf_core.h:549:
+ * RTE_PTYPE_TUNNEL_ESP tunnel type is set
WARNING:LONG_LINE_COMMENT: line length of 103 exceeds 100 columns
#269: FILE: lib/mbuf/rte_mbuf_core.h:560:
+ uint8_t inner_l4_type:4; /**< Inner L4 type. */
WARNING:LONG_LINE_COMMENT: line length of 109 exceeds 100 columns
#272: FILE: lib/mbuf/rte_mbuf_core.h:563:
+ uint32_t pkt_len; /**< Total pkt len: sum of all segments. */
WARNING:LONG_LINE_COMMENT: line length of 101 exceeds 100 columns
#417: FILE: lib/mbuf/rte_mbuf_core.h:627:
+ * when the next pointer is in first cache line (i.e. RTE_IOVA_IN_MBUF is 0).
total: 1 errors, 19 warnings, 420 lines checked
prev parent reply other threads:[~2024-02-13 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1707867209-1901-2-git-send-email-roretzla@linux.microsoft.com>
2024-02-13 23:11 ` |SUCCESS| " qemudev
2024-02-13 23:15 ` qemudev
2024-02-13 23:34 ` checkpatch [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240213233439.9FDA2121F0B@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).