From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AA9843C35 for ; Thu, 29 Feb 2024 10:37:17 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45619402D5; Thu, 29 Feb 2024 10:37:17 +0100 (CET) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 631EF402B4 for ; Thu, 29 Feb 2024 10:37:15 +0100 (CET) Received: by dpdk.org (Postfix, from userid 65534) id 55C83122320; Thu, 29 Feb 2024 10:37:15 +0100 (CET) Subject: |WARNING| pw137463 [PATCH] net/mlx5: fix the counters map in bonding mode In-Reply-To: <20240229093456.306768-1-bingz@nvidia.com> References: <20240229093456.306768-1-bingz@nvidia.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Bing Zhao Message-Id: <20240229093715.55C83122320@dpdk.org> Date: Thu, 29 Feb 2024 10:37:15 +0100 (CET) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/137463 _coding style issues_ WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #232: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1336: + * @param bond_master WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #233: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1337: + * Indicate if the device is a bond master. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #243: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1346: +mlx5_os_read_dev_counters(struct rte_eth_dev *dev, bool bond_master, uint64_t *stats) WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #252: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1354: + if (bond_master) { WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #287: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1389: + * @param bond_master WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #288: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1390: + * Indicate if the device is a bond master. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #301: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1400: +mlx5_os_get_stats_n(struct rte_eth_dev *dev, bool bond_master, WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #313: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1411: + if (bond_master) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #319: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1416: + " statistics for the 1st slave, %d", PORT_ID(priv), ret); WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #327: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1424: + " statistics for the 2nd slave, %d", PORT_ID(priv), ret); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #354: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1661: +mlx5_os_get_stats_strings(struct rte_eth_dev *dev, bool bond_master, WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #370: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1677: + if (bond_master) WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #395: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1702: + if (!bond_master) { WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #411: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1718: + DRV_LOG(WARNING, "port %u unable to get statistic names for 2nd slave with %d", WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #415: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1722: + /* The 2nd slave port may have a different strings set, based on the configuration. */ WARNING:TYPO_SPELLING: 'slave' may be misspelled - perhaps 'secondary'? #425: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1732: + /* Already mapped in the 1st slave port. */ WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #465: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1773: + bool bond_master = (priv->master && priv->pf_bond >= 0); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #465: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1773: + bool bond_master = (priv->master && priv->pf_bond >= 0); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #470: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1777: + ret = mlx5_os_get_stats_n(dev, bond_master, &dev_stats_n, &dev_stats_n_2nd); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #502: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1794: + ret = mlx5_os_get_stats_strings(dev, bond_master, strings, WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #538: FILE: drivers/net/mlx5/linux/mlx5_ethdev_os.c:1804: + ret = mlx5_os_read_dev_counters(dev, bond_master, xstats_ctrl->base); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #576: FILE: drivers/net/mlx5/mlx5.h:2182: +int mlx5_os_read_dev_counters(struct rte_eth_dev *dev, bool bond_master, uint64_t *stats); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #577: FILE: drivers/net/mlx5/mlx5.h:2183: +int mlx5_os_get_stats_n(struct rte_eth_dev *dev, bool bond_master, WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #598: FILE: drivers/net/mlx5/mlx5_stats.c:48: + bool bond_master = (priv->master && priv->pf_bond >= 0); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #598: FILE: drivers/net/mlx5/mlx5_stats.c:48: + bool bond_master = (priv->master && priv->pf_bond >= 0); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #608: FILE: drivers/net/mlx5/mlx5_stats.c:53: + ret = mlx5_os_get_stats_n(dev, bond_master, &stats_n, &stats_n_2nd); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #621: FILE: drivers/net/mlx5/mlx5_stats.c:66: + (bond_master && xstats_ctrl->stats_n_2nd != stats_n_2nd)) WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #625: FILE: drivers/net/mlx5/mlx5_stats.c:68: + ret = mlx5_os_read_dev_counters(dev, bond_master, counters); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #643: FILE: drivers/net/mlx5/mlx5_stats.c:245: + bool bond_master = (priv->master && priv->pf_bond >= 0); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #643: FILE: drivers/net/mlx5/mlx5_stats.c:245: + bool bond_master = (priv->master && priv->pf_bond >= 0); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #647: FILE: drivers/net/mlx5/mlx5_stats.c:247: + ret = mlx5_os_get_stats_n(dev, bond_master, &stats_n, &stats_n_2nd); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #657: FILE: drivers/net/mlx5/mlx5_stats.c:254: + (bond_master && xstats_ctrl->stats_n_2nd != stats_n_2nd)) WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #674: FILE: drivers/net/mlx5/mlx5_stats.c:265: + ret = mlx5_os_read_dev_counters(dev, bond_master, counters); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #692: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:186: + * @param bond_master WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #693: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:187: + * Indicate if the device is a bond master. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #706: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:197: +mlx5_os_get_stats_n(struct rte_eth_dev *dev, bool bond_master, WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #710: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:201: + RTE_SET_USED(bond_master); WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #720: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:233: + * @param bond_master WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #721: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:234: + * Indicate if the device is a bond master. WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #730: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:243: +mlx5_os_read_dev_counters(struct rte_eth_dev *dev, bool bond_master, uint64_t *stats) WARNING:TYPO_SPELLING: 'master' may be misspelled - perhaps 'primary'? #733: FILE: drivers/net/mlx5/windows/mlx5_ethdev_os.c:246: + RTE_SET_USED(bond_master); total: 0 errors, 41 warnings, 0 checks, 532 lines checked