automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw137628 [PATCH 54/71] net/bnx2x: replace use of fixed size rte_memcpy
Date: Fri,  1 Mar 2024 00:09:57 +0100 (CET)	[thread overview]
Message-ID: <20240229230957.7289912232A@dpdk.org> (raw)
In-Reply-To: <20240229225936.483472-55-stephen@networkplumber.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/137628

_coding style issues_


WARNING:LEADING_SPACE: please, no spaces at the start of a line
#181: FILE: drivers/net/bnx2x/bnx2x_stats.c:820:
+    memcpy(old, new, sizeof(struct nig_stats));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#185: FILE: drivers/net/bnx2x/bnx2x_stats.c:822:
+    memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]),$

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around estats->rx_stat_ifhcinbadoctets_hi
#185: FILE: drivers/net/bnx2x/bnx2x_stats.c:822:
+    memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]),

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around pstats->mac_stx[1]
#185: FILE: drivers/net/bnx2x/bnx2x_stats.c:822:
+    memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]),

ERROR:CODE_INDENT: code indent should use tabs where possible
#186: FILE: drivers/net/bnx2x/bnx2x_stats.c:823:
+           sizeof(struct mac_stx));$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#186: FILE: drivers/net/bnx2x/bnx2x_stats.c:823:
+           sizeof(struct mac_stx));$

total: 1 errors, 3 warnings, 2 checks, 125 lines checked

           reply	other threads:[~2024-02-29 23:09 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20240229225936.483472-55-stephen@networkplumber.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240229230957.7289912232A@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).