automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Ferruh Yigit <ferruh.yigit@amd.com>
Subject: |WARNING| pw139608 [PATCH] eal/linux: enhanced error handling for affinity
Date: Mon, 22 Apr 2024 15:51:18 +0200 (CEST)	[thread overview]
Message-ID: <20240422135118.75850121EF1@dpdk.org> (raw)
In-Reply-To: <20240422134917.3740545-1-ferruh.yigit@amd.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/139608

_coding style issues_


ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#166: FILE: lib/eal/unix/rte_thread.c:119:
+static void cpuset_to_string(const cpu_set_t *cpuset,
+			char *cpus_str, size_t cpus_str_size) {

ERROR:C99_COMMENTS: do not use C99 // comments
#169: FILE: lib/eal/unix/rte_thread.c:122:
+	// Track the current position in the string

ERROR:C99_COMMENTS: do not use C99 // comments
#172: FILE: lib/eal/unix/rte_thread.c:125:
+	// Clear the string buffer

WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#174: FILE: lib/eal/unix/rte_thread.c:127:
+	cpus_str_size = RTE_MAX_LCORE < cpus_str_size ?

ERROR:C99_COMMENTS: do not use C99 // comments
#177: FILE: lib/eal/unix/rte_thread.c:130:
+	// Iterate over each CPU core, and check if it is included in the set

ERROR:C99_COMMENTS: do not use C99 // comments
#180: FILE: lib/eal/unix/rte_thread.c:133:
+			// Append the current CPU number to the string

ERROR:C99_COMMENTS: do not use C99 // comments
#190: FILE: lib/eal/unix/rte_thread.c:143:
+	// Ensure the string is properly terminated

total: 6 errors, 1 warnings, 76 lines checked

  parent reply	other threads:[~2024-04-22 13:51 UTC|newest]

Thread overview: 110+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240422134917.3740545-1-ferruh.yigit@amd.com>
2024-04-22 13:24 ` |SUCCESS| " qemudev
2024-04-22 13:28 ` qemudev
2024-04-22 13:51 ` checkpatch [this message]
2024-04-22 14:27 ` |SUCCESS| pw139608 [PATCH] eal/linux: enhanced error handling for af dpdklab
2024-04-22 14:28 ` dpdklab
2024-04-22 14:28 ` dpdklab
2024-04-22 14:28 ` dpdklab
2024-04-22 14:28 ` dpdklab
2024-04-22 14:29 ` dpdklab
2024-04-22 14:29 ` dpdklab
2024-04-22 14:30 ` dpdklab
2024-04-22 14:30 ` dpdklab
2024-04-22 14:30 ` dpdklab
2024-04-22 14:30 ` dpdklab
2024-04-22 14:30 ` dpdklab
2024-04-22 14:30 ` dpdklab
2024-04-22 14:31 ` dpdklab
2024-04-22 14:31 ` dpdklab
2024-04-22 14:31 ` dpdklab
2024-04-22 14:32 ` dpdklab
2024-04-22 14:32 ` dpdklab
2024-04-22 14:32 ` dpdklab
2024-04-22 14:32 ` dpdklab
2024-04-22 14:33 ` dpdklab
2024-04-22 14:33 ` dpdklab
2024-04-22 14:33 ` dpdklab
2024-04-22 14:33 ` dpdklab
2024-04-22 14:34 ` dpdklab
2024-04-22 14:34 ` dpdklab
2024-04-22 14:34 ` dpdklab
2024-04-22 14:35 ` dpdklab
2024-04-22 14:36 ` dpdklab
2024-04-22 14:37 ` dpdklab
2024-04-22 14:37 ` dpdklab
2024-04-22 14:38 ` dpdklab
2024-04-22 14:39 ` dpdklab
2024-04-22 14:39 ` dpdklab
2024-04-22 14:39 ` dpdklab
2024-04-22 14:39 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:40 ` dpdklab
2024-04-22 14:41 ` dpdklab
2024-04-22 14:41 ` dpdklab
2024-04-22 14:41 ` dpdklab
2024-04-22 14:41 ` dpdklab
2024-04-22 14:41 ` dpdklab
2024-04-22 14:42 ` dpdklab
2024-04-22 14:42 ` dpdklab
2024-04-22 14:42 ` dpdklab
2024-04-22 14:42 ` dpdklab
2024-04-22 14:42 ` dpdklab
2024-04-22 14:43 ` dpdklab
2024-04-22 14:43 ` dpdklab
2024-04-22 14:43 ` dpdklab
2024-04-22 14:44 ` dpdklab
2024-04-22 14:45 ` |SUCCESS| pw139608 [PATCH] eal/linux: enhanced error handling for affinity 0-day Robot
2024-04-22 14:45 ` |SUCCESS| pw139608 [PATCH] eal/linux: enhanced error handling for af dpdklab
2024-04-22 14:45 ` dpdklab
2024-04-22 14:45 ` dpdklab
2024-04-22 14:46 ` dpdklab
2024-04-22 14:46 ` dpdklab
2024-04-22 14:48 ` dpdklab
2024-04-22 14:50 ` dpdklab
2024-04-22 14:51 ` dpdklab
2024-04-22 14:52 ` dpdklab
2024-04-22 14:54 ` dpdklab
2024-04-22 14:55 ` dpdklab
2024-04-22 14:55 ` dpdklab
2024-04-22 14:56 ` dpdklab
2024-04-22 14:57 ` dpdklab
2024-04-22 14:58 ` dpdklab
2024-04-22 14:59 ` dpdklab
2024-04-22 14:59 ` dpdklab
2024-04-22 14:59 ` dpdklab
2024-04-22 15:01 ` dpdklab
2024-04-22 15:02 ` dpdklab
2024-04-22 15:03 ` dpdklab
2024-04-22 15:03 ` dpdklab
2024-04-22 15:07 ` dpdklab
2024-04-22 15:10 ` dpdklab
2024-04-22 15:25 ` dpdklab
2024-04-22 15:26 ` dpdklab
2024-04-22 15:26 ` dpdklab
2024-04-22 15:47 ` dpdklab
2024-04-22 15:48 ` dpdklab
2024-04-26 22:25 ` dpdklab
2024-04-26 22:31 ` dpdklab
2024-04-26 22:32 ` dpdklab
2024-04-26 22:58 ` dpdklab
2024-04-26 23:05 ` dpdklab
2024-04-26 23:07 ` dpdklab
2024-04-26 23:10 ` dpdklab
2024-04-26 23:16 ` dpdklab
2024-04-26 23:17 ` dpdklab
2024-04-26 23:17 ` dpdklab
2024-04-26 23:18 ` dpdklab
2024-04-26 23:18 ` dpdklab
2024-04-26 23:18 ` dpdklab
2024-04-26 23:18 ` dpdklab
2024-04-26 23:21 ` dpdklab
2024-04-26 23:21 ` dpdklab
2024-04-26 23:25 ` dpdklab
2024-04-26 23:28 ` dpdklab
2024-04-26 23:31 ` dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240422135118.75850121EF1@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).