From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Vipin Varghese <vipin.varghese@amd.com>
Subject: |WARNING| pw143404 [RFC 2/2] eal/lcore: add llc aware for each macro
Date: Tue, 27 Aug 2024 17:12:53 +0200 (CEST) [thread overview]
Message-ID: <20240827151253.55888120778@dpdk.org> (raw)
In-Reply-To: <20240827151014.201-3-vipin.varghese@amd.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143404
_coding style issues_
WARNING:TYPO_SPELLING: 'availble' may be misspelled - perhaps 'available'?
#115:
availble lcores.
WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#168: FILE: lib/eal/include/rte_lcore.h:230:
+unsigned int rte_get_llc_lcore (unsigned int i, rte_cpuset_t *llc_cpu, unsigned int *start, unsigned int *end);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#168: FILE: lib/eal/include/rte_lcore.h:230:
+unsigned int rte_get_llc_lcore (unsigned int i, rte_cpuset_t *llc_cpu, unsigned int *start, unsigned int *end);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#169: FILE: lib/eal/include/rte_lcore.h:231:
+unsigned int rte_get_llc_first_lcores (rte_cpuset_t *llc_cpu);
WARNING:LONG_LINE: line length of 140 exceeds 100 columns
#170: FILE: lib/eal/include/rte_lcore.h:232:
+unsigned int rte_get_llc_n_lcore (unsigned int i, rte_cpuset_t *llc_cpu, unsigned int *start, unsigned int *end, unsigned int n, bool skip);
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#170: FILE: lib/eal/include/rte_lcore.h:232:
+unsigned int rte_get_llc_n_lcore (unsigned int i, rte_cpuset_t *llc_cpu, unsigned int *start, unsigned int *end, unsigned int n, bool skip);
WARNING:REPEATED_WORD: Possible repeated word: 'the'
#188: FILE: lib/eal/include/rte_lcore.h:252:
+/** Browse all the the cores in the provided llc domain **/
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#191: FILE: lib/eal/include/rte_lcore.h:255:
+ rte_cpuset_t llc_foreach_first_lcores; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#192: FILE: lib/eal/include/rte_lcore.h:256:
+ CPU_ZERO(&llc_foreach_first_lcores); i = 0; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#193: FILE: lib/eal/include/rte_lcore.h:257:
+ unsigned int llc_foreach_num_iter = rte_get_llc_first_lcores(&llc_foreach_first_lcores); \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#194: FILE: lib/eal/include/rte_lcore.h:258:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#194: FILE: lib/eal/include/rte_lcore.h:258:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#195: FILE: lib/eal/include/rte_lcore.h:259:
+ for (; i < RTE_MAX_LCORE; i++) \
ERROR:TRAILING_WHITESPACE: trailing whitespace
#197: FILE: lib/eal/include/rte_lcore.h:261:
+^I$
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#199: FILE: lib/eal/include/rte_lcore.h:263:
+ rte_cpuset_t llc_foreach_first_lcores; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#200: FILE: lib/eal/include/rte_lcore.h:264:
+ CPU_ZERO(&llc_foreach_first_lcores); i = 0; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#201: FILE: lib/eal/include/rte_lcore.h:265:
+ unsigned int llc_foreach_num_iter = rte_get_llc_first_lcores(&llc_foreach_first_lcores); \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#203: FILE: lib/eal/include/rte_lcore.h:267:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#203: FILE: lib/eal/include/rte_lcore.h:267:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#204: FILE: lib/eal/include/rte_lcore.h:268:
+ for (; i < RTE_MAX_LCORE; i++) \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#208: FILE: lib/eal/include/rte_lcore.h:272:
+ rte_cpuset_t llc_foreach_first_lcores; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#209: FILE: lib/eal/include/rte_lcore.h:273:
+ rte_cpuset_t llc_foreach_lcore; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#210: FILE: lib/eal/include/rte_lcore.h:274:
+ unsigned int start,end; \
ERROR:CODE_INDENT: code indent should use tabs where possible
#210: FILE: lib/eal/include/rte_lcore.h:274:
+ unsigned int start,end;^I^I^I^I^I^I^I^I^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#210: FILE: lib/eal/include/rte_lcore.h:274:
+ unsigned int start,end;^I^I^I^I^I^I^I^I^I^I\$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#210: FILE: lib/eal/include/rte_lcore.h:274:
+ unsigned int start,end; \
^
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#211: FILE: lib/eal/include/rte_lcore.h:275:
+ CPU_ZERO(&llc_foreach_first_lcores); i = 0; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#212: FILE: lib/eal/include/rte_lcore.h:276:
+ unsigned int llc_foreach_num_iter = rte_get_llc_first_lcores(&llc_foreach_first_lcores); \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#213: FILE: lib/eal/include/rte_lcore.h:277:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#213: FILE: lib/eal/include/rte_lcore.h:277:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#214: FILE: lib/eal/include/rte_lcore.h:278:
+ for (unsigned int llc_i = i; llc_i < RTE_MAX_LCORE; llc_i++) \
WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#215: FILE: lib/eal/include/rte_lcore.h:279:
+ if (CPU_ISSET(llc_i, &llc_foreach_first_lcores) && rte_get_llc_lcore (llc_i, &llc_foreach_lcore, &start, &end)) \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#215: FILE: lib/eal/include/rte_lcore.h:279:
+ if (CPU_ISSET(llc_i, &llc_foreach_first_lcores) && rte_get_llc_lcore (llc_i, &llc_foreach_lcore, &start, &end)) \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#216: FILE: lib/eal/include/rte_lcore.h:280:
+ for (i = start; (i <= end); i++) \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#220: FILE: lib/eal/include/rte_lcore.h:284:
+ rte_cpuset_t llc_foreach_first_lcores; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#221: FILE: lib/eal/include/rte_lcore.h:285:
+ rte_cpuset_t llc_foreach_lcore; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#222: FILE: lib/eal/include/rte_lcore.h:286:
+ unsigned int start,end; \
ERROR:CODE_INDENT: code indent should use tabs where possible
#222: FILE: lib/eal/include/rte_lcore.h:286:
+ unsigned int start,end;^I^I^I^I^I^I^I^I^I^I\$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#222: FILE: lib/eal/include/rte_lcore.h:286:
+ unsigned int start,end;^I^I^I^I^I^I^I^I^I^I\$
ERROR:SPACING: space required after that ',' (ctx:VxV)
#222: FILE: lib/eal/include/rte_lcore.h:286:
+ unsigned int start,end; \
^
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#223: FILE: lib/eal/include/rte_lcore.h:287:
+ CPU_ZERO(&llc_foreach_first_lcores); i = 0; \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#224: FILE: lib/eal/include/rte_lcore.h:288:
+ unsigned int llc_foreach_num_iter = rte_get_llc_first_lcores(&llc_foreach_first_lcores); \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#225: FILE: lib/eal/include/rte_lcore.h:289:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#225: FILE: lib/eal/include/rte_lcore.h:289:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : i; \
WARNING:LONG_LINE: line length of 137 exceeds 100 columns
#226: FILE: lib/eal/include/rte_lcore.h:290:
+ for (unsigned int llc_i = i; llc_i < RTE_MAX_LCORE; llc_i++) \
WARNING:LONG_LINE: line length of 129 exceeds 100 columns
#227: FILE: lib/eal/include/rte_lcore.h:291:
+ if (CPU_ISSET(llc_i, &llc_foreach_first_lcores) && rte_get_llc_lcore (llc_i, &llc_foreach_lcore, &start, &end)) \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#227: FILE: lib/eal/include/rte_lcore.h:291:
+ if (CPU_ISSET(llc_i, &llc_foreach_first_lcores) && rte_get_llc_lcore (llc_i, &llc_foreach_lcore, &start, &end)) \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#228: FILE: lib/eal/include/rte_lcore.h:292:
+ for (i = start + 1; (i <= end); i++) \
ERROR:SPACING: space required after that ',' (ctx:VxV)
#231: FILE: lib/eal/include/rte_lcore.h:295:
+#define RTE_LCORE_FOREACH_LLC_FIRST_N_WORKER(i,n) \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#234: FILE: lib/eal/include/rte_lcore.h:298:
+ unsigned int start,end, temp_count; \
^
WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#236: FILE: lib/eal/include/rte_lcore.h:300:
+ unsigned int llc_foreach_num_iter = rte_get_llc_first_lcores(&llc_foreach_first_lcores); \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#237: FILE: lib/eal/include/rte_lcore.h:301:
+ i = (0 == llc_foreach_num_iter) ? RTE_MAX_LCORE : 0; \
WARNING:LONG_LINE: line length of 153 exceeds 100 columns
#239: FILE: lib/eal/include/rte_lcore.h:303:
+ if (CPU_ISSET(llc_i, &llc_foreach_first_lcores) && (rte_get_llc_n_lcore (llc_i, &llc_foreach_lcore, &start, &end, n, false) >= n)) \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#239: FILE: lib/eal/include/rte_lcore.h:303:
+ if (CPU_ISSET(llc_i, &llc_foreach_first_lcores) && (rte_get_llc_n_lcore (llc_i, &llc_foreach_lcore, &start, &end, n, false) >= n)) \
WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#241: FILE: lib/eal/include/rte_lcore.h:305:
+ if (CPU_ISSET(i, &llc_foreach_lcore) && (i != rte_get_main_lcore()) && (temp_count--))
ERROR:SPACING: space required after that ',' (ctx:VxV)
#243: FILE: lib/eal/include/rte_lcore.h:307:
+#define RTE_LCORE_FOREACH_LLC_SKIP_N_WORKER(i,n) \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#246: FILE: lib/eal/include/rte_lcore.h:310:
+ unsigned int start_skip,end_skip,llc_skip_i; \
^
ERROR:SPACING: space required after that ',' (ctx:VxV)
#246: FILE: lib/eal/include/rte_lcore.h:310:
+ unsigned int start_skip,end_skip,llc_skip_i; \
^
WARNING:LONG_LINE: line length of 113 exceeds 100 columns
#248: FILE: lib/eal/include/rte_lcore.h:312:
+ unsigned int llc_foreach_skip_num_iter = rte_get_llc_first_lcores(&llc_foreach_skip_first_lcores); \
WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#249: FILE: lib/eal/include/rte_lcore.h:313:
+ i = (0 == llc_foreach_skip_num_iter) ? RTE_MAX_LCORE : 0; \
WARNING:LONG_LINE: line length of 177 exceeds 100 columns
#251: FILE: lib/eal/include/rte_lcore.h:315:
+ if (CPU_ISSET(llc_skip_i, &llc_foreach_skip_first_lcores) && (rte_get_llc_n_lcore (llc_skip_i, &llc_foreach_skip_lcore, &start_skip, &end_skip, n, true) > 0)) \
WARNING:SPACING: space prohibited between function name and open parenthesis '('
#251: FILE: lib/eal/include/rte_lcore.h:315:
+ if (CPU_ISSET(llc_skip_i, &llc_foreach_skip_first_lcores) && (rte_get_llc_n_lcore (llc_skip_i, &llc_foreach_skip_lcore, &start_skip, &end_skip, n, true) > 0)) \
WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#253: FILE: lib/eal/include/rte_lcore.h:317:
+ if (CPU_ISSET(i, &llc_foreach_skip_lcore) && (i != rte_get_main_lcore()))
total: 10 errors, 53 warnings, 119 lines checked
next prev parent reply other threads:[~2024-08-27 15:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240827151014.201-3-vipin.varghese@amd.com>
2024-08-27 14:44 ` |SUCCESS| pw143403-143404 " qemudev
2024-08-27 14:48 ` qemudev
2024-08-27 15:12 ` checkpatch [this message]
2024-08-27 15:54 ` |SUCCESS| pw143403-143404 [PATCH] [RFC,2/2] eal/lcore: add llc aware dpdklab
2024-08-27 15:55 ` dpdklab
2024-08-27 15:58 ` |FAILURE| " dpdklab
2024-08-27 15:58 ` |SUCCESS| " dpdklab
2024-08-27 15:59 ` |FAILURE| " dpdklab
2024-08-27 15:59 ` dpdklab
2024-08-27 15:59 ` dpdklab
2024-08-27 15:59 ` dpdklab
2024-08-27 15:59 ` dpdklab
2024-08-27 16:00 ` dpdklab
2024-08-27 16:09 ` dpdklab
2024-08-27 16:10 ` dpdklab
2024-08-27 16:12 ` dpdklab
2024-08-27 16:14 ` |SUCCESS| " dpdklab
2024-08-27 16:16 ` dpdklab
2024-08-27 16:17 ` |FAILURE| " dpdklab
2024-08-27 16:20 ` |WARNING| " dpdklab
2024-08-27 16:24 ` |SUCCESS| " dpdklab
2024-08-27 16:29 ` dpdklab
2024-08-27 16:41 ` |WARNING| " dpdklab
2024-08-27 16:43 ` |FAILURE| pw143404 [RFC 2/2] eal/lcore: add llc aware for each macro 0-day Robot
2024-08-27 16:43 ` |SUCCESS| pw143403-143404 [PATCH] [RFC,2/2] eal/lcore: add llc aware dpdklab
2024-08-27 17:04 ` |WARNING| " dpdklab
2024-08-27 19:51 ` |SUCCESS| " dpdklab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240827151253.55888120778@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).