From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8302458A9 for ; Fri, 30 Aug 2024 16:15:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4BCF42E9D; Fri, 30 Aug 2024 16:15:16 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 2BCD94025C for ; Fri, 30 Aug 2024 16:15:15 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 20DF0120778; Fri, 30 Aug 2024 16:15:15 +0200 (CEST) Subject: |WARNING| pw143492 [PATCH 38/47] net/bnxt: tf_ulp: inline utility functions and use likely/unlikely In-Reply-To: <20240830140049.1715230-39-sriharsha.basavapatna@broadcom.com> References: <20240830140049.1715230-39-sriharsha.basavapatna@broadcom.com> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Sriharsha Basavapatna Message-Id: <20240830141515.20DF0120778@dpdk.org> Date: Fri, 30 Aug 2024 16:15:15 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/143492 _coding style issues_ WARNING:TYPO_SPELLING: 'hsi' may be misspelled - perhaps 'his'? #2630: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:20: +#include "hsi_struct_def_dpdk.h" WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'? #3543: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:933: + * the firmwware. WARNING:TYPO_SPELLING: 'appplication' may be misspelled - perhaps 'application'? #3563: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:953: + * Application to poll to get the appplication hot upgrade state from WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'? #3564: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:954: + * the firmwware. WARNING:TYPO_SPELLING: 'appplication' may be misspelled - perhaps 'application'? #3576: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:966: + * Application to poll to get the appplication count from WARNING:TYPO_SPELLING: 'firmwware' may be misspelled - perhaps 'firmware'? #3577: FILE: drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h:967: + * the firmwware. WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #3982: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:640: + if (unlikely(ulp_regfile_read(parms->regfile, tbl->pri_operand, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4023: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:722: + if (unlikely(ulp_regfile_write(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4041: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:768: + if (unlikely(ulp_regfile_write(parms->regfile, idx, tfp_cpu_to_be_64(id)))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4060: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:806: + if (unlikely(ulp_port_db_parent_mac_addr_get(parms->ulp_ctx, port_id, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4069: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:813: + if (unlikely(ulp_port_db_drv_mac_addr_get(parms->ulp_ctx, port_id, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4078: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:820: + if (unlikely(ulp_port_db_parent_vnic_get(parms->ulp_ctx, port_id, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4087: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:827: + if (unlikely(ulp_port_db_port_is_pf_get(parms->ulp_ctx, port_id, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4096: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:834: + if (unlikely(ulp_port_db_port_meta_data_get(parms->ulp_ctx, port_id, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4105: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:841: + if (unlikely(ulp_port_db_port_table_scope_get(parms->ulp_ctx, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4113: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:848: + if (unlikely(ulp_port_db_port_vf_fid_get(parms->ulp_ctx, port_id, val))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4149: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:922: + if (unlikely(ulp_regfile_read(parms->regfile, idx, &lregval)) || WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4226: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:994: + if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4246: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1015: + if (unlikely(ulp_mapper_glb_field_tbl_get(parms, idx, &bit))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4291: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1061: + if (unlikely(ULP_BITMAP_ISSET(parms->hdr_bitmap->bits, lregval))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4308: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1075: + if (unlikely(ULP_BITMAP_ISSET(parms->act_bitmap->bits, lregval))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4326: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1090: + if (unlikely(ulp_mapper_glb_field_tbl_get(parms, idx, &bit))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4332: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1095: + if (unlikely(ULP_INDEX_BITMAP_GET(parms->fld_bitmap->bits, bit))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4367: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1124: + if (unlikely(ulp_mapper_field_port_db_process(parms, port_id, idx, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4432: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1197: + if (unlikely(ulp_mapper_cond_opc_list_process(parms, &info, &cond_res))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4449: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1216: + if (unlikely(ULP_BITMAP_ISSET(parms->cf_bitmap, lregval))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4617: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1656: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src1, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4630: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1681: + if (unlikely(ulp_mapper_key_recipe_field_opc_next(parms, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4646: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1704: + if (unlikely(ulp_mapper_key_recipe_field_opc_next(parms, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4664: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1781: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4762: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:1977: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src1, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4785: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2004: + if (unlikely(ulp_mapper_field_opc_next(parms, dir, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4800: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2021: + if (unlikely(ulp_mapper_field_opc_next(parms, dir, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4815: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2039: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src2, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4838: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2057: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src3, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4929: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2196: + parms->device_params->encap_byte_order))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #4994: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2308: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5034: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2353: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5064: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2394: + if (unlikely(ulp_mapper_ident_process(parms, tbl, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5151: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:2594: + parms->device_params->key_byte_order))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5534: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3206: + if (unlikely(ulp_regfile_read(parms->regfile, operand, ®val))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5543: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3220: + if (unlikely(bnxt_ulp_cntxt_mem_type_get(parms->ulp_ctx, &mtype))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5551: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3227: + if (unlikely(bnxt_ulp_cntxt_mem_type_get(parms->ulp_ctx, &mtype))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5629: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3353: + if (unlikely(ulp_regfile_read(parms->regfile, func_opr, ®val))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5639: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3361: + if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data, dir, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5670: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3453: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src1, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5699: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3477: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src2, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5729: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3504: + if (unlikely(ulp_mapper_field_src_process(parms, fld->field_src3, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5761: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3687: + if (unlikely(ulp_regfile_write(parms->regfile, func_info->func_dst_opr, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5809: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3927: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5822: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:3941: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5883: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4054: + if (unlikely(ulp_mapper_func_info_process(parms, tbl))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5933: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4165: + if (unlikely(ulp_regfile_read(parms->regfile, rf_idx, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5979: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4392: + if (unlikely(!ulp_ctx || !parms)) WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5988: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4401: + if (unlikely(bnxt_ulp_cntxt_dev_id_get(ulp_ctx, &parms->dev_id))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #5993: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4405: + if (unlikely(bnxt_ulp_cntxt_fid_get(ulp_ctx, &parms->fw_fid))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6001: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4412: + if (unlikely(!parms->device_params)) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6010: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4424: + if (unlikely(!parms->mapper_data)) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6017: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper.c:4430: + if (unlikely(ulp_regfile_init(parms->regfile))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6264: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:204: + if (unlikely(bnxt_ulp_cntxt_fid_get(parms->ulp_ctx, &fw_fid))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6372: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:321: + if (unlikely(ulp_regfile_write(parms->regfile, tbl->tbl_operand, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6530: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:775: + if (unlikely(bnxt_ulp_cntxt_fid_get(parms->ulp_ctx, &fw_fid))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6541: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:785: + parms->device_params->result_byte_order))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6562: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:830: + if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6575: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:850: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6605: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:898: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6707: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1098: + parms->device_params->result_byte_order))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6728: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1143: + if (unlikely(ulp_mapper_glb_resource_read(parms->mapper_data, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6741: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1163: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6751: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1184: + if (unlikely(ulp_regfile_read(parms->regfile, WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6876: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1441: + if (unlikely(bnxt_ulp_cntxt_fid_get(parms->ulp_ctx, &fw_fid))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6892: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1454: + parms->device_params->result_byte_order))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6909: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1472: + if (unlikely(ulp_regfile_read(parms->regfile, tbl->tbl_operand, &idx))) { WARNING:TYPO_SPELLING: 'parms' may be misspelled - perhaps 'params'? #6920: FILE: drivers/net/bnxt/tf_ulp/ulp_mapper_tfc.c:1485: + parms->device_params->result_byte_order))) { total: 0 errors, 74 warnings, 0 checks, 7687 lines checked