automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: David Marchand <david.marchand@redhat.com>
Subject: |WARNING| pw143785 [PATCH 11/11] drivers: use per line logging in helpers
Date: Sat,  7 Sep 2024 16:57:55 +0200 (CEST)	[thread overview]
Message-ID: <20240907145755.CC5A5121D10@dpdk.org> (raw)
In-Reply-To: <20240907145433.1479091-12-david.marchand@redhat.com>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/143785

_coding style issues_


WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#734: FILE: drivers/common/cnxk/roc_platform.h:279:
+#define RTE_LOGTYPE_tim cnxk_logtype_tim

WARNING:TYPO_SPELLING: 'tim' may be misspelled - perhaps 'time'?
#734: FILE: drivers/common/cnxk/roc_platform.h:279:
+#define RTE_LOGTYPE_tim cnxk_logtype_tim

ERROR:SPACING: space required after that ',' (ctx:VxB)
#855: FILE: drivers/common/idpf/idpf_common_logs.h:17:
+			RTE_FMT_HEAD(__VA_ARGS__,),		\
 			                        ^

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'sc' - possible side-effects?
#1943: FILE: drivers/net/bnx2x/bnx2x_logs.h:21:
+#define PMD_DRV_LOG(level, sc, fmt, args...) \
+	RTE_LOG_LINE(level, BNX2X_DRIVER, \
 		"[%s:%d(%s)] " fmt,	__func__, __LINE__, \
 		(sc)->devinfo.name ? (sc)->devinfo.name : "", ## args)

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2056: FILE: drivers/net/cpfl/cpfl_logs.h:18:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2066: FILE: drivers/net/cpfl/cpfl_logs.h:25:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

CHECK:CAMELCASE: Avoid CamelCase: <PRIx64>
#2132: FILE: drivers/net/dpaa2/dpaa2_rxtx.c:402:
+		"fd_off=%d fd =%" PRIx64 ", meta = %d  bpid =%d, len=%d",

CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements
#2537: FILE: drivers/net/hinic/base/hinic_compat.h:91:
+		HINIC_DRIVER_NAME": " fmt, ##args)

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2767: FILE: drivers/net/idpf/idpf_logs.h:18:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2778: FILE: drivers/net/idpf/idpf_logs.h:25:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2953: FILE: drivers/net/mlx4/mlx4_utils.h:51:
+		RTE_FMT("%s:%u: %s(): " RTE_FMT_HEAD(__VA_ARGS__,), \
 		                                                ^

ERROR:SPACING: space required after that ',' (ctx:VxB)
#2965: FILE: drivers/net/mlx4/mlx4_utils.h:69:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

CHECK:CAMELCASE: Avoid CamelCase: <PRIu64>
#3375: FILE: drivers/net/octeon_ep/otx_ep_rxtx.c:921:
+				    "last_pkt_count %" PRIu64 "new_pkts %d.",

ERROR:SPACING: space required after that ',' (ctx:VxB)
#3628: FILE: drivers/net/vdev_netvsc/vdev_netvsc.c:57:
+			RTE_FMT_HEAD(__VA_ARGS__,), \
 			                        ^

total: 8 errors, 2 warnings, 2942 lines checked

  parent reply	other threads:[~2024-09-07 14:57 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20240907145433.1479091-12-david.marchand@redhat.com>
2024-09-07 14:30 ` |SUCCESS| pw143775-143785 " qemudev
2024-09-07 14:35 ` qemudev
2024-09-07 14:57 ` checkpatch [this message]
2024-09-07 15:44 ` |SUCCESS| pw143785 " 0-day Robot
2024-09-09 21:51 ` |SUCCESS| pw143775-143785 [PATCH] [11/11] drivers: use per line logg dpdklab
2024-09-09 22:12 ` dpdklab
2024-09-09 22:33 ` dpdklab
2024-09-09 22:50 ` |PENDING| " dpdklab
2024-09-09 22:50 ` dpdklab
2024-09-09 23:02 ` |SUCCESS| " dpdklab
2024-09-09 23:03 ` dpdklab
2024-09-09 23:32 ` |PENDING| " dpdklab
2024-09-10  0:33 ` |FAILURE| " dpdklab
2024-09-10  0:37 ` dpdklab
2024-09-10  1:11 ` |WARNING| " dpdklab
2024-09-10  2:01 ` |PENDING| " dpdklab
2024-09-10  3:31 ` |FAILURE| " dpdklab
2024-09-10  3:57 ` |SUCCESS| " dpdklab
2024-09-10  4:32 ` |WARNING| " dpdklab
2024-09-10  5:25 ` |SUCCESS| " dpdklab
2024-09-10  5:30 ` dpdklab
2024-09-10  5:35 ` dpdklab
2024-09-10  5:48 ` |FAILURE| " dpdklab
2024-09-10  5:55 ` dpdklab
2024-09-10  6:02 ` |SUCCESS| " dpdklab
2024-09-10 13:44 ` dpdklab
2024-09-16  7:39 ` dpdklab
2024-09-16 15:31 ` |FAILURE| " dpdklab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240907145755.CC5A5121D10@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=david.marchand@redhat.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).