automatic DPDK test reports
 help / color / mirror / Atom feed
* |WARNING| pw146133 [PATCH v2 11/18] net/r8169: implement Rx path
       [not found] <20241017063200.26101-12-howard_wang@realsil.com.cn>
@ 2024-10-17  6:34 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-10-17  6:34 UTC (permalink / raw)
  To: test-report; +Cc: Howard Wang

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146133

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <Jumbo_Frame_9k>
#107: FILE: drivers/net/r8169/r8169_base.h:588:
+#define Jumbo_Frame_9k  (9 * 1024 - ETH_HLEN - VLAN_HLEN - RTE_ETHER_CRC_LEN)

CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#109: FILE: drivers/net/r8169/r8169_base.h:590:
+#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL << (n)) - 1))

ERROR:CODE_INDENT: code indent should use tabs where possible
#123: FILE: drivers/net/r8169/r8169_ethdev.c:42:
+                             struct rte_eth_dev_info *dev_info);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#123: FILE: drivers/net/r8169/r8169_ethdev.c:42:
+                             struct rte_eth_dev_info *dev_info);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#216: FILE: drivers/net/r8169/r8169_ethdev.c:351:
+^I                       RTE_ETH_LINK_SPEED_100M_HD | RTE_ETH_LINK_SPEED_100M |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#217: FILE: drivers/net/r8169/r8169_ethdev.c:352:
+^I                       RTE_ETH_LINK_SPEED_1G;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#230: FILE: drivers/net/r8169/r8169_ethdev.c:365:
+^I                             dev_info->rx_queue_offload_capa);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#277: FILE: drivers/net/r8169/r8169_ethdev.h:114:
+                                 uint16_t nb_pkts);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#277: FILE: drivers/net/r8169/r8169_ethdev.h:114:
+                                 uint16_t nb_pkts);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#282: FILE: drivers/net/r8169/r8169_ethdev.h:119:
+                      struct rte_eth_rxq_info *qinfo);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#282: FILE: drivers/net/r8169/r8169_ethdev.h:119:
+                      struct rte_eth_rxq_info *qinfo);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#287: FILE: drivers/net/r8169/r8169_ethdev.h:124:
+                       uint16_t nb_rx_desc, unsigned int socket_id,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#287: FILE: drivers/net/r8169/r8169_ethdev.h:124:
+                       uint16_t nb_rx_desc, unsigned int socket_id,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#288: FILE: drivers/net/r8169/r8169_ethdev.h:125:
+                       const struct rte_eth_rxconf *rx_conf,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#288: FILE: drivers/net/r8169/r8169_ethdev.h:125:
+                       const struct rte_eth_rxconf *rx_conf,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#289: FILE: drivers/net/r8169/r8169_ethdev.h:126:
+                       struct rte_mempool *mb_pool);$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#289: FILE: drivers/net/r8169/r8169_ethdev.h:126:
+                       struct rte_mempool *mb_pool);$

CHECK:CAMELCASE: Avoid CamelCase: <_DescStatusBit>
#334: FILE: drivers/net/r8169/r8169_rxtx.c:62:
+enum _DescStatusBit {

CHECK:CAMELCASE: Avoid CamelCase: <DescOwn>
#335: FILE: drivers/net/r8169/r8169_rxtx.c:63:
+	DescOwn     = (1 << 31), /* Descriptor is owned by NIC. */

CHECK:CAMELCASE: Avoid CamelCase: <RingEnd>
#336: FILE: drivers/net/r8169/r8169_rxtx.c:64:
+	RingEnd     = (1 << 30), /* End of descriptor ring */

CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag>
#337: FILE: drivers/net/r8169/r8169_rxtx.c:65:
+	FirstFrag   = (1 << 29), /* First segment of a packet */

CHECK:CAMELCASE: Avoid CamelCase: <LastFrag>
#338: FILE: drivers/net/r8169/r8169_rxtx.c:66:
+	LastFrag    = (1 << 28), /* Final segment of a packet */

CHECK:CAMELCASE: Avoid CamelCase: <DescOwn_V3>
#340: FILE: drivers/net/r8169/r8169_rxtx.c:68:
+	DescOwn_V3  = DescOwn, /* Descriptor is owned by NIC. */

CHECK:CAMELCASE: Avoid CamelCase: <RingEnd_V3>
#341: FILE: drivers/net/r8169/r8169_rxtx.c:69:
+	RingEnd_V3  = RingEnd, /* End of descriptor ring */

CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag_V3>
#342: FILE: drivers/net/r8169/r8169_rxtx.c:70:
+	FirstFrag_V3 = (1 << 25), /* First segment of a packet */

CHECK:CAMELCASE: Avoid CamelCase: <LastFrag_V3>
#343: FILE: drivers/net/r8169/r8169_rxtx.c:71:
+	LastFrag_V3 = (1 << 24), /* Final segment of a packet */

CHECK:CAMELCASE: Avoid CamelCase: <LargeSend>
#347: FILE: drivers/net/r8169/r8169_rxtx.c:75:
+	LargeSend   = (1 << 27), /* TCP Large Send Offload (TSO) */

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv4>
#348: FILE: drivers/net/r8169/r8169_rxtx.c:76:
+	GiantSendv4 = (1 << 26), /* TCP Giant Send Offload V4 (GSOv4) */

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv6>
#349: FILE: drivers/net/r8169/r8169_rxtx.c:77:
+	GiantSendv6 = (1 << 25), /* TCP Giant Send Offload V6 (GSOv6) */

CHECK:CAMELCASE: Avoid CamelCase: <LargeSend_DP>
#350: FILE: drivers/net/r8169/r8169_rxtx.c:78:
+	LargeSend_DP = (1 << 16), /* TCP Large Send Offload (TSO) */

CHECK:CAMELCASE: Avoid CamelCase: <MSSShift>
#351: FILE: drivers/net/r8169/r8169_rxtx.c:79:
+	MSSShift    = 16,        /* MSS value position */

CHECK:CAMELCASE: Avoid CamelCase: <MSSMask>
#352: FILE: drivers/net/r8169/r8169_rxtx.c:80:
+	MSSMask     = 0x7FFU,    /* MSS value 11 bits */

CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS>
#353: FILE: drivers/net/r8169/r8169_rxtx.c:81:
+	TxIPCS      = (1 << 18), /* Calculate IP checksum */

CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS>
#354: FILE: drivers/net/r8169/r8169_rxtx.c:82:
+	TxUDPCS     = (1 << 17), /* Calculate UDP/IP checksum */

CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS>
#355: FILE: drivers/net/r8169/r8169_rxtx.c:83:
+	TxTCPCS     = (1 << 16), /* Calculate TCP/IP checksum */

CHECK:CAMELCASE: Avoid CamelCase: <TxVlanTag>
#356: FILE: drivers/net/r8169/r8169_rxtx.c:84:
+	TxVlanTag   = (1 << 17), /* Add VLAN tag */

CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS_C>
#359: FILE: drivers/net/r8169/r8169_rxtx.c:87:
+	TxUDPCS_C   = (1 << 31), /* Calculate UDP/IP checksum */

CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS_C>
#360: FILE: drivers/net/r8169/r8169_rxtx.c:88:
+	TxTCPCS_C   = (1 << 30), /* Calculate TCP/IP checksum */

CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS_C>
#361: FILE: drivers/net/r8169/r8169_rxtx.c:89:
+	TxIPCS_C    = (1 << 29), /* Calculate IP checksum */

CHECK:CAMELCASE: Avoid CamelCase: <TxIPV6F_C>
#362: FILE: drivers/net/r8169/r8169_rxtx.c:90:
+	TxIPV6F_C   = (1 << 28), /* Indicate it is an IPv6 packet */

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoUDP>
#370: FILE: drivers/net/r8169/r8169_rxtx.c:98:
+#define RxProtoUDP  PID1

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoTCP>
#371: FILE: drivers/net/r8169/r8169_rxtx.c:99:
+#define RxProtoTCP  PID0

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoIP>
#372: FILE: drivers/net/r8169/r8169_rxtx.c:100:
+#define RxProtoIP   (PID1 | PID0)

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoMask>
#373: FILE: drivers/net/r8169/r8169_rxtx.c:101:
+#define RxProtoMask RxProtoIP

CHECK:CAMELCASE: Avoid CamelCase: <RxIPF>
#375: FILE: drivers/net/r8169/r8169_rxtx.c:103:
+	RxIPF       = (1 << 16), /* IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxUDPF>
#376: FILE: drivers/net/r8169/r8169_rxtx.c:104:
+	RxUDPF      = (1 << 15), /* UDP/IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxTCPF>
#377: FILE: drivers/net/r8169/r8169_rxtx.c:105:
+	RxTCPF      = (1 << 14), /* TCP/IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxVlanTag>
#378: FILE: drivers/net/r8169/r8169_rxtx.c:106:
+	RxVlanTag   = (1 << 16), /* VLAN tag available */

CHECK:CAMELCASE: Avoid CamelCase: <RxUDPT>
#381: FILE: drivers/net/r8169/r8169_rxtx.c:109:
+	RxUDPT      = (1 << 18),

CHECK:CAMELCASE: Avoid CamelCase: <RxTCPT>
#382: FILE: drivers/net/r8169/r8169_rxtx.c:110:
+	RxTCPT      = (1 << 17),

CHECK:CAMELCASE: Avoid CamelCase: <RxV6F>
#386: FILE: drivers/net/r8169/r8169_rxtx.c:114:
+	RxV6F       = (1 << 31),

CHECK:CAMELCASE: Avoid CamelCase: <RxV4F>
#387: FILE: drivers/net/r8169/r8169_rxtx.c:115:
+	RxV4F       = (1 << 30),

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoUDP_v3>
#393: FILE: drivers/net/r8169/r8169_rxtx.c:121:
+#define RxProtoUDP_v3  PID1_v3

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoTCP_v3>
#394: FILE: drivers/net/r8169/r8169_rxtx.c:122:
+#define RxProtoTCP_v3  PID0_v3

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoIP_v3>
#395: FILE: drivers/net/r8169/r8169_rxtx.c:123:
+#define RxProtoIP_v3   (PID1_v3 | PID0_v3)

CHECK:CAMELCASE: Avoid CamelCase: <RxProtoMask_v3>
#396: FILE: drivers/net/r8169/r8169_rxtx.c:124:
+#define RxProtoMask_v3 RxProtoIP_v3

CHECK:CAMELCASE: Avoid CamelCase: <RxIPF_v3>
#398: FILE: drivers/net/r8169/r8169_rxtx.c:126:
+	RxIPF_v3       = (1 << 26), /* IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxUDPF_v3>
#399: FILE: drivers/net/r8169/r8169_rxtx.c:127:
+	RxUDPF_v3      = (1 << 25), /* UDP/IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxTCPF_v3>
#400: FILE: drivers/net/r8169/r8169_rxtx.c:128:
+	RxTCPF_v3      = (1 << 24), /* TCP/IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxSCTPF_v3>
#401: FILE: drivers/net/r8169/r8169_rxtx.c:129:
+	RxSCTPF_v3     = (1 << 23), /* TCP/IP checksum failed */

CHECK:CAMELCASE: Avoid CamelCase: <RxVlanTag_v3>
#402: FILE: drivers/net/r8169/r8169_rxtx.c:130:
+	RxVlanTag_v3   = (RxVlanTag), /* VLAN tag available */

CHECK:CAMELCASE: Avoid CamelCase: <RxUDPT_v3>
#405: FILE: drivers/net/r8169/r8169_rxtx.c:133:
+	RxUDPT_v3      = (1 << 29),

CHECK:CAMELCASE: Avoid CamelCase: <RxTCPT_v3>
#406: FILE: drivers/net/r8169/r8169_rxtx.c:134:
+	RxTCPT_v3      = (1 << 28),

CHECK:CAMELCASE: Avoid CamelCase: <RxSCTP_v3>
#407: FILE: drivers/net/r8169/r8169_rxtx.c:135:
+	RxSCTP_v3      = (1 << 27),

CHECK:CAMELCASE: Avoid CamelCase: <RxV6F_v3>
#411: FILE: drivers/net/r8169/r8169_rxtx.c:139:
+	RxV6F_v3       = RxV6F,

CHECK:CAMELCASE: Avoid CamelCase: <RxV4F_v3>
#412: FILE: drivers/net/r8169/r8169_rxtx.c:140:
+	RxV4F_v3       = RxV4F,

ERROR:CODE_INDENT: code indent should use tabs where possible
#452: FILE: drivers/net/r8169/r8169_rxtx.c:180:
+                 struct rte_eth_rxq_info *qinfo)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#452: FILE: drivers/net/r8169/r8169_rxtx.c:180:
+                 struct rte_eth_rxq_info *qinfo)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#487: FILE: drivers/net/r8169/r8169_rxtx.c:215:
+^I           RTE_ETH_RX_OFFLOAD_UDP_CKSUM   |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#488: FILE: drivers/net/r8169/r8169_rxtx.c:216:
+^I           RTE_ETH_RX_OFFLOAD_TCP_CKSUM   |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#489: FILE: drivers/net/r8169/r8169_rxtx.c:217:
+^I           RTE_ETH_RX_OFFLOAD_SCATTER     |$

ERROR:CODE_INDENT: code indent should use tabs where possible
#490: FILE: drivers/net/r8169/r8169_rxtx.c:218:
+^I           RTE_ETH_RX_OFFLOAD_VLAN_STRIP;$

ERROR:CODE_INDENT: code indent should use tabs where possible
#497: FILE: drivers/net/r8169/r8169_rxtx.c:225:
+                   uint16_t nb_rx_desc, unsigned int socket_id,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#497: FILE: drivers/net/r8169/r8169_rxtx.c:225:
+                   uint16_t nb_rx_desc, unsigned int socket_id,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#498: FILE: drivers/net/r8169/r8169_rxtx.c:226:
+                   const struct rte_eth_rxconf *rx_conf,$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#498: FILE: drivers/net/r8169/r8169_rxtx.c:226:
+                   const struct rte_eth_rxconf *rx_conf,$

ERROR:CODE_INDENT: code indent should use tabs where possible
#499: FILE: drivers/net/r8169/r8169_rxtx.c:227:
+                   struct rte_mempool *mb_pool)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#499: FILE: drivers/net/r8169/r8169_rxtx.c:227:
+                   struct rte_mempool *mb_pool)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#521: FILE: drivers/net/r8169/r8169_rxtx.c:249:
+^I                         RTE_CACHE_LINE_SIZE, socket_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#537: FILE: drivers/net/r8169/r8169_rxtx.c:265:
+^I                          sizeof(struct rtl_rx_entry), RTE_CACHE_LINE_SIZE);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#541: FILE: drivers/net/r8169/r8169_rxtx.c:269:
+^I^I             "Port %d: Cannot allocate software ring for queue %d",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#542: FILE: drivers/net/r8169/r8169_rxtx.c:270:
+^I^I             rxq->port_id, rxq->queue_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#554: FILE: drivers/net/r8169/r8169_rxtx.c:282:
+^I                              RTL_RING_ALIGN, socket_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#557: FILE: drivers/net/r8169/r8169_rxtx.c:285:
+^I^I             "Port %d: Cannot allocate software ring for queue %d",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#558: FILE: drivers/net/r8169/r8169_rxtx.c:286:
+^I^I             rxq->port_id, rxq->queue_id);$

ERROR:CODE_INDENT: code indent should use tabs where possible
#592: FILE: drivers/net/r8169/r8169_rxtx.c:320:
+^I^I^I             "queue_id=%hu", rxq->queue_id);$

CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#618: FILE: drivers/net/r8169/r8169_rxtx.c:346:
+	rx_config = RTL_R32(hw, RxConfig);

CHECK:CAMELCASE: Avoid CamelCase: <EnableInnerVlan>
#620: FILE: drivers/net/r8169/r8169_rxtx.c:348:
+		rx_config |= (EnableInnerVlan | EnableOuterVlan);

CHECK:CAMELCASE: Avoid CamelCase: <EnableOuterVlan>
#620: FILE: drivers/net/r8169/r8169_rxtx.c:348:
+		rx_config |= (EnableInnerVlan | EnableOuterVlan);

CHECK:CAMELCASE: Avoid CamelCase: <CPlusCmd>
#626: FILE: drivers/net/r8169/r8169_rxtx.c:354:
+	cp_cmd = RTL_R16(hw, CPlusCmd);

CHECK:CAMELCASE: Avoid CamelCase: <RxChkSum>
#629: FILE: drivers/net/r8169/r8169_rxtx.c:357:
+		cp_cmd |= RxChkSum;

CHECK:CAMELCASE: Avoid CamelCase: <AcceptBroadcast>
#645: FILE: drivers/net/r8169/r8169_rxtx.c:373:
+	rx_mode = AcceptBroadcast | AcceptMyPhys;

CHECK:CAMELCASE: Avoid CamelCase: <AcceptMyPhys>
#645: FILE: drivers/net/r8169/r8169_rxtx.c:373:
+	rx_mode = AcceptBroadcast | AcceptMyPhys;

CHECK:CAMELCASE: Avoid CamelCase: <RxDescAddrLow>
#665: FILE: drivers/net/r8169/r8169_rxtx.c:393:
+	RTL_W32(hw, RxDescAddrLow, ((u64)rxq->hw_ring_phys_addr & DMA_BIT_MASK(32)));

CHECK:CAMELCASE: Avoid CamelCase: <RxDescAddrHigh>
#666: FILE: drivers/net/r8169/r8169_rxtx.c:394:
+	RTL_W32(hw, RxDescAddrHigh, ((u64)rxq->hw_ring_phys_addr >> 32));

CHECK:CAMELCASE: Avoid CamelCase: <RxMaxSize>
#681: FILE: drivers/net/r8169/r8169_rxtx.c:409:
+	RTL_W16(hw, RxMaxSize, max_rx_pkt_size);

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#701: FILE: drivers/net/r8169/r8169_rxtx.c:429:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#701: FILE: drivers/net/r8169/r8169_rxtx.c:429:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb);

ERROR:CODE_INDENT: code indent should use tabs where possible
#718: FILE: drivers/net/r8169/r8169_rxtx.c:446:
+                               uint32_t opts2)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#718: FILE: drivers/net/r8169/r8169_rxtx.c:446:
+                               uint32_t opts2)$

CHECK:CAMELCASE: Avoid CamelCase: <RxRES>
#781: FILE: drivers/net/r8169/r8169_rxtx.c:507:
+		if (unlikely(opts1 & RxRES)) {

ERROR:CODE_INDENT: code indent should use tabs where possible
#792: FILE: drivers/net/r8169/r8169_rxtx.c:518:
+^I^I^I^I           "queue_id=%u",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#793: FILE: drivers/net/r8169/r8169_rxtx.c:519:
+^I^I^I^I           (uint32_t)rxq->port_id, (uint32_t)rxq->queue_id);$

CHECK:CAMELCASE: Avoid CamelCase: <RxOK>
#862: FILE: drivers/net/r8169/r8169_rxtx.c:588:
+		RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail));

CHECK:CAMELCASE: Avoid CamelCase: <RxErr>
#862: FILE: drivers/net/r8169/r8169_rxtx.c:588:
+		RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail));

CHECK:CAMELCASE: Avoid CamelCase: <RxDescUnavail>
#862: FILE: drivers/net/r8169/r8169_rxtx.c:588:
+		RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail));

ERROR:CODE_INDENT: code indent should use tabs where possible
#875: FILE: drivers/net/r8169/r8169_rxtx.c:601:
+                        uint16_t nb_pkts)$

WARNING:LEADING_SPACE: please, no spaces at the start of a line
#875: FILE: drivers/net/r8169/r8169_rxtx.c:601:
+                        uint16_t nb_pkts)$

ERROR:CODE_INDENT: code indent should use tabs where possible
#935: FILE: drivers/net/r8169/r8169_rxtx.c:661:
+^I^I^I^I           "queue_id=%u",$

ERROR:CODE_INDENT: code indent should use tabs where possible
#936: FILE: drivers/net/r8169/r8169_rxtx.c:662:
+^I^I^I^I           (uint32_t)rxq->port_id, (uint32_t)rxq->queue_id);$

CHECK:BRACES: braces {} should be used on all arms of this statement
#1008: FILE: drivers/net/r8169/r8169_rxtx.c:734:
+			if (data_len <= RTE_ETHER_CRC_LEN) {
[...]
+			} else
[...]

WARNING:LONG_LINE: line length of 105 exceeds 100 columns
#1011: FILE: drivers/net/r8169/r8169_rxtx.c:737:
+				last_seg->data_len = last_seg->data_len - (RTE_ETHER_CRC_LEN - data_len);

CHECK:BRACES: Unbalanced braces around else statement
#1013: FILE: drivers/net/r8169/r8169_rxtx.c:739:
+			} else

total: 31 errors, 13 warnings, 69 checks, 993 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-10-17  6:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20241017063200.26101-12-howard_wang@realsil.com.cn>
2024-10-17  6:34 ` |WARNING| pw146133 [PATCH v2 11/18] net/r8169: implement Rx path checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).