* |WARNING| pw146132 [PATCH v2 10/18] net/r8169: add link status and interrupt management
[not found] <20241017063200.26101-11-howard_wang@realsil.com.cn>
@ 2024-10-17 6:34 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-10-17 6:34 UTC (permalink / raw)
To: test-report; +Cc: Howard Wang
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146132
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:CAMELCASE: Avoid CamelCase: <LinkChg>
#141: FILE: drivers/net/r8169/r8169_ethdev.c:83:
+ RTL_W32(hw, IMR0_8125, LinkChg);
CHECK:BRACES: braces {} should be used on all arms of this statement
#153: FILE: drivers/net/r8169/r8169_ethdev.c:95:
+ if (*link_speeds == RTE_ETH_LINK_SPEED_AUTONEG)
[...]
+ else if (*link_speeds != 0) {
[...]
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#156: FILE: drivers/net/r8169/r8169_ethdev.c:98:
+ else if (*link_speeds != 0) {
+
ERROR:CODE_INDENT: code indent should use tabs where possible
#158: FILE: drivers/net/r8169/r8169_ethdev.c:100:
+^I^I RTE_ETH_LINK_SPEED_100M_HD | RTE_ETH_LINK_SPEED_100M |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#159: FILE: drivers/net/r8169/r8169_ethdev.c:101:
+^I^I RTE_ETH_LINK_SPEED_1G | RTE_ETH_LINK_SPEED_2_5G |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#160: FILE: drivers/net/r8169/r8169_ethdev.c:102:
+^I^I RTE_ETH_LINK_SPEED_5G | RTE_ETH_LINK_SPEED_FIXED))$
ERROR:CODE_INDENT: code indent should use tabs where possible
#209: FILE: drivers/net/r8169/r8169_ethdev.c:151:
+^I dev->data->dev_conf.link_speeds, dev->data->port_id);$
CHECK:CAMELCASE: Avoid CamelCase: <PHYstatus>
#227: FILE: drivers/net/r8169/r8169_ethdev.c:169:
+ if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {
CHECK:CAMELCASE: Avoid CamelCase: <LinkStatus>
#227: FILE: drivers/net/r8169/r8169_ethdev.c:169:
+ if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {
CHECK:CAMELCASE: Avoid CamelCase: <FullDup>
#358: FILE: drivers/net/r8169/r8169_ethdev.c:327:
+ if (status & FullDup) {
CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#361: FILE: drivers/net/r8169/r8169_ethdev.c:330:
+ RTL_W32(hw, TxConfig, (RTL_R32(hw, TxConfig) |
ERROR:CODE_INDENT: code indent should use tabs where possible
#362: FILE: drivers/net/r8169/r8169_ethdev.c:331:
+^I^I^I^I (BIT_24 | BIT_25)) & ~BIT_19);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#368: FILE: drivers/net/r8169/r8169_ethdev.c:337:
+^I^I^I^I ~(BIT_19 | BIT_24));$
ERROR:CODE_INDENT: code indent should use tabs where possible
#439: FILE: drivers/net/r8169/r8169_ethdev.c:409:
+^I^I dev);$
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#512: FILE: drivers/net/r8169/r8169_hw.c:1093:
+ hw->HwSuppMaxPhyLinkSpeed = SPEED_2500;
ERROR:CODE_INDENT: code indent should use tabs where possible
#533: FILE: drivers/net/r8169/r8169_hw.h:55:
+ enum rtl_fc_mode fc);$
WARNING:LEADING_SPACE: please, no spaces at the start of a line
#533: FILE: drivers/net/r8169/r8169_hw.h:55:
+ enum rtl_fc_mode fc);$
WARNING:TYPO_SPELLING: 'lite' may be misspelled - perhaps 'light'?
#587: FILE: drivers/net/r8169/r8169_phy.c:819:
+ /* Disable giga lite */
ERROR:CODE_INDENT: code indent should use tabs where possible
#609: FILE: drivers/net/r8169/r8169_phy.c:841:
+^I^I ADVERTISE_100HALF | ADVERTISE_100FULL |$
ERROR:CODE_INDENT: code indent should use tabs where possible
#610: FILE: drivers/net/r8169/r8169_phy.c:842:
+^I^I ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM);$
ERROR:CODE_INDENT: code indent should use tabs where possible
#662: FILE: drivers/net/r8169/r8169_phy.c:894:
+^I hw->advertising);$
total: 11 errors, 3 warnings, 8 checks, 556 lines checked
^ permalink raw reply [flat|nested] only message in thread