From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 962D745B5A for ; Thu, 17 Oct 2024 08:38:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FC8E40264; Thu, 17 Oct 2024 08:38:49 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 4662C40261 for ; Thu, 17 Oct 2024 08:38:48 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 3E15B121E31; Thu, 17 Oct 2024 08:38:48 +0200 (CEST) Subject: |WARNING| pw146134 [PATCH v2 12/18] net/r8169: implement Tx path In-Reply-To: <20241017063200.26101-13-howard_wang@realsil.com.cn> References: <20241017063200.26101-13-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241017063848.3E15B121E31@dpdk.org> Date: Thu, 17 Oct 2024 08:38:48 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/146134 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #108: FILE: drivers/net/r8169/r8169_ethdev.h:80: + u32 NextHwDesCloPtr0; CHECK:CAMELCASE: Avoid CamelCase: #109: FILE: drivers/net/r8169/r8169_ethdev.h:81: + u32 BeginHwDesCloPtr0; ERROR:CODE_INDENT: code indent should use tabs where possible #122: FILE: drivers/net/r8169/r8169_ethdev.h:124: + struct rte_eth_txq_info *qinfo);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #122: FILE: drivers/net/r8169/r8169_ethdev.h:124: + struct rte_eth_txq_info *qinfo);$ ERROR:CODE_INDENT: code indent should use tabs where possible #132: FILE: drivers/net/r8169/r8169_ethdev.h:134: + uint16_t nb_tx_desc, unsigned int socket_id,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #132: FILE: drivers/net/r8169/r8169_ethdev.h:134: + uint16_t nb_tx_desc, unsigned int socket_id,$ ERROR:CODE_INDENT: code indent should use tabs where possible #133: FILE: drivers/net/r8169/r8169_ethdev.h:135: + const struct rte_eth_txconf *tx_conf);$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #133: FILE: drivers/net/r8169/r8169_ethdev.h:135: + const struct rte_eth_txconf *tx_conf);$ ERROR:CODE_INDENT: code indent should use tabs where possible #155: FILE: drivers/net/r8169/r8169_rxtx.c:35: +^I^I RTE_MBUF_F_TX_IPV4 |^I^I\$ ERROR:CODE_INDENT: code indent should use tabs where possible #156: FILE: drivers/net/r8169/r8169_rxtx.c:36: +^I^I RTE_MBUF_F_TX_VLAN |^I^I\$ ERROR:CODE_INDENT: code indent should use tabs where possible #157: FILE: drivers/net/r8169/r8169_rxtx.c:37: +^I^I RTE_MBUF_F_TX_IP_CKSUM |^I \$ ERROR:CODE_INDENT: code indent should use tabs where possible #158: FILE: drivers/net/r8169/r8169_rxtx.c:38: +^I^I RTE_MBUF_F_TX_L4_MASK |^I^I\$ ERROR:CODE_INDENT: code indent should use tabs where possible #159: FILE: drivers/net/r8169/r8169_rxtx.c:39: +^I^I RTE_MBUF_F_TX_TCP_SEG)$ ERROR:CODE_INDENT: code indent should use tabs where possible #295: FILE: drivers/net/r8169/r8169_rxtx.c:881: + struct rte_eth_txq_info *qinfo)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #295: FILE: drivers/net/r8169/r8169_rxtx.c:881: + struct rte_eth_txq_info *qinfo)$ CHECK:CAMELCASE: Avoid CamelCase: #313: FILE: drivers/net/r8169/r8169_rxtx.c:899: + txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd); ERROR:CODE_INDENT: code indent should use tabs where possible #326: FILE: drivers/net/r8169/r8169_rxtx.c:912: +^I RTE_ETH_TX_OFFLOAD_IPV4_CKSUM |$ ERROR:CODE_INDENT: code indent should use tabs where possible #327: FILE: drivers/net/r8169/r8169_rxtx.c:913: +^I RTE_ETH_TX_OFFLOAD_UDP_CKSUM |$ ERROR:CODE_INDENT: code indent should use tabs where possible #328: FILE: drivers/net/r8169/r8169_rxtx.c:914: +^I RTE_ETH_TX_OFFLOAD_TCP_CKSUM |$ ERROR:CODE_INDENT: code indent should use tabs where possible #329: FILE: drivers/net/r8169/r8169_rxtx.c:915: +^I RTE_ETH_TX_OFFLOAD_TCP_TSO |$ ERROR:CODE_INDENT: code indent should use tabs where possible #330: FILE: drivers/net/r8169/r8169_rxtx.c:916: +^I RTE_ETH_TX_OFFLOAD_MULTI_SEGS;$ ERROR:CODE_INDENT: code indent should use tabs where possible #337: FILE: drivers/net/r8169/r8169_rxtx.c:923: + uint16_t nb_tx_desc, unsigned int socket_id,$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #337: FILE: drivers/net/r8169/r8169_rxtx.c:923: + uint16_t nb_tx_desc, unsigned int socket_id,$ ERROR:CODE_INDENT: code indent should use tabs where possible #338: FILE: drivers/net/r8169/r8169_rxtx.c:924: + const struct rte_eth_txconf *tx_conf)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #338: FILE: drivers/net/r8169/r8169_rxtx.c:924: + const struct rte_eth_txconf *tx_conf)$ ERROR:CODE_INDENT: code indent should use tabs where possible #359: FILE: drivers/net/r8169/r8169_rxtx.c:945: +^I sizeof(struct rtl_tx_queue),$ ERROR:CODE_INDENT: code indent should use tabs where possible #360: FILE: drivers/net/r8169/r8169_rxtx.c:946: +^I RTE_CACHE_LINE_SIZE, socket_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #375: FILE: drivers/net/r8169/r8169_rxtx.c:961: +^I sizeof(struct rtl_tx_entry), RTE_CACHE_LINE_SIZE);$ ERROR:CODE_INDENT: code indent should use tabs where possible #379: FILE: drivers/net/r8169/r8169_rxtx.c:965: +^I^I "Port %d: Cannot allocate software ring for queue %d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #380: FILE: drivers/net/r8169/r8169_rxtx.c:966: +^I^I txq->port_id, txq->queue_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #392: FILE: drivers/net/r8169/r8169_rxtx.c:978: +^I RTL_RING_ALIGN, socket_id);$ ERROR:CODE_INDENT: code indent should use tabs where possible #395: FILE: drivers/net/r8169/r8169_rxtx.c:981: +^I^I "Port %d: Cannot allocate hardware ring for queue %d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #396: FILE: drivers/net/r8169/r8169_rxtx.c:982: +^I^I txq->port_id, txq->queue_id);$ CHECK:CAMELCASE: Avoid CamelCase: #425: FILE: drivers/net/r8169/r8169_rxtx.c:1011: + RTL_W32(hw, TxDescStartAddrLow, ERROR:CODE_INDENT: code indent should use tabs where possible #426: FILE: drivers/net/r8169/r8169_rxtx.c:1012: +^I ((u64)txq->hw_ring_phys_addr & DMA_BIT_MASK(32)));$ CHECK:CAMELCASE: Avoid CamelCase: #427: FILE: drivers/net/r8169/r8169_rxtx.c:1013: + RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32)); CHECK:CAMELCASE: Avoid CamelCase: #441: FILE: drivers/net/r8169/r8169_rxtx.c:1027: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb); CHECK:CAMELCASE: Avoid CamelCase: #441: FILE: drivers/net/r8169/r8169_rxtx.c:1027: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb); CHECK:CAMELCASE: Avoid CamelCase: #454: FILE: drivers/net/r8169/r8169_rxtx.c:1038: + (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) : CHECK:CAMELCASE: Avoid CamelCase: #471: FILE: drivers/net/r8169/r8169_rxtx.c:1055: + opts[0] |= GiantSendv4; CHECK:CAMELCASE: Avoid CamelCase: #473: FILE: drivers/net/r8169/r8169_rxtx.c:1057: + opts[0] |= GiantSendv6; ERROR:CODE_INDENT: code indent should use tabs where possible #487: FILE: drivers/net/r8169/r8169_rxtx.c:1071: + uint32_t *opts)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #487: FILE: drivers/net/r8169/r8169_rxtx.c:1071: + uint32_t *opts)$ CHECK:CAMELCASE: Avoid CamelCase: #493: FILE: drivers/net/r8169/r8169_rxtx.c:1077: + csum_cmd |= TxIPCS_C; CHECK:CAMELCASE: Avoid CamelCase: #497: FILE: drivers/net/r8169/r8169_rxtx.c:1081: + csum_cmd |= TxUDPCS_C; CHECK:CAMELCASE: Avoid CamelCase: #500: FILE: drivers/net/r8169/r8169_rxtx.c:1084: + csum_cmd |= TxTCPCS_C; CHECK:BRACES: braces {} should be used on all arms of this statement #505: FILE: drivers/net/r8169/r8169_rxtx.c:1089: + if (ol_flags & RTE_MBUF_F_TX_IPV6) { [...] + } else [...] CHECK:CAMELCASE: Avoid CamelCase: #507: FILE: drivers/net/r8169/r8169_rxtx.c:1091: + csum_cmd |= TxIPV6F_C; CHECK:BRACES: Unbalanced braces around else statement #509: FILE: drivers/net/r8169/r8169_rxtx.c:1093: + } else CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->data_len < 175' #523: FILE: drivers/net/r8169/r8169_rxtx.c:1107: + if (!(tx_pkt->l4_len && (tx_pkt->data_len < 175))) ERROR:CODE_INDENT: code indent should use tabs where possible #531: FILE: drivers/net/r8169/r8169_rxtx.c:1115: +^I^I struct rte_ether_hdr *) + l4_offset + 2, 2);$ ERROR:CODE_INDENT: code indent should use tabs where possible #572: FILE: drivers/net/r8169/r8169_rxtx.c:1156: + struct rte_mbuf *tx_pkt)$ WARNING:LEADING_SPACE: please, no spaces at the start of a line #572: FILE: drivers/net/r8169/r8169_rxtx.c:1156: + struct rte_mbuf *tx_pkt)$ CHECK:BRACES: Blank lines aren't necessary after an open brace '{' #574: FILE: drivers/net/r8169/r8169_rxtx.c:1158: +{ + CHECK:CAMELCASE: Avoid CamelCase: #600: FILE: drivers/net/r8169/r8169_rxtx.c:1184: + opts[0] = DescOwn; CHECK:CAMELCASE: Avoid CamelCase: #632: FILE: drivers/net/r8169/r8169_rxtx.c:1216: + opts1 |= FirstFrag; CHECK:CAMELCASE: Avoid CamelCase: #634: FILE: drivers/net/r8169/r8169_rxtx.c:1218: + opts1 |= LastFrag; CHECK:CAMELCASE: Avoid CamelCase: #672: FILE: drivers/net/r8169/r8169_rxtx.c:1256: + switch (hw->HwSuppTxNoCloseVer) { CHECK:CAMELCASE: Avoid CamelCase: #698: FILE: drivers/net/r8169/r8169_rxtx.c:1282: + const uint8_t enable_tx_no_close = hw->EnableTxNoClose; ERROR:CODE_INDENT: code indent should use tabs where possible #712: FILE: drivers/net/r8169/r8169_rxtx.c:1296: +^I^I hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);$ CHECK:CAMELCASE: Avoid CamelCase: #712: FILE: drivers/net/r8169/r8169_rxtx.c:1296: + hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask); WARNING:LONG_LINE: line length of 101 exceeds 100 columns #714: FILE: drivers/net/r8169/r8169_rxtx.c:1298: + rte_memory_order_relaxed) % nb_tx_desc) - head), tx_desc_closed); ERROR:CODE_INDENT: code indent should use tabs where possible #714: FILE: drivers/net/r8169/r8169_rxtx.c:1298: +^I^I rte_memory_order_relaxed) % nb_tx_desc) - head), tx_desc_closed);$ CHECK:BRACES: Unbalanced braces around else statement #716: FILE: drivers/net/r8169/r8169_rxtx.c:1300: + } else ERROR:CODE_INDENT: code indent should use tabs where possible #718: FILE: drivers/net/r8169/r8169_rxtx.c:1302: +^I^I rte_memory_order_relaxed) % nb_tx_desc) - head;$ ERROR:CODE_INDENT: code indent should use tabs where possible #764: FILE: drivers/net/r8169/r8169_rxtx.c:1348: +^I^I hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);$ WARNING:LONG_LINE: line length of 101 exceeds 100 columns #766: FILE: drivers/net/r8169/r8169_rxtx.c:1350: + rte_memory_order_relaxed) % nb_tx_desc) - head), tx_desc_closed); ERROR:CODE_INDENT: code indent should use tabs where possible #766: FILE: drivers/net/r8169/r8169_rxtx.c:1350: +^I^I rte_memory_order_relaxed) % nb_tx_desc) - head), tx_desc_closed);$ CHECK:BRACES: Unbalanced braces around else statement #768: FILE: drivers/net/r8169/r8169_rxtx.c:1352: + } else ERROR:CODE_INDENT: code indent should use tabs where possible #770: FILE: drivers/net/r8169/r8169_rxtx.c:1354: +^I^I rte_memory_order_relaxed) % nb_tx_desc) - head;$ CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #797: FILE: drivers/net/r8169/r8169_rxtx.c:1381: + + } ERROR:CODE_INDENT: code indent should use tabs where possible #829: FILE: drivers/net/r8169/r8169_rxtx.c:1413: +^I "port %d txq %d pkts: %d tx_free=%d tx_tail=%d tx_head=%d",$ ERROR:CODE_INDENT: code indent should use tabs where possible #830: FILE: drivers/net/r8169/r8169_rxtx.c:1414: +^I txq->port_id, txq->queue_id, nb_pkts, txq->tx_free,$ ERROR:CODE_INDENT: code indent should use tabs where possible #831: FILE: drivers/net/r8169/r8169_rxtx.c:1415: +^I txq->tx_tail, txq->tx_head);$ WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rtl_xmit_pkts', this function's name, in a string #852: FILE: drivers/net/r8169/r8169_rxtx.c:1436: + PMD_TX_LOG(DEBUG, "rtl_xmit_pkts %d transmitted", nb_tx); total: 37 errors, 11 warnings, 27 checks, 790 lines checked Warning in drivers/net/r8169/r8169_rxtx.c: Using rte_smp_[r/w]mb