* |WARNING| pw146804 [PATCH v3 05/18] net/r8169: add support for hw config
[not found] <20241023033328.191827-6-howard_wang@realsil.com.cn>
@ 2024-10-23 3:35 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-10-23 3:35 UTC (permalink / raw)
To: test-report; +Cc: Howard Wang
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146804
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <InterFrameGap>
#238: FILE: drivers/net/r8169/r8169_base.h:510:
+#define InterFrameGap 0x03 /* 3 means InterFrameGap = the shortest one */
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#269: FILE: drivers/net/r8169/r8169_ethdev.h:20:
+ u8 HwSuppIntMitiVer;
CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#272: FILE: drivers/net/r8169/r8169_ethdev.h:23:
+ u8 EnableTxNoClose;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#275: FILE: drivers/net/r8169/r8169_ethdev.h:26:
+ u8 HwSuppDashVer;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#277: FILE: drivers/net/r8169/r8169_ethdev.h:28:
+ u8 HwSuppOcpChannelVer;
CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#278: FILE: drivers/net/r8169/r8169_ethdev.h:29:
+ u8 AllowAccessDashOcp;
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Addr_Align>
#305: FILE: drivers/net/r8169/r8169_hw.c:32:
+ val_shift = addr % ERIAR_Addr_Align;
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Read>
#308: FILE: drivers/net/r8169/r8169_hw.c:35:
+ eri_cmd = ERIAR_Read | transformed_base_address |
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Type_shift>
#309: FILE: drivers/net/r8169/r8169_hw.c:36:
+ type << ERIAR_Type_shift |
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ByteEn>
#310: FILE: drivers/net/r8169/r8169_hw.c:37:
+ ERIAR_ByteEn << ERIAR_ByteEn_shift |
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ByteEn_shift>
#310: FILE: drivers/net/r8169/r8169_hw.c:37:
+ ERIAR_ByteEn << ERIAR_ByteEn_shift |
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Flag>
#324: FILE: drivers/net/r8169/r8169_hw.c:51:
+ if (RTL_R32(hw, ERIAR) & ERIAR_Flag)
CHECK:BRACES: braces {} should be used on all arms of this statement
#340: FILE: drivers/net/r8169/r8169_hw.c:67:
+ if (len <= 4 - val_shift)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#342: FILE: drivers/net/r8169/r8169_hw.c:69:
+ else {
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Write>
#386: FILE: drivers/net/r8169/r8169_hw.c:113:
+ eri_cmd = ERIAR_Write | transformed_base_address |
CHECK:BRACES: braces {} should be used on all arms of this statement
#406: FILE: drivers/net/r8169/r8169_hw.c:133:
+ if (len <= 4 - val_shift)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#408: FILE: drivers/net/r8169/r8169_hw.c:135:
+ else {
CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#505: FILE: drivers/net/r8169/r8169_hw.c:232:
+
+ }
CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#574: FILE: drivers/net/r8169/r8169_hw.c:372:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);
CHECK:CAMELCASE: Avoid CamelCase: <StopReq>
#574: FILE: drivers/net/r8169/r8169_hw.c:372:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);
CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#592: FILE: drivers/net/r8169/r8169_hw.c:390:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));
CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#592: FILE: drivers/net/r8169/r8169_hw.c:390:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));
CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#605: FILE: drivers/net/r8169/r8169_hw.c:403:
+ if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==
CHECK:CAMELCASE: Avoid CamelCase: <Txfifo_empty>
#605: FILE: drivers/net/r8169/r8169_hw.c:403:
+ if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==
CHECK:CAMELCASE: Avoid CamelCase: <Rxfifo_empty>
#605: FILE: drivers/net/r8169/r8169_hw.c:403:
+ if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==
CHECK:CAMELCASE: Avoid CamelCase: <IntrMitigate>
#619: FILE: drivers/net/r8169/r8169_hw.c:417:
+ if ((RTL_R16(hw, IntrMitigate) & (BIT_0 | BIT_1 | BIT_8)) ==
CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#630: FILE: drivers/net/r8169/r8169_hw.c:428:
+ RTL_W32(hw, RxConfig, RTL_R32(hw, RxConfig) &
CHECK:CAMELCASE: Avoid CamelCase: <AcceptErr>
#631: FILE: drivers/net/r8169/r8169_hw.c:429:
+ ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |
CHECK:CAMELCASE: Avoid CamelCase: <AcceptRunt>
#631: FILE: drivers/net/r8169/r8169_hw.c:429:
+ ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |
CHECK:CAMELCASE: Avoid CamelCase: <AcceptBroadcast>
#631: FILE: drivers/net/r8169/r8169_hw.c:429:
+ ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |
CHECK:CAMELCASE: Avoid CamelCase: <AcceptMulticast>
#631: FILE: drivers/net/r8169/r8169_hw.c:429:
+ ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |
CHECK:CAMELCASE: Avoid CamelCase: <AcceptMyPhys>
#632: FILE: drivers/net/r8169/r8169_hw.c:430:
+ AcceptMyPhys | AcceptAllPhys));
CHECK:CAMELCASE: Avoid CamelCase: <AcceptAllPhys>
#632: FILE: drivers/net/r8169/r8169_hw.c:430:
+ AcceptMyPhys | AcceptAllPhys));
CHECK:CAMELCASE: Avoid CamelCase: <CmdReset>
#651: FILE: drivers/net/r8169/r8169_hw.c:449:
+ RTL_W8(hw, ChipCmd, CmdReset);
CHECK:CAMELCASE: Avoid CamelCase: <Cfg9346>
#664: FILE: drivers/net/r8169/r8169_hw.c:462:
+ RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock);
CHECK:CAMELCASE: Avoid CamelCase: <Cfg9346_Unlock>
#664: FILE: drivers/net/r8169/r8169_hw.c:462:
+ RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock);
CHECK:CAMELCASE: Avoid CamelCase: <Config2>
#690: FILE: drivers/net/r8169/r8169_hw.c:488:
+ RTL_W8(hw, Config2, RTL_R8(hw, Config2) | BIT_7);
CHECK:CAMELCASE: Avoid CamelCase: <Config5>
#691: FILE: drivers/net/r8169/r8169_hw.c:489:
+ RTL_W8(hw, Config5, RTL_R8(hw, Config5) | BIT_0);
ERROR:TRAILING_WHITESPACE: trailing whitespace
#752: FILE: drivers/net/r8169/r8169_hw.c:550:
+^I$
CHECK:CAMELCASE: Avoid CamelCase: <RxCfgDMAShift>
#786: FILE: drivers/net/r8169/r8169_hw.c:584:
+ RTL_W32(hw, RxConfig, (RX_DMA_BURST_unlimited << RxCfgDMAShift));
CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#811: FILE: drivers/net/r8169/r8169_hw.c:609:
+ RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) |
CHECK:CAMELCASE: Avoid CamelCase: <TxDMAShift>
#811: FILE: drivers/net/r8169/r8169_hw.c:609:
+ RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) |
CHECK:CAMELCASE: Avoid CamelCase: <TxInterFrameGapShift>
#812: FILE: drivers/net/r8169/r8169_hw.c:610:
+ (InterFrameGap << TxInterFrameGapShift));
CHECK:CAMELCASE: Avoid CamelCase: <Config1>
#841: FILE: drivers/net/r8169/r8169_hw.c:639:
+ RTL_W8(hw, Config1, RTL_R8(hw, Config1) & ~0x10);
CHECK:CAMELCASE: Avoid CamelCase: <EnableRxDescV4_0>
#986: FILE: drivers/net/r8169/r8169_hw.c:784:
+ RTL_W8(hw, 0xd8, RTL_R8(hw, 0xd8) & ~EnableRxDescV4_0);
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1050: FILE: drivers/net/r8169/r8169_phy.c:2:
+ * Copyright(c) 2024 Realtek Corporation. All rights reserved */
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1053: FILE: drivers/net/r8169/r8169_phy.c:5:
+#include <stdio.h>
total: 1 errors, 2 warnings, 44 checks, 990 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-10-23 3:35 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20241023033328.191827-6-howard_wang@realsil.com.cn>
2024-10-23 3:35 ` |WARNING| pw146804 [PATCH v3 05/18] net/r8169: add support for hw config checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).