From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEFD445BA9 for ; Wed, 23 Oct 2024 05:35:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EAAF84064A; Wed, 23 Oct 2024 05:35:17 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 7C8E64026C for ; Wed, 23 Oct 2024 05:35:16 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 5DFE51206AA; Wed, 23 Oct 2024 05:35:16 +0200 (CEST) Subject: |WARNING| pw146804 [PATCH v3 05/18] net/r8169: add support for hw config In-Reply-To: <20241023033328.191827-6-howard_wang@realsil.com.cn> References: <20241023033328.191827-6-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241023033516.5DFE51206AA@dpdk.org> Date: Wed, 23 Oct 2024 05:35:16 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/146804 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #238: FILE: drivers/net/r8169/r8169_base.h:510: +#define InterFrameGap 0x03 /* 3 means InterFrameGap = the shortest one */ CHECK:CAMELCASE: Avoid CamelCase: #269: FILE: drivers/net/r8169/r8169_ethdev.h:20: + u8 HwSuppIntMitiVer; CHECK:CAMELCASE: Avoid CamelCase: #272: FILE: drivers/net/r8169/r8169_ethdev.h:23: + u8 EnableTxNoClose; CHECK:CAMELCASE: Avoid CamelCase: #275: FILE: drivers/net/r8169/r8169_ethdev.h:26: + u8 HwSuppDashVer; CHECK:CAMELCASE: Avoid CamelCase: #277: FILE: drivers/net/r8169/r8169_ethdev.h:28: + u8 HwSuppOcpChannelVer; CHECK:CAMELCASE: Avoid CamelCase: #278: FILE: drivers/net/r8169/r8169_ethdev.h:29: + u8 AllowAccessDashOcp; CHECK:CAMELCASE: Avoid CamelCase: #305: FILE: drivers/net/r8169/r8169_hw.c:32: + val_shift = addr % ERIAR_Addr_Align; CHECK:CAMELCASE: Avoid CamelCase: #308: FILE: drivers/net/r8169/r8169_hw.c:35: + eri_cmd = ERIAR_Read | transformed_base_address | CHECK:CAMELCASE: Avoid CamelCase: #309: FILE: drivers/net/r8169/r8169_hw.c:36: + type << ERIAR_Type_shift | CHECK:CAMELCASE: Avoid CamelCase: #310: FILE: drivers/net/r8169/r8169_hw.c:37: + ERIAR_ByteEn << ERIAR_ByteEn_shift | CHECK:CAMELCASE: Avoid CamelCase: #310: FILE: drivers/net/r8169/r8169_hw.c:37: + ERIAR_ByteEn << ERIAR_ByteEn_shift | CHECK:CAMELCASE: Avoid CamelCase: #324: FILE: drivers/net/r8169/r8169_hw.c:51: + if (RTL_R32(hw, ERIAR) & ERIAR_Flag) CHECK:BRACES: braces {} should be used on all arms of this statement #340: FILE: drivers/net/r8169/r8169_hw.c:67: + if (len <= 4 - val_shift) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #342: FILE: drivers/net/r8169/r8169_hw.c:69: + else { CHECK:CAMELCASE: Avoid CamelCase: #386: FILE: drivers/net/r8169/r8169_hw.c:113: + eri_cmd = ERIAR_Write | transformed_base_address | CHECK:BRACES: braces {} should be used on all arms of this statement #406: FILE: drivers/net/r8169/r8169_hw.c:133: + if (len <= 4 - val_shift) [...] + else { [...] CHECK:BRACES: Unbalanced braces around else statement #408: FILE: drivers/net/r8169/r8169_hw.c:135: + else { CHECK:BRACES: Blank lines aren't necessary before a close brace '}' #505: FILE: drivers/net/r8169/r8169_hw.c:232: + + } CHECK:CAMELCASE: Avoid CamelCase: #574: FILE: drivers/net/r8169/r8169_hw.c:372: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq); CHECK:CAMELCASE: Avoid CamelCase: #574: FILE: drivers/net/r8169/r8169_hw.c:372: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq); CHECK:CAMELCASE: Avoid CamelCase: #592: FILE: drivers/net/r8169/r8169_hw.c:390: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb)); CHECK:CAMELCASE: Avoid CamelCase: #592: FILE: drivers/net/r8169/r8169_hw.c:390: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb)); CHECK:CAMELCASE: Avoid CamelCase: #605: FILE: drivers/net/r8169/r8169_hw.c:403: + if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) == CHECK:CAMELCASE: Avoid CamelCase: #605: FILE: drivers/net/r8169/r8169_hw.c:403: + if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) == CHECK:CAMELCASE: Avoid CamelCase: #605: FILE: drivers/net/r8169/r8169_hw.c:403: + if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) == CHECK:CAMELCASE: Avoid CamelCase: #619: FILE: drivers/net/r8169/r8169_hw.c:417: + if ((RTL_R16(hw, IntrMitigate) & (BIT_0 | BIT_1 | BIT_8)) == CHECK:CAMELCASE: Avoid CamelCase: #630: FILE: drivers/net/r8169/r8169_hw.c:428: + RTL_W32(hw, RxConfig, RTL_R32(hw, RxConfig) & CHECK:CAMELCASE: Avoid CamelCase: #631: FILE: drivers/net/r8169/r8169_hw.c:429: + ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast | CHECK:CAMELCASE: Avoid CamelCase: #631: FILE: drivers/net/r8169/r8169_hw.c:429: + ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast | CHECK:CAMELCASE: Avoid CamelCase: #631: FILE: drivers/net/r8169/r8169_hw.c:429: + ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast | CHECK:CAMELCASE: Avoid CamelCase: #631: FILE: drivers/net/r8169/r8169_hw.c:429: + ~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast | CHECK:CAMELCASE: Avoid CamelCase: #632: FILE: drivers/net/r8169/r8169_hw.c:430: + AcceptMyPhys | AcceptAllPhys)); CHECK:CAMELCASE: Avoid CamelCase: #632: FILE: drivers/net/r8169/r8169_hw.c:430: + AcceptMyPhys | AcceptAllPhys)); CHECK:CAMELCASE: Avoid CamelCase: #651: FILE: drivers/net/r8169/r8169_hw.c:449: + RTL_W8(hw, ChipCmd, CmdReset); CHECK:CAMELCASE: Avoid CamelCase: #664: FILE: drivers/net/r8169/r8169_hw.c:462: + RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock); CHECK:CAMELCASE: Avoid CamelCase: #664: FILE: drivers/net/r8169/r8169_hw.c:462: + RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock); CHECK:CAMELCASE: Avoid CamelCase: #690: FILE: drivers/net/r8169/r8169_hw.c:488: + RTL_W8(hw, Config2, RTL_R8(hw, Config2) | BIT_7); CHECK:CAMELCASE: Avoid CamelCase: #691: FILE: drivers/net/r8169/r8169_hw.c:489: + RTL_W8(hw, Config5, RTL_R8(hw, Config5) | BIT_0); ERROR:TRAILING_WHITESPACE: trailing whitespace #752: FILE: drivers/net/r8169/r8169_hw.c:550: +^I$ CHECK:CAMELCASE: Avoid CamelCase: #786: FILE: drivers/net/r8169/r8169_hw.c:584: + RTL_W32(hw, RxConfig, (RX_DMA_BURST_unlimited << RxCfgDMAShift)); CHECK:CAMELCASE: Avoid CamelCase: #811: FILE: drivers/net/r8169/r8169_hw.c:609: + RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) | CHECK:CAMELCASE: Avoid CamelCase: #811: FILE: drivers/net/r8169/r8169_hw.c:609: + RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) | CHECK:CAMELCASE: Avoid CamelCase: #812: FILE: drivers/net/r8169/r8169_hw.c:610: + (InterFrameGap << TxInterFrameGapShift)); CHECK:CAMELCASE: Avoid CamelCase: #841: FILE: drivers/net/r8169/r8169_hw.c:639: + RTL_W8(hw, Config1, RTL_R8(hw, Config1) & ~0x10); CHECK:CAMELCASE: Avoid CamelCase: #986: FILE: drivers/net/r8169/r8169_hw.c:784: + RTL_W8(hw, 0xd8, RTL_R8(hw, 0xd8) & ~EnableRxDescV4_0); WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line #1050: FILE: drivers/net/r8169/r8169_phy.c:2: + * Copyright(c) 2024 Realtek Corporation. All rights reserved */ WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'? #1053: FILE: drivers/net/r8169/r8169_phy.c:5: +#include total: 1 errors, 2 warnings, 44 checks, 990 lines checked