|WARNING| pw146811 [PATCH v3 12/18] net/r8169: implement Tx path

|WARNING| pw146811 [PATCH v3 12/18] net/r8169: implement Tx path

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146811

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <NextHwDesCloPtr0>
#107: FILE: drivers/net/r8169/r8169_ethdev.h:80:
+	u32 NextHwDesCloPtr0;

CHECK:CAMELCASE: Avoid CamelCase: <BeginHwDesCloPtr0>
#108: FILE: drivers/net/r8169/r8169_ethdev.h:81:
+	u32 BeginHwDesCloPtr0;

CHECK:SPACING: No space is necessary after a cast
#198: FILE: drivers/net/r8169/r8169_rxtx.c:79:
+	RTE_ATOMIC(uint32_t) tx_tail;

CHECK:CAMELCASE: Avoid CamelCase: <RingEnd>
#312: FILE: drivers/net/r8169/r8169_rxtx.c:899:
+	txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd);

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrLow>
#423: FILE: drivers/net/r8169/r8169_rxtx.c:1010:
+	RTL_W32(hw, TxDescStartAddrLow,

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrHigh>
#425: FILE: drivers/net/r8169/r8169_rxtx.c:1012:
+	RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32));

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#439: FILE: drivers/net/r8169/r8169_rxtx.c:1026:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#439: FILE: drivers/net/r8169/r8169_rxtx.c:1026:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <TxVlanTag>
#452: FILE: drivers/net/r8169/r8169_rxtx.c:1037:
+	       (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) :

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv4>
#469: FILE: drivers/net/r8169/r8169_rxtx.c:1054:
+				opts[0] |= GiantSendv4;

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv6>
#471: FILE: drivers/net/r8169/r8169_rxtx.c:1056:
+				opts[0] |= GiantSendv6;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS_C>
#491: FILE: drivers/net/r8169/r8169_rxtx.c:1076:
+		csum_cmd |= TxIPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS_C>
#495: FILE: drivers/net/r8169/r8169_rxtx.c:1080:
+		csum_cmd |= TxUDPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS_C>
#498: FILE: drivers/net/r8169/r8169_rxtx.c:1083:
+		csum_cmd |= TxTCPCS_C;

CHECK:BRACES: braces {} should be used on all arms of this statement
#503: FILE: drivers/net/r8169/r8169_rxtx.c:1088:
+		if (ol_flags & RTE_MBUF_F_TX_IPV6) {
[...]
+		} else
[...]

CHECK:CAMELCASE: Avoid CamelCase: <TxIPV6F_C>
#505: FILE: drivers/net/r8169/r8169_rxtx.c:1090:
+			csum_cmd |= TxIPV6F_C;

CHECK:BRACES: Unbalanced braces around else statement
#507: FILE: drivers/net/r8169/r8169_rxtx.c:1092:
+		} else

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->data_len < 175'
#521: FILE: drivers/net/r8169/r8169_rxtx.c:1106:
+	if (!(tx_pkt->l4_len && (tx_pkt->data_len < 175)))

CHECK:CAMELCASE: Avoid CamelCase: <DescOwn>
#597: FILE: drivers/net/r8169/r8169_rxtx.c:1182:
+	opts[0] = DescOwn;

CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag>
#629: FILE: drivers/net/r8169/r8169_rxtx.c:1214:
+			opts1 |= FirstFrag;

CHECK:CAMELCASE: Avoid CamelCase: <LastFrag>
#631: FILE: drivers/net/r8169/r8169_rxtx.c:1216:
+			opts1 |= LastFrag;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#669: FILE: drivers/net/r8169/r8169_rxtx.c:1254:
+	switch (hw->HwSuppTxNoCloseVer) {

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#695: FILE: drivers/net/r8169/r8169_rxtx.c:1280:
+	const uint8_t enable_tx_no_close = hw->EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#709: FILE: drivers/net/r8169/r8169_rxtx.c:1294:
+						   hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);

CHECK:BRACES: Unbalanced braces around else statement
#714: FILE: drivers/net/r8169/r8169_rxtx.c:1299:
+	} else

CHECK:BRACES: Unbalanced braces around else statement
#767: FILE: drivers/net/r8169/r8169_rxtx.c:1352:
+	} else

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rtl_xmit_pkts', this function's name, in a string
#850: FILE: drivers/net/r8169/r8169_rxtx.c:1435:
+	PMD_TX_LOG(DEBUG, "rtl_xmit_pkts %d transmitted", nb_tx);

total: 0 errors, 1 warnings, 26 checks, 789 lines checked
Warning in drivers/net/r8169/r8169_rxtx.c:
Using rte_smp_[r/w]mb