From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3FC1E45BA9 for ; Wed, 23 Oct 2024 05:37:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3AB494026C; Wed, 23 Oct 2024 05:37:33 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 6548E40151 for ; Wed, 23 Oct 2024 05:37:32 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 51CE21206AA; Wed, 23 Oct 2024 05:37:32 +0200 (CEST) Subject: |WARNING| pw146811 [PATCH v3 12/18] net/r8169: implement Tx path In-Reply-To: <20241023033328.191827-13-howard_wang@realsil.com.cn> References: <20241023033328.191827-13-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241023033732.51CE21206AA@dpdk.org> Date: Wed, 23 Oct 2024 05:37:32 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/146811 _coding style issues_ CHECK:CAMELCASE: Avoid CamelCase: #107: FILE: drivers/net/r8169/r8169_ethdev.h:80: + u32 NextHwDesCloPtr0; CHECK:CAMELCASE: Avoid CamelCase: #108: FILE: drivers/net/r8169/r8169_ethdev.h:81: + u32 BeginHwDesCloPtr0; CHECK:SPACING: No space is necessary after a cast #198: FILE: drivers/net/r8169/r8169_rxtx.c:79: + RTE_ATOMIC(uint32_t) tx_tail; CHECK:CAMELCASE: Avoid CamelCase: #312: FILE: drivers/net/r8169/r8169_rxtx.c:899: + txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd); CHECK:CAMELCASE: Avoid CamelCase: #423: FILE: drivers/net/r8169/r8169_rxtx.c:1010: + RTL_W32(hw, TxDescStartAddrLow, CHECK:CAMELCASE: Avoid CamelCase: #425: FILE: drivers/net/r8169/r8169_rxtx.c:1012: + RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32)); CHECK:CAMELCASE: Avoid CamelCase: #439: FILE: drivers/net/r8169/r8169_rxtx.c:1026: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb); CHECK:CAMELCASE: Avoid CamelCase: #439: FILE: drivers/net/r8169/r8169_rxtx.c:1026: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb); CHECK:CAMELCASE: Avoid CamelCase: #452: FILE: drivers/net/r8169/r8169_rxtx.c:1037: + (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) : CHECK:CAMELCASE: Avoid CamelCase: #469: FILE: drivers/net/r8169/r8169_rxtx.c:1054: + opts[0] |= GiantSendv4; CHECK:CAMELCASE: Avoid CamelCase: #471: FILE: drivers/net/r8169/r8169_rxtx.c:1056: + opts[0] |= GiantSendv6; CHECK:CAMELCASE: Avoid CamelCase: #491: FILE: drivers/net/r8169/r8169_rxtx.c:1076: + csum_cmd |= TxIPCS_C; CHECK:CAMELCASE: Avoid CamelCase: #495: FILE: drivers/net/r8169/r8169_rxtx.c:1080: + csum_cmd |= TxUDPCS_C; CHECK:CAMELCASE: Avoid CamelCase: #498: FILE: drivers/net/r8169/r8169_rxtx.c:1083: + csum_cmd |= TxTCPCS_C; CHECK:BRACES: braces {} should be used on all arms of this statement #503: FILE: drivers/net/r8169/r8169_rxtx.c:1088: + if (ol_flags & RTE_MBUF_F_TX_IPV6) { [...] + } else [...] CHECK:CAMELCASE: Avoid CamelCase: #505: FILE: drivers/net/r8169/r8169_rxtx.c:1090: + csum_cmd |= TxIPV6F_C; CHECK:BRACES: Unbalanced braces around else statement #507: FILE: drivers/net/r8169/r8169_rxtx.c:1092: + } else CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->data_len < 175' #521: FILE: drivers/net/r8169/r8169_rxtx.c:1106: + if (!(tx_pkt->l4_len && (tx_pkt->data_len < 175))) CHECK:CAMELCASE: Avoid CamelCase: #597: FILE: drivers/net/r8169/r8169_rxtx.c:1182: + opts[0] = DescOwn; CHECK:CAMELCASE: Avoid CamelCase: #629: FILE: drivers/net/r8169/r8169_rxtx.c:1214: + opts1 |= FirstFrag; CHECK:CAMELCASE: Avoid CamelCase: #631: FILE: drivers/net/r8169/r8169_rxtx.c:1216: + opts1 |= LastFrag; CHECK:CAMELCASE: Avoid CamelCase: #669: FILE: drivers/net/r8169/r8169_rxtx.c:1254: + switch (hw->HwSuppTxNoCloseVer) { CHECK:CAMELCASE: Avoid CamelCase: #695: FILE: drivers/net/r8169/r8169_rxtx.c:1280: + const uint8_t enable_tx_no_close = hw->EnableTxNoClose; CHECK:CAMELCASE: Avoid CamelCase: #709: FILE: drivers/net/r8169/r8169_rxtx.c:1294: + hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask); CHECK:BRACES: Unbalanced braces around else statement #714: FILE: drivers/net/r8169/r8169_rxtx.c:1299: + } else CHECK:BRACES: Unbalanced braces around else statement #767: FILE: drivers/net/r8169/r8169_rxtx.c:1352: + } else WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rtl_xmit_pkts', this function's name, in a string #850: FILE: drivers/net/r8169/r8169_rxtx.c:1435: + PMD_TX_LOG(DEBUG, "rtl_xmit_pkts %d transmitted", nb_tx); total: 0 errors, 1 warnings, 26 checks, 789 lines checked Warning in drivers/net/r8169/r8169_rxtx.c: Using rte_smp_[r/w]mb