automatic DPDK test reports
 help / color / mirror / Atom feed
* |WARNING| pw146809 [PATCH v3 10/18] net/r8169: add link status and interrupt management
       [not found] <20241023033328.191827-11-howard_wang@realsil.com.cn>
@ 2024-10-23  3:37 ` checkpatch
  0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-10-23  3:37 UTC (permalink / raw)
  To: test-report; +Cc: Howard Wang

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146809

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <LinkChg>
#141: FILE: drivers/net/r8169/r8169_ethdev.c:83:
+	RTL_W32(hw, IMR0_8125, LinkChg);

CHECK:BRACES: braces {} should be used on all arms of this statement
#153: FILE: drivers/net/r8169/r8169_ethdev.c:95:
+	if (*link_speeds == RTE_ETH_LINK_SPEED_AUTONEG)
[...]
+	else if (*link_speeds != 0) {
[...]

CHECK:CAMELCASE: Avoid CamelCase: <PHYstatus>
#226: FILE: drivers/net/r8169/r8169_ethdev.c:168:
+		if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {

CHECK:CAMELCASE: Avoid CamelCase: <LinkStatus>
#226: FILE: drivers/net/r8169/r8169_ethdev.c:168:
+		if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {

CHECK:CAMELCASE: Avoid CamelCase: <FullDup>
#357: FILE: drivers/net/r8169/r8169_ethdev.c:326:
+		if (status & FullDup) {

CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#360: FILE: drivers/net/r8169/r8169_ethdev.c:329:
+				RTL_W32(hw, TxConfig, (RTL_R32(hw, TxConfig) |

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#511: FILE: drivers/net/r8169/r8169_hw.c:1094:
+		hw->HwSuppMaxPhyLinkSpeed = SPEED_2500;

WARNING:TYPO_SPELLING: 'lite' may be misspelled - perhaps 'light'?
#586: FILE: drivers/net/r8169/r8169_phy.c:820:
+	/* Disable giga lite */

total: 0 errors, 2 warnings, 7 checks, 555 lines checked

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2024-10-23  3:37 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20241023033328.191827-11-howard_wang@realsil.com.cn>
2024-10-23  3:37 ` |WARNING| pw146809 [PATCH v3 10/18] net/r8169: add link status and interrupt management checkpatch

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).