From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 7004945BA9
	for <public@inbox.dpdk.org>; Wed, 23 Oct 2024 05:37:52 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6B0F44066C;
	Wed, 23 Oct 2024 05:37:52 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 46B9C4066C
 for <test-report@dpdk.org>; Wed, 23 Oct 2024 05:37:51 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 3C5821206AA; Wed, 23 Oct 2024 05:37:51 +0200 (CEST)
Subject: |WARNING| pw146809 [PATCH v3 10/18] net/r8169: add link status and
 interrupt management
In-Reply-To: <20241023033328.191827-11-howard_wang@realsil.com.cn>
References: <20241023033328.191827-11-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241023033751.3C5821206AA@dpdk.org>
Date: Wed, 23 Oct 2024 05:37:51 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146809

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <LinkChg>
#141: FILE: drivers/net/r8169/r8169_ethdev.c:83:
+	RTL_W32(hw, IMR0_8125, LinkChg);

CHECK:BRACES: braces {} should be used on all arms of this statement
#153: FILE: drivers/net/r8169/r8169_ethdev.c:95:
+	if (*link_speeds == RTE_ETH_LINK_SPEED_AUTONEG)
[...]
+	else if (*link_speeds != 0) {
[...]

CHECK:CAMELCASE: Avoid CamelCase: <PHYstatus>
#226: FILE: drivers/net/r8169/r8169_ethdev.c:168:
+		if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {

CHECK:CAMELCASE: Avoid CamelCase: <LinkStatus>
#226: FILE: drivers/net/r8169/r8169_ethdev.c:168:
+		if (!(RTL_R16(hw, PHYstatus) & LinkStatus)) {

CHECK:CAMELCASE: Avoid CamelCase: <FullDup>
#357: FILE: drivers/net/r8169/r8169_ethdev.c:326:
+		if (status & FullDup) {

CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#360: FILE: drivers/net/r8169/r8169_ethdev.c:329:
+				RTL_W32(hw, TxConfig, (RTL_R32(hw, TxConfig) |

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#511: FILE: drivers/net/r8169/r8169_hw.c:1094:
+		hw->HwSuppMaxPhyLinkSpeed = SPEED_2500;

WARNING:TYPO_SPELLING: 'lite' may be misspelled - perhaps 'light'?
#586: FILE: drivers/net/r8169/r8169_phy.c:820:
+	/* Disable giga lite */

total: 0 errors, 2 warnings, 7 checks, 555 lines checked