* |WARNING| pw146808 [PATCH v3 09/18] net/r8169: add support for hw initialization
[not found] <20241023033328.191827-10-howard_wang@realsil.com.cn>
@ 2024-10-23 3:38 ` checkpatch
0 siblings, 0 replies; only message in thread
From: checkpatch @ 2024-10-23 3:38 UTC (permalink / raw)
To: test-report; +Cc: Howard Wang
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/146808
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#172: FILE: drivers/net/r8169/r8169_dash.c:6:
+#include <stdio.h>
CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#231: FILE: drivers/net/r8169/r8169_dash.c:65:
+ if (!hw->AllowAccessDashOcp)
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#278: FILE: drivers/net/r8169/r8169_dash.h:17:
+#define HW_DASH_SUPPORT_DASH(_M) ((_M)->HwSuppDashVer > 0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#284: FILE: drivers/net/r8169/r8169_dash.h:23:
+#define HW_DASH_SUPPORT_GET_FIRMWARE_VERSION(_M) (HW_DASH_SUPPORT_TYPE_2(_M) || \
+ HW_DASH_SUPPORT_TYPE_3(_M) || \
+ HW_DASH_SUPPORT_TYPE_4(_M))
CHECK:CAMELCASE: Avoid CamelCase: <HwIcVerUnknown>
#411: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+ u8 HwIcVerUnknown;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppNowIsOobVer>
#432: FILE: drivers/net/r8169/r8169_ethdev.h:69:
+ u8 HwSuppNowIsOobVer;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#438: FILE: drivers/net/r8169/r8169_ethdev.h:74:
+ u8 HwSuppTxNoCloseVer;
CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#439: FILE: drivers/net/r8169/r8169_ethdev.h:75:
+ u8 EnableTxNoClose;
CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#442: FILE: drivers/net/r8169/r8169_ethdev.h:78:
+ u32 MaxTxDescPtrMask;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#516: FILE: drivers/net/r8169/r8169_hw.c:979:
+ speed = RTE_MIN(speed, hw->HwSuppMaxPhyLinkSpeed);
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#569: FILE: drivers/net/r8169/r8169_hw.c:1032:
+ hw->HwSuppOcpChannelVer = 2;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#625: FILE: drivers/net/r8169/r8169_hw.c:1088:
+ hw->HwSuppCheckPhyDisableModeVer = 3;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#731: FILE: drivers/net/r8169/r8169_hw.c:1194:
+ hw->NotWrRamCodeToMicroP = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrMcuPatchCode>
#732: FILE: drivers/net/r8169/r8169_hw.c:1195:
+ hw->NotWrMcuPatchCode = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMacMcuVer>
#738: FILE: drivers/net/r8169/r8169_hw.c:1201:
+ hw->HwSuppMacMcuVer = 2;
CHECK:CAMELCASE: Avoid CamelCase: <MacMcuPageSize>
#745: FILE: drivers/net/r8169/r8169_hw.c:1208:
+ hw->MacMcuPageSize = RTL_MAC_MCU_PAGE_SIZE;
CHECK:CAMELCASE: Avoid CamelCase: <RequirePhyMdiSwapPatch>
#754: FILE: drivers/net/r8169/r8169_hw.c:1217:
+ hw->RequirePhyMdiSwapPatch = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#762: FILE: drivers/net/r8169/r8169_hw.c:1225:
+ hw->HwSuppIntMitiVer = 3;
CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#807: FILE: drivers/net/r8169/r8169_hw.c:1270:
+ RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);
CHECK:CAMELCASE: Avoid CamelCase: <Now_is_oob>
#807: FILE: drivers/net/r8169/r8169_hw.c:1270:
+ RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);
CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#918: FILE: drivers/net/r8169/r8169_hw.c:1381:
+ val32 = RTL_R32(hw, TxConfig);
CHECK:BRACES: braces {} should be used on all arms of this statement
#924: FILE: drivers/net/r8169/r8169_hw.c:1387:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#930: FILE: drivers/net/r8169/r8169_hw.c:1393:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#938: FILE: drivers/net/r8169/r8169_hw.c:1401:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#944: FILE: drivers/net/r8169/r8169_hw.c:1407:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#952: FILE: drivers/net/r8169/r8169_hw.c:1415:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#956: FILE: drivers/net/r8169/r8169_hw.c:1419:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#964: FILE: drivers/net/r8169/r8169_hw.c:1427:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#968: FILE: drivers/net/r8169/r8169_hw.c:1431:
+ else {
CHECK:BRACES: braces {} should be used on all arms of this statement
#976: FILE: drivers/net/r8169/r8169_hw.c:1439:
+ if (ic_version_id == 0x00000000)
[...]
+ else if (ic_version_id == 0x100000)
[...]
+ else if (ic_version_id == 0x200000)
[...]
+ else {
[...]
CHECK:BRACES: Unbalanced braces around else statement
#982: FILE: drivers/net/r8169/r8169_hw.c:1445:
+ else {
total: 0 errors, 2 warnings, 30 checks, 989 lines checked
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-10-23 3:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20241023033328.191827-10-howard_wang@realsil.com.cn>
2024-10-23 3:38 ` |WARNING| pw146808 [PATCH v3 09/18] net/r8169: add support for hw initialization checkpatch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).