|WARNING| pw147169 [PATCH v4 05/18] net/r8169: add support for hw config

automatic DPDK test reports
 help / color / mirror / Atom feed

From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw147169 [PATCH v4 05/18] net/r8169: add support for hw config
Date: Fri, 25 Oct 2024 05:38:39 +0200 (CEST)	[thread overview]
Message-ID: <20241025033840.00D99123108@dpdk.org> (raw)
In-Reply-To: <20241025033529.15581-6-howard_wang@realsil.com.cn>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147169

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <InterFrameGap>
#237: FILE: drivers/net/r8169/r8169_base.h:510:
+#define InterFrameGap       0x03    /* 3 means InterFrameGap = the shortest one */

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#268: FILE: drivers/net/r8169/r8169_ethdev.h:20:
+	u8  HwSuppIntMitiVer;

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#271: FILE: drivers/net/r8169/r8169_ethdev.h:23:
+	u8 EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#274: FILE: drivers/net/r8169/r8169_ethdev.h:26:
+	u8 HwSuppDashVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#276: FILE: drivers/net/r8169/r8169_ethdev.h:28:
+	u8 HwSuppOcpChannelVer;

CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#277: FILE: drivers/net/r8169/r8169_ethdev.h:29:
+	u8 AllowAccessDashOcp;

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Addr_Align>
#304: FILE: drivers/net/r8169/r8169_hw.c:32:
+		val_shift = addr % ERIAR_Addr_Align;

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Read>
#307: FILE: drivers/net/r8169/r8169_hw.c:35:
+		eri_cmd = ERIAR_Read | transformed_base_address |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Type_shift>
#308: FILE: drivers/net/r8169/r8169_hw.c:36:
+			  type << ERIAR_Type_shift |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ByteEn>
#309: FILE: drivers/net/r8169/r8169_hw.c:37:
+			  ERIAR_ByteEn << ERIAR_ByteEn_shift |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ByteEn_shift>
#309: FILE: drivers/net/r8169/r8169_hw.c:37:
+			  ERIAR_ByteEn << ERIAR_ByteEn_shift |

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Flag>
#323: FILE: drivers/net/r8169/r8169_hw.c:51:
+			if (RTL_R32(hw, ERIAR) & ERIAR_Flag)

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_Write>
#385: FILE: drivers/net/r8169/r8169_hw.c:113:
+		eri_cmd = ERIAR_Write | transformed_base_address |

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#573: FILE: drivers/net/r8169/r8169_hw.c:371:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);

CHECK:CAMELCASE: Avoid CamelCase: <StopReq>
#573: FILE: drivers/net/r8169/r8169_hw.c:371:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#591: FILE: drivers/net/r8169/r8169_hw.c:389:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));

CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#591: FILE: drivers/net/r8169/r8169_hw.c:389:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));

CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#604: FILE: drivers/net/r8169/r8169_hw.c:402:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Txfifo_empty>
#604: FILE: drivers/net/r8169/r8169_hw.c:402:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Rxfifo_empty>
#604: FILE: drivers/net/r8169/r8169_hw.c:402:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <IntrMitigate>
#618: FILE: drivers/net/r8169/r8169_hw.c:416:
+			if ((RTL_R16(hw, IntrMitigate) & (BIT_0 | BIT_1 | BIT_8)) ==

CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#629: FILE: drivers/net/r8169/r8169_hw.c:427:
+	RTL_W32(hw, RxConfig, RTL_R32(hw, RxConfig) &

CHECK:CAMELCASE: Avoid CamelCase: <AcceptErr>
#630: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptRunt>
#630: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptBroadcast>
#630: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptMulticast>
#630: FILE: drivers/net/r8169/r8169_hw.c:428:
+		~(AcceptErr | AcceptRunt | AcceptBroadcast | AcceptMulticast |

CHECK:CAMELCASE: Avoid CamelCase: <AcceptMyPhys>
#631: FILE: drivers/net/r8169/r8169_hw.c:429:
+		AcceptMyPhys | AcceptAllPhys));

CHECK:CAMELCASE: Avoid CamelCase: <AcceptAllPhys>
#631: FILE: drivers/net/r8169/r8169_hw.c:429:
+		AcceptMyPhys | AcceptAllPhys));

CHECK:CAMELCASE: Avoid CamelCase: <CmdReset>
#650: FILE: drivers/net/r8169/r8169_hw.c:448:
+	RTL_W8(hw, ChipCmd, CmdReset);

CHECK:CAMELCASE: Avoid CamelCase: <Cfg9346>
#663: FILE: drivers/net/r8169/r8169_hw.c:461:
+	RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock);

CHECK:CAMELCASE: Avoid CamelCase: <Cfg9346_Unlock>
#663: FILE: drivers/net/r8169/r8169_hw.c:461:
+	RTL_W8(hw, Cfg9346, RTL_R8(hw, Cfg9346) | Cfg9346_Unlock);

CHECK:CAMELCASE: Avoid CamelCase: <Config2>
#689: FILE: drivers/net/r8169/r8169_hw.c:487:
+			RTL_W8(hw, Config2, RTL_R8(hw, Config2) | BIT_7);

CHECK:CAMELCASE: Avoid CamelCase: <Config5>
#690: FILE: drivers/net/r8169/r8169_hw.c:488:
+			RTL_W8(hw, Config5, RTL_R8(hw, Config5) | BIT_0);

CHECK:CAMELCASE: Avoid CamelCase: <RxCfgDMAShift>
#785: FILE: drivers/net/r8169/r8169_hw.c:583:
+	RTL_W32(hw, RxConfig, (RX_DMA_BURST_unlimited << RxCfgDMAShift));

CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#810: FILE: drivers/net/r8169/r8169_hw.c:608:
+	RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) |

CHECK:CAMELCASE: Avoid CamelCase: <TxDMAShift>
#810: FILE: drivers/net/r8169/r8169_hw.c:608:
+	RTL_W32(hw, TxConfig, (TX_DMA_BURST_unlimited << TxDMAShift) |

CHECK:CAMELCASE: Avoid CamelCase: <TxInterFrameGapShift>
#811: FILE: drivers/net/r8169/r8169_hw.c:609:
+		(InterFrameGap << TxInterFrameGapShift));

CHECK:CAMELCASE: Avoid CamelCase: <Config1>
#840: FILE: drivers/net/r8169/r8169_hw.c:638:
+		RTL_W8(hw, Config1, RTL_R8(hw, Config1) & ~0x10);

CHECK:CAMELCASE: Avoid CamelCase: <EnableRxDescV4_0>
#985: FILE: drivers/net/r8169/r8169_hw.c:783:
+			RTL_W8(hw, 0xd8, RTL_R8(hw, 0xd8) & ~EnableRxDescV4_0);

WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#1048: FILE: drivers/net/r8169/r8169_phy.c:2:
+ * Copyright(c) 2024 Realtek Corporation. All rights reserved */

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#1051: FILE: drivers/net/r8169/r8169_phy.c:5:
+#include <stdio.h>

total: 0 errors, 2 warnings, 39 checks, 986 lines checked

          parent reply	other threads:[~2024-10-25  3:38 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20241025033529.15581-6-howard_wang@realsil.com.cn>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025033840.00D99123108@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=howard_wang@realsil.com.cn \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).