automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw147177 [PATCH v4 13/18] net/r8169: implement device statistics
Date: Fri, 25 Oct 2024 05:40:57 +0200 (CEST)	[thread overview]
Message-ID: <20241025034057.7462C123108@dpdk.org> (raw)
In-Reply-To: <20241025033529.15581-14-howard_wang@realsil.com.cn>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147177

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:TYPO_SPELLING: 'underun' may be misspelled - perhaps 'underrun'?
#97: FILE: drivers/net/r8169/r8169_base.h:40:
+	u16 tx_underun;

CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrHigh>
#226: FILE: drivers/net/r8169/r8169_hw.c:1519:
+	RTL_W32(hw, CounterAddrHigh, (u64)paddr >> 32);

CHECK:CAMELCASE: Avoid CamelCase: <CounterAddrLow>
#228: FILE: drivers/net/r8169/r8169_hw.c:1521:
+	RTL_W32(hw, CounterAddrLow, cmd);

CHECK:CAMELCASE: Avoid CamelCase: <CounterDump>
#229: FILE: drivers/net/r8169/r8169_hw.c:1522:
+	RTL_W32(hw, CounterAddrLow, cmd | CounterDump);

CHECK:CAMELCASE: Avoid CamelCase: <CounterReset>
#259: FILE: drivers/net/r8169/r8169_hw.c:1552:
+		((u64)hw->tally_paddr & (DMA_BIT_MASK(32))) | CounterReset);

total: 0 errors, 2 warnings, 4 checks, 204 lines checked

           reply	other threads:[~2024-10-25  3:41 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20241025033529.15581-14-howard_wang@realsil.com.cn>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241025034057.7462C123108@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=howard_wang@realsil.com.cn \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).