From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id B3EC945BCF
	for <public@inbox.dpdk.org>; Fri, 25 Oct 2024 05:41:23 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id B027A4026B;
	Fri, 25 Oct 2024 05:41:23 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 3F9594025A
 for <test-report@dpdk.org>; Fri, 25 Oct 2024 05:41:07 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 37877123108; Fri, 25 Oct 2024 05:41:07 +0200 (CEST)
Subject: |WARNING| pw147176 [PATCH v4 12/18] net/r8169: implement Tx path
In-Reply-To: <20241025033529.15581-13-howard_wang@realsil.com.cn>
References: <20241025033529.15581-13-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241025034107.37877123108@dpdk.org>
Date: Fri, 25 Oct 2024 05:41:07 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147176

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <NextHwDesCloPtr0>
#108: FILE: drivers/net/r8169/r8169_ethdev.h:80:
+	u32 NextHwDesCloPtr0;

CHECK:CAMELCASE: Avoid CamelCase: <BeginHwDesCloPtr0>
#109: FILE: drivers/net/r8169/r8169_ethdev.h:81:
+	u32 BeginHwDesCloPtr0;

CHECK:SPACING: No space is necessary after a cast
#199: FILE: drivers/net/r8169/r8169_rxtx.c:79:
+	RTE_ATOMIC(uint32_t) tx_tail;

CHECK:CAMELCASE: Avoid CamelCase: <RingEnd>
#313: FILE: drivers/net/r8169/r8169_rxtx.c:901:
+	txq->hw_ring[txq->nb_tx_desc - 1].opts1 = rte_cpu_to_le_32(RingEnd);

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrLow>
#424: FILE: drivers/net/r8169/r8169_rxtx.c:1012:
+	RTL_W32(hw, TxDescStartAddrLow,

CHECK:CAMELCASE: Avoid CamelCase: <TxDescStartAddrHigh>
#426: FILE: drivers/net/r8169/r8169_rxtx.c:1014:
+	RTL_W32(hw, TxDescStartAddrHigh, ((u64)txq->hw_ring_phys_addr >> 32));

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#440: FILE: drivers/net/r8169/r8169_rxtx.c:1028:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#440: FILE: drivers/net/r8169/r8169_rxtx.c:1028:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdTxEnb);

CHECK:CAMELCASE: Avoid CamelCase: <TxVlanTag>
#453: FILE: drivers/net/r8169/r8169_rxtx.c:1039:
+	       (TxVlanTag | rte_bswap16(tx_pkt->vlan_tci)) :

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv4>
#470: FILE: drivers/net/r8169/r8169_rxtx.c:1056:
+				opts[0] |= GiantSendv4;

CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv6>
#472: FILE: drivers/net/r8169/r8169_rxtx.c:1058:
+				opts[0] |= GiantSendv6;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS_C>
#492: FILE: drivers/net/r8169/r8169_rxtx.c:1078:
+		csum_cmd |= TxIPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS_C>
#496: FILE: drivers/net/r8169/r8169_rxtx.c:1082:
+		csum_cmd |= TxUDPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS_C>
#499: FILE: drivers/net/r8169/r8169_rxtx.c:1085:
+		csum_cmd |= TxTCPCS_C;

CHECK:CAMELCASE: Avoid CamelCase: <TxIPV6F_C>
#506: FILE: drivers/net/r8169/r8169_rxtx.c:1092:
+			csum_cmd |= TxIPV6F_C;

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'tx_pkt->data_len < 175'
#524: FILE: drivers/net/r8169/r8169_rxtx.c:1110:
+	if (!(tx_pkt->l4_len && (tx_pkt->data_len < 175)))

CHECK:CAMELCASE: Avoid CamelCase: <DescOwn>
#599: FILE: drivers/net/r8169/r8169_rxtx.c:1185:
+	opts[0] = DescOwn;

CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag>
#631: FILE: drivers/net/r8169/r8169_rxtx.c:1217:
+			opts1 |= FirstFrag;

CHECK:CAMELCASE: Avoid CamelCase: <LastFrag>
#633: FILE: drivers/net/r8169/r8169_rxtx.c:1219:
+			opts1 |= LastFrag;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#671: FILE: drivers/net/r8169/r8169_rxtx.c:1257:
+	switch (hw->HwSuppTxNoCloseVer) {

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#697: FILE: drivers/net/r8169/r8169_rxtx.c:1283:
+	const uint8_t enable_tx_no_close = hw->EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#711: FILE: drivers/net/r8169/r8169_rxtx.c:1297:
+						   hw->BeginHwDesCloPtr0, hw->MaxTxDescPtrMask);

WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using 'rtl_xmit_pkts', this function's name, in a string
#854: FILE: drivers/net/r8169/r8169_rxtx.c:1440:
+	PMD_TX_LOG(DEBUG, "rtl_xmit_pkts %d transmitted", nb_tx);

total: 0 errors, 1 warnings, 22 checks, 791 lines checked
Warning in drivers/net/r8169/r8169_rxtx.c:
Using rte_smp_[r/w]mb