From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw147175 [PATCH v4 11/18] net/r8169: implement Rx path
Date: Fri, 25 Oct 2024 05:41:19 +0200 (CEST) [thread overview]
Message-ID: <20241025034119.391EA123108@dpdk.org> (raw)
In-Reply-To: <20241025033529.15581-12-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147175
_coding style issues_
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects?
#107: FILE: drivers/net/r8169/r8169_base.h:581:
+#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL << (n)) - 1))
CHECK:CAMELCASE: Avoid CamelCase: <_DescStatusBit>
#331: FILE: drivers/net/r8169/r8169_rxtx.c:62:
+enum _DescStatusBit {
CHECK:CAMELCASE: Avoid CamelCase: <DescOwn>
#332: FILE: drivers/net/r8169/r8169_rxtx.c:63:
+ DescOwn = (1 << 31), /* Descriptor is owned by NIC. */
CHECK:CAMELCASE: Avoid CamelCase: <RingEnd>
#333: FILE: drivers/net/r8169/r8169_rxtx.c:64:
+ RingEnd = (1 << 30), /* End of descriptor ring */
CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag>
#334: FILE: drivers/net/r8169/r8169_rxtx.c:65:
+ FirstFrag = (1 << 29), /* First segment of a packet */
CHECK:CAMELCASE: Avoid CamelCase: <LastFrag>
#335: FILE: drivers/net/r8169/r8169_rxtx.c:66:
+ LastFrag = (1 << 28), /* Final segment of a packet */
CHECK:CAMELCASE: Avoid CamelCase: <DescOwn_V3>
#337: FILE: drivers/net/r8169/r8169_rxtx.c:68:
+ DescOwn_V3 = DescOwn, /* Descriptor is owned by NIC. */
CHECK:CAMELCASE: Avoid CamelCase: <RingEnd_V3>
#338: FILE: drivers/net/r8169/r8169_rxtx.c:69:
+ RingEnd_V3 = RingEnd, /* End of descriptor ring */
CHECK:CAMELCASE: Avoid CamelCase: <FirstFrag_V3>
#339: FILE: drivers/net/r8169/r8169_rxtx.c:70:
+ FirstFrag_V3 = (1 << 25), /* First segment of a packet */
CHECK:CAMELCASE: Avoid CamelCase: <LastFrag_V3>
#340: FILE: drivers/net/r8169/r8169_rxtx.c:71:
+ LastFrag_V3 = (1 << 24), /* Final segment of a packet */
CHECK:CAMELCASE: Avoid CamelCase: <LargeSend>
#344: FILE: drivers/net/r8169/r8169_rxtx.c:75:
+ LargeSend = (1 << 27), /* TCP Large Send Offload (TSO) */
CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv4>
#345: FILE: drivers/net/r8169/r8169_rxtx.c:76:
+ GiantSendv4 = (1 << 26), /* TCP Giant Send Offload V4 (GSOv4) */
CHECK:CAMELCASE: Avoid CamelCase: <GiantSendv6>
#346: FILE: drivers/net/r8169/r8169_rxtx.c:77:
+ GiantSendv6 = (1 << 25), /* TCP Giant Send Offload V6 (GSOv6) */
CHECK:CAMELCASE: Avoid CamelCase: <LargeSend_DP>
#347: FILE: drivers/net/r8169/r8169_rxtx.c:78:
+ LargeSend_DP = (1 << 16), /* TCP Large Send Offload (TSO) */
CHECK:CAMELCASE: Avoid CamelCase: <MSSShift>
#348: FILE: drivers/net/r8169/r8169_rxtx.c:79:
+ MSSShift = 16, /* MSS value position */
CHECK:CAMELCASE: Avoid CamelCase: <MSSMask>
#349: FILE: drivers/net/r8169/r8169_rxtx.c:80:
+ MSSMask = 0x7FFU, /* MSS value 11 bits */
CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS>
#350: FILE: drivers/net/r8169/r8169_rxtx.c:81:
+ TxIPCS = (1 << 18), /* Calculate IP checksum */
CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS>
#351: FILE: drivers/net/r8169/r8169_rxtx.c:82:
+ TxUDPCS = (1 << 17), /* Calculate UDP/IP checksum */
CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS>
#352: FILE: drivers/net/r8169/r8169_rxtx.c:83:
+ TxTCPCS = (1 << 16), /* Calculate TCP/IP checksum */
CHECK:CAMELCASE: Avoid CamelCase: <TxVlanTag>
#353: FILE: drivers/net/r8169/r8169_rxtx.c:84:
+ TxVlanTag = (1 << 17), /* Add VLAN tag */
CHECK:CAMELCASE: Avoid CamelCase: <TxUDPCS_C>
#356: FILE: drivers/net/r8169/r8169_rxtx.c:87:
+ TxUDPCS_C = (1 << 31), /* Calculate UDP/IP checksum */
CHECK:CAMELCASE: Avoid CamelCase: <TxTCPCS_C>
#357: FILE: drivers/net/r8169/r8169_rxtx.c:88:
+ TxTCPCS_C = (1 << 30), /* Calculate TCP/IP checksum */
CHECK:CAMELCASE: Avoid CamelCase: <TxIPCS_C>
#358: FILE: drivers/net/r8169/r8169_rxtx.c:89:
+ TxIPCS_C = (1 << 29), /* Calculate IP checksum */
CHECK:CAMELCASE: Avoid CamelCase: <TxIPV6F_C>
#359: FILE: drivers/net/r8169/r8169_rxtx.c:90:
+ TxIPV6F_C = (1 << 28), /* Indicate it is an IPv6 packet */
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoUDP>
#367: FILE: drivers/net/r8169/r8169_rxtx.c:98:
+#define RxProtoUDP PID1
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoTCP>
#368: FILE: drivers/net/r8169/r8169_rxtx.c:99:
+#define RxProtoTCP PID0
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoIP>
#369: FILE: drivers/net/r8169/r8169_rxtx.c:100:
+#define RxProtoIP (PID1 | PID0)
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoMask>
#370: FILE: drivers/net/r8169/r8169_rxtx.c:101:
+#define RxProtoMask RxProtoIP
CHECK:CAMELCASE: Avoid CamelCase: <RxIPF>
#372: FILE: drivers/net/r8169/r8169_rxtx.c:103:
+ RxIPF = (1 << 16), /* IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxUDPF>
#373: FILE: drivers/net/r8169/r8169_rxtx.c:104:
+ RxUDPF = (1 << 15), /* UDP/IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxTCPF>
#374: FILE: drivers/net/r8169/r8169_rxtx.c:105:
+ RxTCPF = (1 << 14), /* TCP/IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxVlanTag>
#375: FILE: drivers/net/r8169/r8169_rxtx.c:106:
+ RxVlanTag = (1 << 16), /* VLAN tag available */
CHECK:CAMELCASE: Avoid CamelCase: <RxUDPT>
#378: FILE: drivers/net/r8169/r8169_rxtx.c:109:
+ RxUDPT = (1 << 18),
CHECK:CAMELCASE: Avoid CamelCase: <RxTCPT>
#379: FILE: drivers/net/r8169/r8169_rxtx.c:110:
+ RxTCPT = (1 << 17),
CHECK:CAMELCASE: Avoid CamelCase: <RxV6F>
#383: FILE: drivers/net/r8169/r8169_rxtx.c:114:
+ RxV6F = (1 << 31),
CHECK:CAMELCASE: Avoid CamelCase: <RxV4F>
#384: FILE: drivers/net/r8169/r8169_rxtx.c:115:
+ RxV4F = (1 << 30),
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoUDP_v3>
#390: FILE: drivers/net/r8169/r8169_rxtx.c:121:
+#define RxProtoUDP_v3 PID1_v3
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoTCP_v3>
#391: FILE: drivers/net/r8169/r8169_rxtx.c:122:
+#define RxProtoTCP_v3 PID0_v3
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoIP_v3>
#392: FILE: drivers/net/r8169/r8169_rxtx.c:123:
+#define RxProtoIP_v3 (PID1_v3 | PID0_v3)
CHECK:CAMELCASE: Avoid CamelCase: <RxProtoMask_v3>
#393: FILE: drivers/net/r8169/r8169_rxtx.c:124:
+#define RxProtoMask_v3 RxProtoIP_v3
CHECK:CAMELCASE: Avoid CamelCase: <RxIPF_v3>
#395: FILE: drivers/net/r8169/r8169_rxtx.c:126:
+ RxIPF_v3 = (1 << 26), /* IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxUDPF_v3>
#396: FILE: drivers/net/r8169/r8169_rxtx.c:127:
+ RxUDPF_v3 = (1 << 25), /* UDP/IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxTCPF_v3>
#397: FILE: drivers/net/r8169/r8169_rxtx.c:128:
+ RxTCPF_v3 = (1 << 24), /* TCP/IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxSCTPF_v3>
#398: FILE: drivers/net/r8169/r8169_rxtx.c:129:
+ RxSCTPF_v3 = (1 << 23), /* TCP/IP checksum failed */
CHECK:CAMELCASE: Avoid CamelCase: <RxVlanTag_v3>
#399: FILE: drivers/net/r8169/r8169_rxtx.c:130:
+ RxVlanTag_v3 = (RxVlanTag), /* VLAN tag available */
CHECK:CAMELCASE: Avoid CamelCase: <RxUDPT_v3>
#402: FILE: drivers/net/r8169/r8169_rxtx.c:133:
+ RxUDPT_v3 = (1 << 29),
CHECK:CAMELCASE: Avoid CamelCase: <RxTCPT_v3>
#403: FILE: drivers/net/r8169/r8169_rxtx.c:134:
+ RxTCPT_v3 = (1 << 28),
CHECK:CAMELCASE: Avoid CamelCase: <RxSCTP_v3>
#404: FILE: drivers/net/r8169/r8169_rxtx.c:135:
+ RxSCTP_v3 = (1 << 27),
CHECK:CAMELCASE: Avoid CamelCase: <RxV6F_v3>
#408: FILE: drivers/net/r8169/r8169_rxtx.c:139:
+ RxV6F_v3 = RxV6F,
CHECK:CAMELCASE: Avoid CamelCase: <RxV4F_v3>
#409: FILE: drivers/net/r8169/r8169_rxtx.c:140:
+ RxV4F_v3 = RxV4F,
CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#615: FILE: drivers/net/r8169/r8169_rxtx.c:346:
+ rx_config = RTL_R32(hw, RxConfig);
CHECK:CAMELCASE: Avoid CamelCase: <EnableInnerVlan>
#617: FILE: drivers/net/r8169/r8169_rxtx.c:348:
+ rx_config |= (EnableInnerVlan | EnableOuterVlan);
CHECK:CAMELCASE: Avoid CamelCase: <EnableOuterVlan>
#617: FILE: drivers/net/r8169/r8169_rxtx.c:348:
+ rx_config |= (EnableInnerVlan | EnableOuterVlan);
CHECK:CAMELCASE: Avoid CamelCase: <CPlusCmd>
#623: FILE: drivers/net/r8169/r8169_rxtx.c:354:
+ cp_cmd = RTL_R16(hw, CPlusCmd);
CHECK:CAMELCASE: Avoid CamelCase: <RxChkSum>
#626: FILE: drivers/net/r8169/r8169_rxtx.c:357:
+ cp_cmd |= RxChkSum;
CHECK:CAMELCASE: Avoid CamelCase: <AcceptBroadcast>
#642: FILE: drivers/net/r8169/r8169_rxtx.c:373:
+ rx_mode = AcceptBroadcast | AcceptMyPhys;
CHECK:CAMELCASE: Avoid CamelCase: <AcceptMyPhys>
#642: FILE: drivers/net/r8169/r8169_rxtx.c:373:
+ rx_mode = AcceptBroadcast | AcceptMyPhys;
CHECK:CAMELCASE: Avoid CamelCase: <RxDescAddrLow>
#662: FILE: drivers/net/r8169/r8169_rxtx.c:393:
+ RTL_W32(hw, RxDescAddrLow, ((u64)rxq->hw_ring_phys_addr & DMA_BIT_MASK(32)));
CHECK:CAMELCASE: Avoid CamelCase: <RxDescAddrHigh>
#663: FILE: drivers/net/r8169/r8169_rxtx.c:394:
+ RTL_W32(hw, RxDescAddrHigh, ((u64)rxq->hw_ring_phys_addr >> 32));
CHECK:CAMELCASE: Avoid CamelCase: <RxMaxSize>
#678: FILE: drivers/net/r8169/r8169_rxtx.c:409:
+ RTL_W16(hw, RxMaxSize, max_rx_pkt_size);
CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#698: FILE: drivers/net/r8169/r8169_rxtx.c:429:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb);
CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#698: FILE: drivers/net/r8169/r8169_rxtx.c:429:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb);
CHECK:CAMELCASE: Avoid CamelCase: <RxRES>
#778: FILE: drivers/net/r8169/r8169_rxtx.c:507:
+ if (unlikely(opts1 & RxRES)) {
CHECK:CAMELCASE: Avoid CamelCase: <RxOK>
#859: FILE: drivers/net/r8169/r8169_rxtx.c:588:
+ RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail));
CHECK:CAMELCASE: Avoid CamelCase: <RxErr>
#859: FILE: drivers/net/r8169/r8169_rxtx.c:588:
+ RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail));
CHECK:CAMELCASE: Avoid CamelCase: <RxDescUnavail>
#859: FILE: drivers/net/r8169/r8169_rxtx.c:588:
+ RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail));
total: 0 errors, 0 warnings, 66 checks, 991 lines checked
parent reply other threads:[~2024-10-25 3:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241025033529.15581-12-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025034119.391EA123108@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).