From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C7E3B45BCF for ; Fri, 25 Oct 2024 05:41:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF108435B2; Fri, 25 Oct 2024 05:41:23 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 45F954025A for ; Fri, 25 Oct 2024 05:41:19 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id 391EA123108; Fri, 25 Oct 2024 05:41:19 +0200 (CEST) Subject: |WARNING| pw147175 [PATCH v4 11/18] net/r8169: implement Rx path In-Reply-To: <20241025033529.15581-12-howard_wang@realsil.com.cn> References: <20241025033529.15581-12-howard_wang@realsil.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Howard Wang Message-Id: <20241025034119.391EA123108@dpdk.org> Date: Fri, 25 Oct 2024 05:41:19 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/147175 _coding style issues_ CHECK:MACRO_ARG_REUSE: Macro argument reuse 'n' - possible side-effects? #107: FILE: drivers/net/r8169/r8169_base.h:581: +#define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL << (n)) - 1)) CHECK:CAMELCASE: Avoid CamelCase: <_DescStatusBit> #331: FILE: drivers/net/r8169/r8169_rxtx.c:62: +enum _DescStatusBit { CHECK:CAMELCASE: Avoid CamelCase: #332: FILE: drivers/net/r8169/r8169_rxtx.c:63: + DescOwn = (1 << 31), /* Descriptor is owned by NIC. */ CHECK:CAMELCASE: Avoid CamelCase: #333: FILE: drivers/net/r8169/r8169_rxtx.c:64: + RingEnd = (1 << 30), /* End of descriptor ring */ CHECK:CAMELCASE: Avoid CamelCase: #334: FILE: drivers/net/r8169/r8169_rxtx.c:65: + FirstFrag = (1 << 29), /* First segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #335: FILE: drivers/net/r8169/r8169_rxtx.c:66: + LastFrag = (1 << 28), /* Final segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #337: FILE: drivers/net/r8169/r8169_rxtx.c:68: + DescOwn_V3 = DescOwn, /* Descriptor is owned by NIC. */ CHECK:CAMELCASE: Avoid CamelCase: #338: FILE: drivers/net/r8169/r8169_rxtx.c:69: + RingEnd_V3 = RingEnd, /* End of descriptor ring */ CHECK:CAMELCASE: Avoid CamelCase: #339: FILE: drivers/net/r8169/r8169_rxtx.c:70: + FirstFrag_V3 = (1 << 25), /* First segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #340: FILE: drivers/net/r8169/r8169_rxtx.c:71: + LastFrag_V3 = (1 << 24), /* Final segment of a packet */ CHECK:CAMELCASE: Avoid CamelCase: #344: FILE: drivers/net/r8169/r8169_rxtx.c:75: + LargeSend = (1 << 27), /* TCP Large Send Offload (TSO) */ CHECK:CAMELCASE: Avoid CamelCase: #345: FILE: drivers/net/r8169/r8169_rxtx.c:76: + GiantSendv4 = (1 << 26), /* TCP Giant Send Offload V4 (GSOv4) */ CHECK:CAMELCASE: Avoid CamelCase: #346: FILE: drivers/net/r8169/r8169_rxtx.c:77: + GiantSendv6 = (1 << 25), /* TCP Giant Send Offload V6 (GSOv6) */ CHECK:CAMELCASE: Avoid CamelCase: #347: FILE: drivers/net/r8169/r8169_rxtx.c:78: + LargeSend_DP = (1 << 16), /* TCP Large Send Offload (TSO) */ CHECK:CAMELCASE: Avoid CamelCase: #348: FILE: drivers/net/r8169/r8169_rxtx.c:79: + MSSShift = 16, /* MSS value position */ CHECK:CAMELCASE: Avoid CamelCase: #349: FILE: drivers/net/r8169/r8169_rxtx.c:80: + MSSMask = 0x7FFU, /* MSS value 11 bits */ CHECK:CAMELCASE: Avoid CamelCase: #350: FILE: drivers/net/r8169/r8169_rxtx.c:81: + TxIPCS = (1 << 18), /* Calculate IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #351: FILE: drivers/net/r8169/r8169_rxtx.c:82: + TxUDPCS = (1 << 17), /* Calculate UDP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #352: FILE: drivers/net/r8169/r8169_rxtx.c:83: + TxTCPCS = (1 << 16), /* Calculate TCP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #353: FILE: drivers/net/r8169/r8169_rxtx.c:84: + TxVlanTag = (1 << 17), /* Add VLAN tag */ CHECK:CAMELCASE: Avoid CamelCase: #356: FILE: drivers/net/r8169/r8169_rxtx.c:87: + TxUDPCS_C = (1 << 31), /* Calculate UDP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #357: FILE: drivers/net/r8169/r8169_rxtx.c:88: + TxTCPCS_C = (1 << 30), /* Calculate TCP/IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #358: FILE: drivers/net/r8169/r8169_rxtx.c:89: + TxIPCS_C = (1 << 29), /* Calculate IP checksum */ CHECK:CAMELCASE: Avoid CamelCase: #359: FILE: drivers/net/r8169/r8169_rxtx.c:90: + TxIPV6F_C = (1 << 28), /* Indicate it is an IPv6 packet */ CHECK:CAMELCASE: Avoid CamelCase: #367: FILE: drivers/net/r8169/r8169_rxtx.c:98: +#define RxProtoUDP PID1 CHECK:CAMELCASE: Avoid CamelCase: #368: FILE: drivers/net/r8169/r8169_rxtx.c:99: +#define RxProtoTCP PID0 CHECK:CAMELCASE: Avoid CamelCase: #369: FILE: drivers/net/r8169/r8169_rxtx.c:100: +#define RxProtoIP (PID1 | PID0) CHECK:CAMELCASE: Avoid CamelCase: #370: FILE: drivers/net/r8169/r8169_rxtx.c:101: +#define RxProtoMask RxProtoIP CHECK:CAMELCASE: Avoid CamelCase: #372: FILE: drivers/net/r8169/r8169_rxtx.c:103: + RxIPF = (1 << 16), /* IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #373: FILE: drivers/net/r8169/r8169_rxtx.c:104: + RxUDPF = (1 << 15), /* UDP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #374: FILE: drivers/net/r8169/r8169_rxtx.c:105: + RxTCPF = (1 << 14), /* TCP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #375: FILE: drivers/net/r8169/r8169_rxtx.c:106: + RxVlanTag = (1 << 16), /* VLAN tag available */ CHECK:CAMELCASE: Avoid CamelCase: #378: FILE: drivers/net/r8169/r8169_rxtx.c:109: + RxUDPT = (1 << 18), CHECK:CAMELCASE: Avoid CamelCase: #379: FILE: drivers/net/r8169/r8169_rxtx.c:110: + RxTCPT = (1 << 17), CHECK:CAMELCASE: Avoid CamelCase: #383: FILE: drivers/net/r8169/r8169_rxtx.c:114: + RxV6F = (1 << 31), CHECK:CAMELCASE: Avoid CamelCase: #384: FILE: drivers/net/r8169/r8169_rxtx.c:115: + RxV4F = (1 << 30), CHECK:CAMELCASE: Avoid CamelCase: #390: FILE: drivers/net/r8169/r8169_rxtx.c:121: +#define RxProtoUDP_v3 PID1_v3 CHECK:CAMELCASE: Avoid CamelCase: #391: FILE: drivers/net/r8169/r8169_rxtx.c:122: +#define RxProtoTCP_v3 PID0_v3 CHECK:CAMELCASE: Avoid CamelCase: #392: FILE: drivers/net/r8169/r8169_rxtx.c:123: +#define RxProtoIP_v3 (PID1_v3 | PID0_v3) CHECK:CAMELCASE: Avoid CamelCase: #393: FILE: drivers/net/r8169/r8169_rxtx.c:124: +#define RxProtoMask_v3 RxProtoIP_v3 CHECK:CAMELCASE: Avoid CamelCase: #395: FILE: drivers/net/r8169/r8169_rxtx.c:126: + RxIPF_v3 = (1 << 26), /* IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #396: FILE: drivers/net/r8169/r8169_rxtx.c:127: + RxUDPF_v3 = (1 << 25), /* UDP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #397: FILE: drivers/net/r8169/r8169_rxtx.c:128: + RxTCPF_v3 = (1 << 24), /* TCP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #398: FILE: drivers/net/r8169/r8169_rxtx.c:129: + RxSCTPF_v3 = (1 << 23), /* TCP/IP checksum failed */ CHECK:CAMELCASE: Avoid CamelCase: #399: FILE: drivers/net/r8169/r8169_rxtx.c:130: + RxVlanTag_v3 = (RxVlanTag), /* VLAN tag available */ CHECK:CAMELCASE: Avoid CamelCase: #402: FILE: drivers/net/r8169/r8169_rxtx.c:133: + RxUDPT_v3 = (1 << 29), CHECK:CAMELCASE: Avoid CamelCase: #403: FILE: drivers/net/r8169/r8169_rxtx.c:134: + RxTCPT_v3 = (1 << 28), CHECK:CAMELCASE: Avoid CamelCase: #404: FILE: drivers/net/r8169/r8169_rxtx.c:135: + RxSCTP_v3 = (1 << 27), CHECK:CAMELCASE: Avoid CamelCase: #408: FILE: drivers/net/r8169/r8169_rxtx.c:139: + RxV6F_v3 = RxV6F, CHECK:CAMELCASE: Avoid CamelCase: #409: FILE: drivers/net/r8169/r8169_rxtx.c:140: + RxV4F_v3 = RxV4F, CHECK:CAMELCASE: Avoid CamelCase: #615: FILE: drivers/net/r8169/r8169_rxtx.c:346: + rx_config = RTL_R32(hw, RxConfig); CHECK:CAMELCASE: Avoid CamelCase: #617: FILE: drivers/net/r8169/r8169_rxtx.c:348: + rx_config |= (EnableInnerVlan | EnableOuterVlan); CHECK:CAMELCASE: Avoid CamelCase: #617: FILE: drivers/net/r8169/r8169_rxtx.c:348: + rx_config |= (EnableInnerVlan | EnableOuterVlan); CHECK:CAMELCASE: Avoid CamelCase: #623: FILE: drivers/net/r8169/r8169_rxtx.c:354: + cp_cmd = RTL_R16(hw, CPlusCmd); CHECK:CAMELCASE: Avoid CamelCase: #626: FILE: drivers/net/r8169/r8169_rxtx.c:357: + cp_cmd |= RxChkSum; CHECK:CAMELCASE: Avoid CamelCase: #642: FILE: drivers/net/r8169/r8169_rxtx.c:373: + rx_mode = AcceptBroadcast | AcceptMyPhys; CHECK:CAMELCASE: Avoid CamelCase: #642: FILE: drivers/net/r8169/r8169_rxtx.c:373: + rx_mode = AcceptBroadcast | AcceptMyPhys; CHECK:CAMELCASE: Avoid CamelCase: #662: FILE: drivers/net/r8169/r8169_rxtx.c:393: + RTL_W32(hw, RxDescAddrLow, ((u64)rxq->hw_ring_phys_addr & DMA_BIT_MASK(32))); CHECK:CAMELCASE: Avoid CamelCase: #663: FILE: drivers/net/r8169/r8169_rxtx.c:394: + RTL_W32(hw, RxDescAddrHigh, ((u64)rxq->hw_ring_phys_addr >> 32)); CHECK:CAMELCASE: Avoid CamelCase: #678: FILE: drivers/net/r8169/r8169_rxtx.c:409: + RTL_W16(hw, RxMaxSize, max_rx_pkt_size); CHECK:CAMELCASE: Avoid CamelCase: #698: FILE: drivers/net/r8169/r8169_rxtx.c:429: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb); CHECK:CAMELCASE: Avoid CamelCase: #698: FILE: drivers/net/r8169/r8169_rxtx.c:429: + RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | CmdRxEnb); CHECK:CAMELCASE: Avoid CamelCase: #778: FILE: drivers/net/r8169/r8169_rxtx.c:507: + if (unlikely(opts1 & RxRES)) { CHECK:CAMELCASE: Avoid CamelCase: #859: FILE: drivers/net/r8169/r8169_rxtx.c:588: + RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail)); CHECK:CAMELCASE: Avoid CamelCase: #859: FILE: drivers/net/r8169/r8169_rxtx.c:588: + RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail)); CHECK:CAMELCASE: Avoid CamelCase: #859: FILE: drivers/net/r8169/r8169_rxtx.c:588: + RTL_W32(hw, ISR0_8125, (RxOK | RxErr | RxDescUnavail)); total: 0 errors, 0 warnings, 66 checks, 991 lines checked