From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw147173 [PATCH v4 09/18] net/r8169: add support for hw initialization
Date: Fri, 25 Oct 2024 05:41:37 +0200 (CEST) [thread overview]
Message-ID: <20241025034137.56338123108@dpdk.org> (raw)
In-Reply-To: <20241025033529.15581-10-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147173
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#173: FILE: drivers/net/r8169/r8169_dash.c:6:
+#include <stdio.h>
CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#232: FILE: drivers/net/r8169/r8169_dash.c:65:
+ if (!hw->AllowAccessDashOcp)
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#278: FILE: drivers/net/r8169/r8169_dash.h:17:
+#define HW_DASH_SUPPORT_DASH(_M) ((_M)->HwSuppDashVer > 0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#284: FILE: drivers/net/r8169/r8169_dash.h:23:
+#define HW_DASH_SUPPORT_GET_FIRMWARE_VERSION(_M) (HW_DASH_SUPPORT_TYPE_2(_M) || \
+ HW_DASH_SUPPORT_TYPE_3(_M) || \
+ HW_DASH_SUPPORT_TYPE_4(_M))
CHECK:CAMELCASE: Avoid CamelCase: <HwIcVerUnknown>
#410: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+ u8 HwIcVerUnknown;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppNowIsOobVer>
#431: FILE: drivers/net/r8169/r8169_ethdev.h:69:
+ u8 HwSuppNowIsOobVer;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#437: FILE: drivers/net/r8169/r8169_ethdev.h:74:
+ u8 HwSuppTxNoCloseVer;
CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#438: FILE: drivers/net/r8169/r8169_ethdev.h:75:
+ u8 EnableTxNoClose;
CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#441: FILE: drivers/net/r8169/r8169_ethdev.h:78:
+ u32 MaxTxDescPtrMask;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#516: FILE: drivers/net/r8169/r8169_hw.c:978:
+ speed = RTE_MIN(speed, hw->HwSuppMaxPhyLinkSpeed);
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#569: FILE: drivers/net/r8169/r8169_hw.c:1031:
+ hw->HwSuppOcpChannelVer = 2;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#625: FILE: drivers/net/r8169/r8169_hw.c:1087:
+ hw->HwSuppCheckPhyDisableModeVer = 3;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#731: FILE: drivers/net/r8169/r8169_hw.c:1193:
+ hw->NotWrRamCodeToMicroP = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrMcuPatchCode>
#732: FILE: drivers/net/r8169/r8169_hw.c:1194:
+ hw->NotWrMcuPatchCode = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMacMcuVer>
#738: FILE: drivers/net/r8169/r8169_hw.c:1200:
+ hw->HwSuppMacMcuVer = 2;
CHECK:CAMELCASE: Avoid CamelCase: <MacMcuPageSize>
#745: FILE: drivers/net/r8169/r8169_hw.c:1207:
+ hw->MacMcuPageSize = RTL_MAC_MCU_PAGE_SIZE;
CHECK:CAMELCASE: Avoid CamelCase: <RequirePhyMdiSwapPatch>
#754: FILE: drivers/net/r8169/r8169_hw.c:1216:
+ hw->RequirePhyMdiSwapPatch = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#762: FILE: drivers/net/r8169/r8169_hw.c:1224:
+ hw->HwSuppIntMitiVer = 3;
CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#807: FILE: drivers/net/r8169/r8169_hw.c:1269:
+ RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);
CHECK:CAMELCASE: Avoid CamelCase: <Now_is_oob>
#807: FILE: drivers/net/r8169/r8169_hw.c:1269:
+ RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);
CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#918: FILE: drivers/net/r8169/r8169_hw.c:1380:
+ val32 = RTL_R32(hw, TxConfig);
total: 0 errors, 2 warnings, 20 checks, 986 lines checked
parent reply other threads:[~2024-10-25 3:41 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241025033529.15581-10-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241025034137.56338123108@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).