From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id F22CE45BA1
	for <public@inbox.dpdk.org>; Mon, 28 Oct 2024 08:34:08 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id DD36240DD1;
	Mon, 28 Oct 2024 08:34:08 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 0CFCA40B91
 for <test-report@dpdk.org>; Mon, 28 Oct 2024 08:34:08 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id D9F8912314E; Mon, 28 Oct 2024 08:34:07 +0100 (CET)
Subject: |WARNING| pw147469 [PATCH v5 09/18] net/r8169: add support for hw
 initialization
In-Reply-To: <20241028073112.107535-10-howard_wang@realsil.com.cn>
References: <20241028073112.107535-10-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241028073407.D9F8912314E@dpdk.org>
Date: Mon, 28 Oct 2024 08:34:07 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147469

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#176: FILE: drivers/net/r8169/r8169_dash.c:6:
+#include <stdio.h>

CHECK:CAMELCASE: Avoid CamelCase: <AllowAccessDashOcp>
#235: FILE: drivers/net/r8169/r8169_dash.c:65:
+	if (!hw->AllowAccessDashOcp)

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppDashVer>
#281: FILE: drivers/net/r8169/r8169_dash.h:17:
+#define HW_DASH_SUPPORT_DASH(_M)        ((_M)->HwSuppDashVer > 0)

CHECK:MACRO_ARG_REUSE: Macro argument reuse '_M' - possible side-effects?
#287: FILE: drivers/net/r8169/r8169_dash.h:23:
+#define HW_DASH_SUPPORT_GET_FIRMWARE_VERSION(_M) (HW_DASH_SUPPORT_TYPE_2(_M) || \
+						  HW_DASH_SUPPORT_TYPE_3(_M) || \
+						  HW_DASH_SUPPORT_TYPE_4(_M))

CHECK:CAMELCASE: Avoid CamelCase: <HwIcVerUnknown>
#413: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+	u8  HwIcVerUnknown;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppNowIsOobVer>
#434: FILE: drivers/net/r8169/r8169_ethdev.h:69:
+	u8  HwSuppNowIsOobVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppTxNoCloseVer>
#440: FILE: drivers/net/r8169/r8169_ethdev.h:74:
+	u8  HwSuppTxNoCloseVer;

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#441: FILE: drivers/net/r8169/r8169_ethdev.h:75:
+	u8  EnableTxNoClose;

CHECK:CAMELCASE: Avoid CamelCase: <MaxTxDescPtrMask>
#444: FILE: drivers/net/r8169/r8169_ethdev.h:78:
+	u32 MaxTxDescPtrMask;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#519: FILE: drivers/net/r8169/r8169_hw.c:978:
+	speed = RTE_MIN(speed, hw->HwSuppMaxPhyLinkSpeed);

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppOcpChannelVer>
#572: FILE: drivers/net/r8169/r8169_hw.c:1031:
+			hw->HwSuppOcpChannelVer = 2;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#628: FILE: drivers/net/r8169/r8169_hw.c:1087:
+		hw->HwSuppCheckPhyDisableModeVer = 3;

CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#734: FILE: drivers/net/r8169/r8169_hw.c:1193:
+		hw->NotWrRamCodeToMicroP = TRUE;

CHECK:CAMELCASE: Avoid CamelCase: <NotWrMcuPatchCode>
#735: FILE: drivers/net/r8169/r8169_hw.c:1194:
+		hw->NotWrMcuPatchCode = TRUE;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMacMcuVer>
#741: FILE: drivers/net/r8169/r8169_hw.c:1200:
+		hw->HwSuppMacMcuVer = 2;

CHECK:CAMELCASE: Avoid CamelCase: <MacMcuPageSize>
#748: FILE: drivers/net/r8169/r8169_hw.c:1207:
+		hw->MacMcuPageSize = RTL_MAC_MCU_PAGE_SIZE;

CHECK:CAMELCASE: Avoid CamelCase: <RequirePhyMdiSwapPatch>
#757: FILE: drivers/net/r8169/r8169_hw.c:1216:
+			hw->RequirePhyMdiSwapPatch = TRUE;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppIntMitiVer>
#765: FILE: drivers/net/r8169/r8169_hw.c:1224:
+		hw->HwSuppIntMitiVer = 3;

CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#810: FILE: drivers/net/r8169/r8169_hw.c:1269:
+		RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);

CHECK:CAMELCASE: Avoid CamelCase: <Now_is_oob>
#810: FILE: drivers/net/r8169/r8169_hw.c:1269:
+		RTL_W8(hw, MCUCmd_reg, RTL_R8(hw, MCUCmd_reg) & ~Now_is_oob);

CHECK:CAMELCASE: Avoid CamelCase: <TxConfig>
#921: FILE: drivers/net/r8169/r8169_hw.c:1380:
+	val32 = RTL_R32(hw, TxConfig);

total: 0 errors, 2 warnings, 20 checks, 986 lines checked