From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw147468 [PATCH v5 08/18] net/r8169: add support for phy configuration
Date: Mon, 28 Oct 2024 08:34:16 +0100 (CET) [thread overview]
Message-ID: <20241028073416.973BB12314E@dpdk.org> (raw)
In-Reply-To: <20241028073112.107535-9-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147468
_coding style issues_
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#123: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+ u8 HwSuppCheckPhyDisableModeVer;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#128: FILE: drivers/net/r8169/r8169_ethdev.h:47:
+ u32 HwSuppMaxPhyLinkSpeed;
CHECK:CAMELCASE: Avoid CamelCase: <PhyState>
#183: FILE: drivers/net/r8169/r8169_phy.c:376:
+rtl_wait_phy_ups_resume(struct rtl_hw *hw, u16 PhyState)
CHECK:CAMELCASE: Avoid CamelCase: <HwHasWrRamCodeToMicroP>
#347: FILE: drivers/net/r8169/r8169_phy.c:540:
+ hw->HwHasWrRamCodeToMicroP = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#395: FILE: drivers/net/r8169/r8169_phy.c:588:
+ if (hw->NotWrRamCodeToMicroP == TRUE)
CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone
#395: FILE: drivers/net/r8169/r8169_phy.c:588:
+ if (hw->NotWrRamCodeToMicroP == TRUE)
WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'?
#665: FILE: drivers/net/r8169/r8169_phy.h:86:
+#define ADVERTISE_PAUSE_ASYM 0x0800 /* Try for asymetric pause */
total: 0 errors, 1 warnings, 6 checks, 601 lines checked
parent reply other threads:[~2024-10-28 7:34 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241028073112.107535-9-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028073416.973BB12314E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).