From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 01A4945BFB
	for <public@inbox.dpdk.org>; Mon, 28 Oct 2024 08:34:18 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id F07FC40B97;
	Mon, 28 Oct 2024 08:34:17 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id A07B540B97
 for <test-report@dpdk.org>; Mon, 28 Oct 2024 08:34:16 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 973BB12314E; Mon, 28 Oct 2024 08:34:16 +0100 (CET)
Subject: |WARNING| pw147468 [PATCH v5 08/18] net/r8169: add support for phy
 configuration
In-Reply-To: <20241028073112.107535-9-howard_wang@realsil.com.cn>
References: <20241028073112.107535-9-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241028073416.973BB12314E@dpdk.org>
Date: Mon, 28 Oct 2024 08:34:16 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147468

_coding style issues_


CHECK:CAMELCASE: Avoid CamelCase: <HwSuppCheckPhyDisableModeVer>
#123: FILE: drivers/net/r8169/r8169_ethdev.h:42:
+	u8  HwSuppCheckPhyDisableModeVer;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#128: FILE: drivers/net/r8169/r8169_ethdev.h:47:
+	u32 HwSuppMaxPhyLinkSpeed;

CHECK:CAMELCASE: Avoid CamelCase: <PhyState>
#183: FILE: drivers/net/r8169/r8169_phy.c:376:
+rtl_wait_phy_ups_resume(struct rtl_hw *hw, u16 PhyState)

CHECK:CAMELCASE: Avoid CamelCase: <HwHasWrRamCodeToMicroP>
#347: FILE: drivers/net/r8169/r8169_phy.c:540:
+		hw->HwHasWrRamCodeToMicroP = TRUE;

CHECK:CAMELCASE: Avoid CamelCase: <NotWrRamCodeToMicroP>
#395: FILE: drivers/net/r8169/r8169_phy.c:588:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

CHECK:BOOL_COMPARISON: Using comparison to TRUE is error prone
#395: FILE: drivers/net/r8169/r8169_phy.c:588:
+	if (hw->NotWrRamCodeToMicroP == TRUE)

WARNING:TYPO_SPELLING: 'asymetric' may be misspelled - perhaps 'asymmetric'?
#665: FILE: drivers/net/r8169/r8169_phy.h:86:
+#define ADVERTISE_PAUSE_ASYM	0x0800	/* Try for asymetric pause     */

total: 0 errors, 1 warnings, 6 checks, 601 lines checked