From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw147466 [PATCH v5 06/18] net/r8169: add phy registers access routines
Date: Mon, 28 Oct 2024 08:35:22 +0100 (CET) [thread overview]
Message-ID: <20241028073522.58D0212314E@dpdk.org> (raw)
In-Reply-To: <20241028073112.107535-7-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147466
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:CAMELCASE: Avoid CamelCase: <RegNum>
#99: FILE: drivers/net/r8169/r8169_phy.c:44:
+rtl_map_phy_ocp_addr(u16 PageNum, u8 RegNum)
CHECK:CAMELCASE: Avoid CamelCase: <RegAddr>
#128: FILE: drivers/net/r8169/r8169_phy.c:73:
+rtl_mdio_real_read_phy_ocp(struct rtl_hw *hw, u32 RegAddr)
CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Addr_Reg_shift>
#134: FILE: drivers/net/r8169/r8169_phy.c:79:
+ data32 <<= OCPR_Addr_Reg_shift;
CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Flag>
#140: FILE: drivers/net/r8169/r8169_phy.c:85:
+ if (RTL_R32(hw, PHYOCP) & OCPR_Flag)
CHECK:CAMELCASE: Avoid CamelCase: <OCPDR_Data_Mask>
#143: FILE: drivers/net/r8169/r8169_phy.c:88:
+ value = RTL_R32(hw, PHYOCP) & OCPDR_Data_Mask;
CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Write>
#178: FILE: drivers/net/r8169/r8169_phy.c:123:
+ data32 |= OCPR_Write | value;
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Write>
#254: FILE: drivers/net/r8169/r8169_phy.c:199:
+ RTL_W32(hw, EPHYAR, EPHYAR_Write |
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask_v2>
#255: FILE: drivers/net/r8169/r8169_phy.c:200:
+ (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_shift>
#255: FILE: drivers/net/r8169/r8169_phy.c:200:
+ (addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Data_Mask>
#256: FILE: drivers/net/r8169/r8169_phy.c:201:
+ (value & EPHYAR_Data_Mask));
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Flag>
#262: FILE: drivers/net/r8169/r8169_phy.c:207:
+ if (!(RTL_R32(hw, EPHYAR) & EPHYAR_Flag))
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Read>
#275: FILE: drivers/net/r8169/r8169_phy.c:220:
+ RTL_W32(hw, EPHYAR, EPHYAR_Read | (addr & EPHYAR_Reg_Mask_v2) <<
total: 0 errors, 1 warnings, 12 checks, 251 lines checked
parent reply other threads:[~2024-10-28 7:35 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20241028073112.107535-7-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241028073522.58D0212314E@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).