From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DBB9145BFB
	for <public@inbox.dpdk.org>; Mon, 28 Oct 2024 08:35:24 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D793C40DD3;
	Mon, 28 Oct 2024 08:35:24 +0100 (CET)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 62AC740DD3
 for <test-report@dpdk.org>; Mon, 28 Oct 2024 08:35:22 +0100 (CET)
Received: by dpdk.org (Postfix, from userid 65534)
 id 58D0212314E; Mon, 28 Oct 2024 08:35:22 +0100 (CET)
Subject: |WARNING| pw147466 [PATCH v5 06/18] net/r8169: add phy registers
 access routines
In-Reply-To: <20241028073112.107535-7-howard_wang@realsil.com.cn>
References: <20241028073112.107535-7-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20241028073522.58D0212314E@dpdk.org>
Date: Mon, 28 Oct 2024 08:35:22 +0100 (CET)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147466

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <RegNum>
#99: FILE: drivers/net/r8169/r8169_phy.c:44:
+rtl_map_phy_ocp_addr(u16 PageNum, u8 RegNum)

CHECK:CAMELCASE: Avoid CamelCase: <RegAddr>
#128: FILE: drivers/net/r8169/r8169_phy.c:73:
+rtl_mdio_real_read_phy_ocp(struct rtl_hw *hw, u32 RegAddr)

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Addr_Reg_shift>
#134: FILE: drivers/net/r8169/r8169_phy.c:79:
+	data32 <<= OCPR_Addr_Reg_shift;

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Flag>
#140: FILE: drivers/net/r8169/r8169_phy.c:85:
+		if (RTL_R32(hw, PHYOCP) & OCPR_Flag)

CHECK:CAMELCASE: Avoid CamelCase: <OCPDR_Data_Mask>
#143: FILE: drivers/net/r8169/r8169_phy.c:88:
+	value = RTL_R32(hw, PHYOCP) & OCPDR_Data_Mask;

CHECK:CAMELCASE: Avoid CamelCase: <OCPR_Write>
#178: FILE: drivers/net/r8169/r8169_phy.c:123:
+	data32 |= OCPR_Write | value;

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Write>
#254: FILE: drivers/net/r8169/r8169_phy.c:199:
+	RTL_W32(hw, EPHYAR, EPHYAR_Write |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask_v2>
#255: FILE: drivers/net/r8169/r8169_phy.c:200:
+		(addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_shift>
#255: FILE: drivers/net/r8169/r8169_phy.c:200:
+		(addr & EPHYAR_Reg_Mask_v2) << EPHYAR_Reg_shift |

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Data_Mask>
#256: FILE: drivers/net/r8169/r8169_phy.c:201:
+		(value & EPHYAR_Data_Mask));

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Flag>
#262: FILE: drivers/net/r8169/r8169_phy.c:207:
+		if (!(RTL_R32(hw, EPHYAR) & EPHYAR_Flag))

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Read>
#275: FILE: drivers/net/r8169/r8169_phy.c:220:
+	RTL_W32(hw, EPHYAR, EPHYAR_Read | (addr & EPHYAR_Reg_Mask_v2) <<

total: 0 errors, 1 warnings, 12 checks, 251 lines checked