automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Martin Weiser <martin.weiser@allegro-packets.com>
Subject: |WARNING| pw147513 [PATCH] igc: fix invalid length and corrupted multi-segment mbufs
Date: Mon, 28 Oct 2024 14:51:40 +0100 (CET)	[thread overview]
Message-ID: <20241028135140.792CC12314E@dpdk.org> (raw)
In-Reply-To: <5f0486a2-eb1e-4349-bdca-ee2c241379b3@allegro-packets.com>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain, Size: 1574 bytes --]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/147513

_coding style issues_


ERROR:CORRUPTED_PATCH: patch seems to be corrupt (line wrapped?)
#162: FILE: :510:
rte_mbuf **rx_pkts,

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#166: FILE: :514:
+        if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP) {

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#167: FILE: :515:
+            if (first_seg == NULL)

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#168: FILE: :516:
+                data_len -= IGC_TS_HDR_LEN;

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#169: FILE: :517:
+            else

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#170: FILE: :518:
+                rxm->data_off -= IGC_TS_HDR_LEN;

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#171: FILE: :519:
+        }

WARNING:EMBEDDED_FILENAME: It's generally not useful to have the filename in the file
#180: FILE: :568:
+                rxm = last_seg;

WARNING:SUSPECT_CODE_INDENT: suspect code indent for conditional statements (0, 0)
#194: FILE: drivers/net/igc/igc_txrx.c:350:
+        if (rxq->offloads & RTE_ETH_RX_OFFLOAD_TIMESTAMP)
+            data_len -= IGC_TS_HDR_LEN;

total: 1 errors, 8 warnings, 0 checks, 29 lines checked

      parent reply	other threads:[~2024-10-28 13:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <5f0486a2-eb1e-4349-bdca-ee2c241379b3@allegro-packets.com>
2024-10-28 13:18 ` qemudev
2024-10-28 13:51 ` checkpatch [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241028135140.792CC12314E@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=martin.weiser@allegro-packets.com \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).