|WARNING| pw154185 [PATCH v1 4/5] net/ixgbe: add ACI debug printouts

|WARNING| pw154185 [PATCH v1 4/5] net/ixgbe: add ACI debug printouts

[checkpatch]

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154185

_coding style issues_


WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#47: 
Subject: [PATCH v1 4/5] net/ixgbe: add ACI debug printouts

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#70: 
Add more verbose printouts for ACI when debugging is enabled.

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#90: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:35:
+ * ixgbe_aci_debug_array - dump a buffer of data row by row

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#97: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:42:
+STATIC void ixgbe_aci_debug_array(struct ixgbe_hw *hw, u16 row_size, u8 *buf,

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#100: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:45:
+	char debug_portion[IXGBE_ACI_MAX_DEBUG_STRING_LENGTH] = {''};

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#101: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:46:
+	char debug_string[IXGBE_ACI_MAX_DEBUG_STRING_LENGTH] = {''};

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#103: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:48:
+	s16 remaining_space = IXGBE_ACI_MAX_DEBUG_STRING_LENGTH - 1;

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#110: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:55:
+				nbytes = snprintf(debug_string, sizeof(debug_string), "0x%04X : ", i);

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#111: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:56:
+				remaining_space = IXGBE_ACI_MAX_DEBUG_STRING_LENGTH - nbytes - 1;

WARNING:LONG_LINE: line length of 119 exceeds 100 columns
#113: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:58:
+					nbytes = snprintf(debug_portion, sizeof(debug_portion), "0x%02X ", buf[i + j]);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#116: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:61:
+					if (remaining_space <= 0) break;

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#120: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:65:
+				memset(debug_string, 0, IXGBE_ACI_MAX_DEBUG_STRING_LENGTH);

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#125: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:70:
+			remaining_space = IXGBE_ACI_MAX_DEBUG_STRING_LENGTH - nbytes - 1;

WARNING:LONG_LINE: line length of 111 exceeds 100 columns
#127: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:72:
+				nbytes = snprintf(debug_portion, sizeof(debug_portion), "0x%02X ", buf[i + j]);

ERROR:TRAILING_STATEMENTS: trailing statements should be on next line
#130: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:75:
+				if (remaining_space <= 0) break;

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#139: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:84:
+ * ixgbe_aci_debug - dump the ACI data with the descriptor contents.

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#139: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:84:
+ * ixgbe_aci_debug - dump the ACI data with the descriptor contents.

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#145: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:90:
+ * Debug function for dumping logs about ACI command with descriptor contents.

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#147: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:92:
+void ixgbe_aci_debug(struct ixgbe_hw *hw, void *desc, void *buf, u16 buf_len)

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#149: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:94:
+	struct ixgbe_aci_desc *aci_desc = (struct ixgbe_aci_desc *)desc;

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#149: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:94:
+	struct ixgbe_aci_desc *aci_desc = (struct ixgbe_aci_desc *)desc;

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#149: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:94:
+	struct ixgbe_aci_desc *aci_desc = (struct ixgbe_aci_desc *)desc;

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#155: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:100:
+	datalen = IXGBE_LE16_TO_CPU(aci_desc->datalen);

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#156: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:101:
+	flags = IXGBE_LE16_TO_CPU(aci_desc->flags);

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#159: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:104:
+		  IXGBE_LE16_TO_CPU(aci_desc->opcode), flags, datalen,

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#160: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:105:
+		  IXGBE_LE16_TO_CPU(aci_desc->retval));

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#162: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:107:
+		  IXGBE_LE32_TO_CPU(aci_desc->cookie_high),

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#163: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:108:
+		  IXGBE_LE32_TO_CPU(aci_desc->cookie_low));

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#165: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:110:
+		  IXGBE_LE32_TO_CPU(aci_desc->params.generic.param0),

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#166: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:111:
+		  IXGBE_LE32_TO_CPU(aci_desc->params.generic.param1));

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#168: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:113:
+		  IXGBE_LE32_TO_CPU(aci_desc->params.generic.addr_high),

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#169: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:114:
+		  IXGBE_LE32_TO_CPU(aci_desc->params.generic.addr_low));

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#174: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:119:
+	if (buf && aci_desc->datalen != 0 &&

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#175: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:120:
+	    (flags & (IXGBE_ACI_FLAG_DD | IXGBE_ACI_FLAG_CMP) ||

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#175: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:120:
+	    (flags & (IXGBE_ACI_FLAG_DD | IXGBE_ACI_FLAG_CMP) ||

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#176: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:121:
+	     flags & IXGBE_ACI_FLAG_RD)) {

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#178: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:123:
+		ixgbe_aci_debug_array(hw, 16, (u8 *)buf, min(buf_len, datalen));

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#218: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:256:
+		ixgbe_aci_debug(hw, (void *)desc, tmp_buf, (u16)tmp_buf_size);

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#227: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:297:
+			ixgbe_aci_debug(hw, (void *)raw_desc, NULL, 0);

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#235: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:306:
+			ixgbe_aci_debug(hw, (void *)raw_desc, NULL, 0);

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#269: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.c:350:
+			ixgbe_aci_debug(hw, (void *)raw_desc, tmp_buf,

WARNING:TYPO_SPELLING: 'aci' may be misspelled - perhaps ''?
#282: FILE: drivers/net/intel/ixgbe/base/ixgbe_e610.h:13:
+void ixgbe_aci_debug(struct ixgbe_hw *hw, void *desc, void *buf, u16 buf_len);

WARNING:TYPO_SPELLING: 'ACI' may be misspelled - perhaps ''?
#307: FILE: drivers/net/intel/ixgbe/base/ixgbe_type_e610.h:364:
+#define IXGBE_ACI_MAX_DEBUG_STRING_LENGTH	128

total: 2 errors, 41 warnings, 0 checks, 202 lines checked