From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Subject: |WARNING| pw154236 [PATCH 3/8] net/r8169: add support for RTL8127
Date: Tue, 10 Jun 2025 08:02:39 +0200 (CEST) [thread overview]
Message-ID: <20250610060239.C413E12527C@dpdk.org> (raw)
In-Reply-To: <20250610060123.4104-3-howard_wang@realsil.com.cn>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154236
_coding style issues_
WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one
CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#469: FILE: drivers/net/r8169/base/rtl8127.c:17:
+ RTL_W32(hw, RxConfig, Rx_Fetch_Number_8 | Rx_Close_Multiple |
CHECK:CAMELCASE: Avoid CamelCase: <Rx_Fetch_Number_8>
#469: FILE: drivers/net/r8169/base/rtl8127.c:17:
+ RTL_W32(hw, RxConfig, Rx_Fetch_Number_8 | Rx_Close_Multiple |
CHECK:CAMELCASE: Avoid CamelCase: <Rx_Close_Multiple>
#469: FILE: drivers/net/r8169/base/rtl8127.c:17:
+ RTL_W32(hw, RxConfig, Rx_Fetch_Number_8 | Rx_Close_Multiple |
CHECK:CAMELCASE: Avoid CamelCase: <RxCfg_pause_slot_en>
#470: FILE: drivers/net/r8169/base/rtl8127.c:18:
+ RxCfg_pause_slot_en | (RX_DMA_BURST_512 << RxCfgDMAShift));
CHECK:CAMELCASE: Avoid CamelCase: <RxCfgDMAShift>
#470: FILE: drivers/net/r8169/base/rtl8127.c:18:
+ RxCfg_pause_slot_en | (RX_DMA_BURST_512 << RxCfgDMAShift));
CHECK:CAMELCASE: Avoid CamelCase: <NotWrMcuPatchCode>
#786: FILE: drivers/net/r8169/base/rtl8127.c:334:
+ if (hw->NotWrMcuPatchCode)
CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#1910: FILE: drivers/net/r8169/r8169_hw.c:632:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);
CHECK:CAMELCASE: Avoid CamelCase: <StopReq>
#1910: FILE: drivers/net/r8169/r8169_hw.c:632:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);
CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#1998: FILE: drivers/net/r8169/r8169_hw.c:659:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));
CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#1998: FILE: drivers/net/r8169/r8169_hw.c:659:
+ RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));
CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#2027: FILE: drivers/net/r8169/r8169_hw.c:670:
+ if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==
CHECK:CAMELCASE: Avoid CamelCase: <Txfifo_empty>
#2027: FILE: drivers/net/r8169/r8169_hw.c:670:
+ if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==
CHECK:CAMELCASE: Avoid CamelCase: <Rxfifo_empty>
#2027: FILE: drivers/net/r8169/r8169_hw.c:670:
+ if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==
CHECK:CAMELCASE: Avoid CamelCase: <Config1>
#2226: FILE: drivers/net/r8169/r8169_hw.c:973:
+ RTL_W8(hw, Config1, RTL_R8(hw, Config1) & ~0x10);
CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#2242: FILE: drivers/net/r8169/r8169_hw.c:989:
+ if (hw->EnableTxNoClose)
CHECK:CAMELCASE: Avoid CamelCase: <EnableRxDescV4_0>
#2268: FILE: drivers/net/r8169/r8169_hw.c:1003:
+ RTL_W8(hw, 0xD8, RTL_R8(hw, 0xD8) & ~EnableRxDescV4_0);
CHECK:CAMELCASE: Avoid CamelCase: <Config3>
#2568: FILE: drivers/net/r8169/r8169_hw.c:1154:
+ RTL_W8(hw, Config3, RTL_R8(hw, Config3) & ~BIT_1);
CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ExGMAC>
#2594: FILE: drivers/net/r8169/r8169_hw.c:1157:
+ csi_tmp = rtl_eri_read(hw, 0xDE, 1, ERIAR_ExGMAC);
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#2796: FILE: drivers/net/r8169/r8169_hw.c:1493:
+ speed = hw->HwSuppMaxPhyLinkSpeed;
CHECK:CAMELCASE: Avoid CamelCase: <HwSuppNowIsOobVer>
#2866: FILE: drivers/net/r8169/r8169_hw.c:1711:
+ hw->HwSuppNowIsOobVer = 1;
CHECK:CAMELCASE: Avoid CamelCase: <HwIcVerUnknown>
#3132: FILE: drivers/net/r8169/r8169_hw.c:2509:
+ hw->HwIcVerUnknown = TRUE;
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask_v2>
#3354: FILE: drivers/net/r8169/r8169_phy.c:209:
+ _rtl_ephy_write(hw, EPHYAR_EXT_ADDR, addr, EPHYAR_Reg_Mask_v2);
CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask>
#3411: FILE: drivers/net/r8169/r8169_phy.c:271:
+ mask = EPHYAR_Reg_Mask;
total: 0 errors, 1 warnings, 23 checks, 3921 lines checked
parent reply other threads:[~2025-06-10 6:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250610060123.4104-3-howard_wang@realsil.com.cn>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250610060239.C413E12527C@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=howard_wang@realsil.com.cn \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).