From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0AF42468BF
	for <public@inbox.dpdk.org>; Tue, 10 Jun 2025 08:25:52 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 0544E402D4;
	Tue, 10 Jun 2025 08:25:52 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 3DAF3402D4
 for <test-report@dpdk.org>; Tue, 10 Jun 2025 08:25:50 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 9B0F412527C; Tue, 10 Jun 2025 08:24:55 +0200 (CEST)
Subject: |WARNING| pw154244 [PATCH v1 3/8] net/r8169: add support for RTL8127
In-Reply-To: <20250610062241.4517-4-howard_wang@realsil.com.cn>
References: <20250610062241.4517-4-howard_wang@realsil.com.cn>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Howard Wang <howard_wang@realsil.com.cn>
Message-Id: <20250610062455.9B0F412527C@dpdk.org>
Date: Tue, 10 Jun 2025 08:24:55 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154244

_coding style issues_


WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

CHECK:CAMELCASE: Avoid CamelCase: <RxConfig>
#470: FILE: drivers/net/r8169/base/rtl8127.c:17:
+		RTL_W32(hw, RxConfig, Rx_Fetch_Number_8 | Rx_Close_Multiple |

CHECK:CAMELCASE: Avoid CamelCase: <Rx_Fetch_Number_8>
#470: FILE: drivers/net/r8169/base/rtl8127.c:17:
+		RTL_W32(hw, RxConfig, Rx_Fetch_Number_8 | Rx_Close_Multiple |

CHECK:CAMELCASE: Avoid CamelCase: <Rx_Close_Multiple>
#470: FILE: drivers/net/r8169/base/rtl8127.c:17:
+		RTL_W32(hw, RxConfig, Rx_Fetch_Number_8 | Rx_Close_Multiple |

CHECK:CAMELCASE: Avoid CamelCase: <RxCfg_pause_slot_en>
#471: FILE: drivers/net/r8169/base/rtl8127.c:18:
+			RxCfg_pause_slot_en | (RX_DMA_BURST_512 << RxCfgDMAShift));

CHECK:CAMELCASE: Avoid CamelCase: <RxCfgDMAShift>
#471: FILE: drivers/net/r8169/base/rtl8127.c:18:
+			RxCfg_pause_slot_en | (RX_DMA_BURST_512 << RxCfgDMAShift));

CHECK:CAMELCASE: Avoid CamelCase: <NotWrMcuPatchCode>
#787: FILE: drivers/net/r8169/base/rtl8127.c:334:
+	if (hw->NotWrMcuPatchCode)

CHECK:CAMELCASE: Avoid CamelCase: <ChipCmd>
#1911: FILE: drivers/net/r8169/r8169_hw.c:632:
+		RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);

CHECK:CAMELCASE: Avoid CamelCase: <StopReq>
#1911: FILE: drivers/net/r8169/r8169_hw.c:632:
+		RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) | StopReq);

CHECK:CAMELCASE: Avoid CamelCase: <CmdTxEnb>
#1999: FILE: drivers/net/r8169/r8169_hw.c:659:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));

CHECK:CAMELCASE: Avoid CamelCase: <CmdRxEnb>
#1999: FILE: drivers/net/r8169/r8169_hw.c:659:
+	RTL_W8(hw, ChipCmd, RTL_R8(hw, ChipCmd) & (CmdTxEnb | CmdRxEnb));

CHECK:CAMELCASE: Avoid CamelCase: <MCUCmd_reg>
#2028: FILE: drivers/net/r8169/r8169_hw.c:670:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Txfifo_empty>
#2028: FILE: drivers/net/r8169/r8169_hw.c:670:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Rxfifo_empty>
#2028: FILE: drivers/net/r8169/r8169_hw.c:670:
+			if ((RTL_R8(hw, MCUCmd_reg) & (Txfifo_empty | Rxfifo_empty)) ==

CHECK:CAMELCASE: Avoid CamelCase: <Config1>
#2227: FILE: drivers/net/r8169/r8169_hw.c:973:
+	RTL_W8(hw, Config1, RTL_R8(hw, Config1) & ~0x10);

CHECK:CAMELCASE: Avoid CamelCase: <EnableTxNoClose>
#2243: FILE: drivers/net/r8169/r8169_hw.c:989:
+		if (hw->EnableTxNoClose)

CHECK:CAMELCASE: Avoid CamelCase: <EnableRxDescV4_0>
#2269: FILE: drivers/net/r8169/r8169_hw.c:1003:
+		RTL_W8(hw, 0xD8, RTL_R8(hw, 0xD8) & ~EnableRxDescV4_0);

CHECK:CAMELCASE: Avoid CamelCase: <Config3>
#2569: FILE: drivers/net/r8169/r8169_hw.c:1154:
+	RTL_W8(hw, Config3, RTL_R8(hw, Config3) & ~BIT_1);

CHECK:CAMELCASE: Avoid CamelCase: <ERIAR_ExGMAC>
#2595: FILE: drivers/net/r8169/r8169_hw.c:1157:
+	csi_tmp = rtl_eri_read(hw, 0xDE, 1, ERIAR_ExGMAC);

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppMaxPhyLinkSpeed>
#2797: FILE: drivers/net/r8169/r8169_hw.c:1493:
+		speed = hw->HwSuppMaxPhyLinkSpeed;

CHECK:CAMELCASE: Avoid CamelCase: <HwSuppNowIsOobVer>
#2867: FILE: drivers/net/r8169/r8169_hw.c:1711:
+	hw->HwSuppNowIsOobVer = 1;

CHECK:CAMELCASE: Avoid CamelCase: <HwIcVerUnknown>
#3133: FILE: drivers/net/r8169/r8169_hw.c:2509:
+			hw->HwIcVerUnknown = TRUE;

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask_v2>
#3355: FILE: drivers/net/r8169/r8169_phy.c:209:
+	_rtl_ephy_write(hw, EPHYAR_EXT_ADDR, addr, EPHYAR_Reg_Mask_v2);

CHECK:CAMELCASE: Avoid CamelCase: <EPHYAR_Reg_Mask>
#3412: FILE: drivers/net/r8169/r8169_phy.c:271:
+		mask = EPHYAR_Reg_Mask;

total: 0 errors, 1 warnings, 23 checks, 3921 lines checked