From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01EA3469E9 for ; Wed, 18 Jun 2025 09:58:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF878427AC; Wed, 18 Jun 2025 09:58:05 +0200 (CEST) Received: from dpdk.org (dpdk.org [92.243.24.197]) by mails.dpdk.org (Postfix) with ESMTP id 46E9E427AC for ; Wed, 18 Jun 2025 09:58:05 +0200 (CEST) Received: by dpdk.org (Postfix, from userid 65534) id CF0781252C7; Wed, 18 Jun 2025 09:57:00 +0200 (CEST) Subject: |WARNING| pw154563 [PATCH v2 2/2] net/zxdh: add support flow director ops In-Reply-To: <20250618074936.3616999-3-chen.bingbin@zte.com.cn> References: <20250618074936.3616999-3-chen.bingbin@zte.com.cn> To: test-report@dpdk.org From: checkpatch@dpdk.org Cc: Bingbin Chen Message-Id: <20250618075700.CF0781252C7@dpdk.org> Date: Wed, 18 Jun 2025 09:57:00 +0200 (CEST) X-BeenThere: test-report@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: automatic DPDK test reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: test-report-bounces@dpdk.org Test-Label: checkpatch Test-Status: WARNING http://dpdk.org/patch/154563 _coding style issues_ WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line) #60: Provide support for ETH, VLAN, IPv4/IPv6, TCP/UDP, VXLAN, and mask matching, WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'? #337: FILE: drivers/net/zxdh/zxdh_flow.c:6: +#include CHECK:MACRO_ARG_REUSE: Macro argument reuse 'buf_size' - possible side-effects? #378: FILE: drivers/net/zxdh/zxdh_flow.c:47: +#define MKDUMPSTR(buf, buf_size, cur_len, ...) \ +do { \ + if ((cur_len) >= (buf_size)) \ + break; \ + (cur_len) += snprintf((buf) + (cur_len), (buf_size) - (cur_len), __VA_ARGS__); \ +} while (0) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'cur_len' - possible side-effects? #378: FILE: drivers/net/zxdh/zxdh_flow.c:47: +#define MKDUMPSTR(buf, buf_size, cur_len, ...) \ +do { \ + if ((cur_len) >= (buf_size)) \ + break; \ + (cur_len) += snprintf((buf) + (cur_len), (buf_size) - (cur_len), __VA_ARGS__); \ +} while (0) CHECK:CAMELCASE: Avoid CamelCase: #456: FILE: drivers/net/zxdh/zxdh_flow.c:125: + "L3 dstip=0x%08x 0x%08x 0x%08x 0x%08x("IPv6_BYTES_FMT") ", CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #456: FILE: drivers/net/zxdh/zxdh_flow.c:125: + "L3 dstip=0x%08x 0x%08x 0x%08x 0x%08x("IPv6_BYTES_FMT") ", CHECK:CAMELCASE: Avoid CamelCase: #460: FILE: drivers/net/zxdh/zxdh_flow.c:129: + IPv6_BYTES(key->dst_ip)); CHECK:CONCATENATED_STRING: Concatenated strings should use spaces between elements #462: FILE: drivers/net/zxdh/zxdh_flow.c:131: + " srcip=0x%08x 0x%08x 0x%08x 0x%08x("IPv6_BYTES_FMT") ", WARNING:TYPO_SPELLING: 'realease' may be misspelled - perhaps 'release'? #1235: FILE: drivers/net/zxdh/zxdh_flow.c:904: + "realease handle_idx to hw failed"); WARNING:TYPO_SPELLING: 'realease' may be misspelled - perhaps 'release'? #1426: FILE: drivers/net/zxdh/zxdh_flow.c:1095: + "realease handle_idx to hw failed"); WARNING:TYPO_SPELLING: 'realease' may be misspelled - perhaps 'release'? #1429: FILE: drivers/net/zxdh/zxdh_flow.c:1098: + PMD_DRV_LOG(DEBUG, "realease handle_idx to hw succ! %d", handle_idx); ERROR:C99_COMMENTS: do not use C99 // comments #1620: FILE: drivers/net/zxdh/zxdh_flow.c:1289: + //ether_type = rte_be_to_cpu_16(eth_spec->type); CHECK:CAMELCASE: Avoid CamelCase: #2373: FILE: drivers/net/zxdh/zxdh_flow.h:32: +#ifndef IPv4_BYTES CHECK:CAMELCASE: Avoid CamelCase: #2374: FILE: drivers/net/zxdh/zxdh_flow.h:33: +#define IPv4_BYTES_FMT "%" PRIu8 ".%" PRIu8 ".%" PRIu8 ".%" PRIu8 CHECK:CAMELCASE: Avoid CamelCase: #2374: FILE: drivers/net/zxdh/zxdh_flow.h:33: +#define IPv4_BYTES_FMT "%" PRIu8 ".%" PRIu8 ".%" PRIu8 ".%" PRIu8 ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2375: FILE: drivers/net/zxdh/zxdh_flow.h:34: +#define IPv4_BYTES(addr) \ + (uint8_t)(((addr) >> 24) & 0xFF),\ + (uint8_t)(((addr) >> 16) & 0xFF),\ + (uint8_t)(((addr) >> 8) & 0xFF),\ + (uint8_t)((addr) & 0xFF) CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #2375: FILE: drivers/net/zxdh/zxdh_flow.h:34: +#define IPv4_BYTES(addr) \ + (uint8_t)(((addr) >> 24) & 0xFF),\ + (uint8_t)(((addr) >> 16) & 0xFF),\ + (uint8_t)(((addr) >> 8) & 0xFF),\ + (uint8_t)((addr) & 0xFF) ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses #2385: FILE: drivers/net/zxdh/zxdh_flow.h:44: +#define IPv6_BYTES(addr) \ + addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], addr[6], addr[7], \ + addr[8], addr[9], addr[10], addr[11], addr[12], addr[13], addr[14], addr[15] CHECK:MACRO_ARG_REUSE: Macro argument reuse 'addr' - possible side-effects? #2385: FILE: drivers/net/zxdh/zxdh_flow.h:44: +#define IPv6_BYTES(addr) \ + addr[0], addr[1], addr[2], addr[3], addr[4], addr[5], addr[6], addr[7], \ + addr[8], addr[9], addr[10], addr[11], addr[12], addr[13], addr[14], addr[15] total: 3 errors, 5 warnings, 11 checks, 3014 lines checked