From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id E6F4D46A53
	for <public@inbox.dpdk.org>; Wed, 25 Jun 2025 14:53:40 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id E326B40E1B;
	Wed, 25 Jun 2025 14:53:40 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 5E64040E20
 for <test-report@dpdk.org>; Wed, 25 Jun 2025 14:53:39 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 5B8BE1252CF; Wed, 25 Jun 2025 14:52:26 +0200 (CEST)
Subject: |WARNING| pw154714 [PATCH v2 14/15] net/txgbe: add other
 hardware-related changes
In-Reply-To: <20250625125047.18072-15-zaiyuwang@trustnetic.com>
References: <20250625125047.18072-15-zaiyuwang@trustnetic.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>
Message-Id: <20250625125226.5B8BE1252CF@dpdk.org>
Date: Wed, 25 Jun 2025 14:52:26 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154714

_coding style issues_


WARNING:TYPO_SPELLING: 'Lite' may be misspelled - perhaps 'Light'?
#75: 
Add other hardware-related changes for Amber-Lite NICs, such as PF

WARNING:MSLEEP: msleep < 20ms can sleep for up to 20ms; see Documentation/timers/timers-howto.rst
#127: FILE: drivers/net/txgbe/base/txgbe_hw.c:2237:
+			msleep(1);

WARNING:TYPO_SPELLING: 'THRE' may be misspelled - perhaps 'THREE'?
#183: FILE: drivers/net/txgbe/base/txgbe_hw.c:2298:
+		wr32m(hw, TXGBE_AML_TS_CTL1, TXGBE_AML_ALARM_THRE_MASK, 0x186a0000);

WARNING:TYPO_SPELLING: 'THRE' may be misspelled - perhaps 'THREE'?
#184: FILE: drivers/net/txgbe/base/txgbe_hw.c:2299:
+		wr32m(hw, TXGBE_AML_TS_CTL1, TXGBE_AML_DALARM_THRE_MASK, 0x16f60);

WARNING:TYPO_SPELLING: 'THRE' may be misspelled - perhaps 'THREE'?
#380: FILE: drivers/net/txgbe/base/txgbe_type.h:64:
+#define TXGBE_AML_ALARM_THRE_MASK       0x1FFE0000U

WARNING:TYPO_SPELLING: 'THRE' may be misspelled - perhaps 'THREE'?
#381: FILE: drivers/net/txgbe/base/txgbe_type.h:65:
+#define TXGBE_AML_DALARM_THRE_MASK      0x0001FFE0U

total: 0 errors, 6 warnings, 0 checks, 370 lines checked