From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>
Subject: |WARNING| pw154709 [PATCH v2 09/15] net/txgbe: add TX head Write-Back mode for Amber-Lite NICs
Date: Wed, 25 Jun 2025 14:52:51 +0200 (CEST) [thread overview]
Message-ID: <20250625125251.431891252CF@dpdk.org> (raw)
In-Reply-To: <20250625125047.18072-10-zaiyuwang@trustnetic.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154709
_coding style issues_
WARNING:TYPO_SPELLING: 'Lite' may be misspelled - perhaps 'Light'?
#77:
Add TX head Write-Back mode for Amber-Lite NICs. When enabled, the
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->headwb_mem
#198: FILE: drivers/net/txgbe/txgbe_rxtx.c:101:
+ volatile uint16_t head = (uint16_t)*(txq->headwb_mem);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->headwb_mem
#235: FILE: drivers/net/txgbe/txgbe_rxtx.c:648:
+ u32 head = *(txq->headwb_mem);
ERROR:C99_COMMENTS: do not use C99 // comments
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:2429:
+ TXGBE_ALIGN, socket_id);//amlite-to-do: align?
CHECK:SPACING: No space is necessary after a cast
#299: FILE: drivers/net/txgbe/txgbe_rxtx.c:2439:
+ txq->headwb_mem = (uint32_t *) TMZ_VADDR(headwb);
CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->headwb_mem
#394: FILE: drivers/net/txgbe/txgbe_rxtx_vec_common.h:97:
+ volatile uint16_t head = (uint16_t)*(txq->headwb_mem);
total: 1 errors, 1 warnings, 4 checks, 279 lines checked
parent reply other threads:[~2025-06-25 12:54 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250625125047.18072-10-zaiyuwang@trustnetic.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250625125251.431891252CF@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=test-report@dpdk.org \
--cc=zaiyuwang@trustnetic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).