From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3E5F546A53
	for <public@inbox.dpdk.org>; Wed, 25 Jun 2025 14:54:06 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 3A1AD402AB;
	Wed, 25 Jun 2025 14:54:06 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 41FE7402AB
 for <test-report@dpdk.org>; Wed, 25 Jun 2025 14:54:04 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 431891252CF; Wed, 25 Jun 2025 14:52:51 +0200 (CEST)
Subject: |WARNING| pw154709 [PATCH v2 09/15] net/txgbe: add TX head Write-Back
 mode for Amber-Lite NICs
In-Reply-To: <20250625125047.18072-10-zaiyuwang@trustnetic.com>
References: <20250625125047.18072-10-zaiyuwang@trustnetic.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>
Message-Id: <20250625125251.431891252CF@dpdk.org>
Date: Wed, 25 Jun 2025 14:52:51 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154709

_coding style issues_


WARNING:TYPO_SPELLING: 'Lite' may be misspelled - perhaps 'Light'?
#77: 
Add TX head Write-Back mode for Amber-Lite NICs. When enabled, the

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->headwb_mem
#198: FILE: drivers/net/txgbe/txgbe_rxtx.c:101:
+		volatile uint16_t head = (uint16_t)*(txq->headwb_mem);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->headwb_mem
#235: FILE: drivers/net/txgbe/txgbe_rxtx.c:648:
+		u32 head = *(txq->headwb_mem);

ERROR:C99_COMMENTS: do not use C99 // comments
#289: FILE: drivers/net/txgbe/txgbe_rxtx.c:2429:
+			TXGBE_ALIGN, socket_id);//amlite-to-do: align?

CHECK:SPACING: No space is necessary after a cast
#299: FILE: drivers/net/txgbe/txgbe_rxtx.c:2439:
+	txq->headwb_mem = (uint32_t *) TMZ_VADDR(headwb);

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around txq->headwb_mem
#394: FILE: drivers/net/txgbe/txgbe_rxtx_vec_common.h:97:
+				volatile uint16_t head = (uint16_t)*(txq->headwb_mem);

total: 1 errors, 1 warnings, 4 checks, 279 lines checked