From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8AEB646A53
	for <public@inbox.dpdk.org>; Wed, 25 Jun 2025 14:54:35 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 869D4402AB;
	Wed, 25 Jun 2025 14:54:35 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id CA220402AB
 for <test-report@dpdk.org>; Wed, 25 Jun 2025 14:54:33 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id CE3A21252CF; Wed, 25 Jun 2025 14:53:20 +0200 (CEST)
Subject: |WARNING| pw154704 [PATCH v2 04/15] net/txgbe: add basic link
 configuration for Amber-Lite NICs
In-Reply-To: <20250625125047.18072-5-zaiyuwang@trustnetic.com>
References: <20250625125047.18072-5-zaiyuwang@trustnetic.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>
Message-Id: <20250625125320.CE3A21252CF@dpdk.org>
Date: Wed, 25 Jun 2025 14:53:20 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154704

_coding style issues_


WARNING:TYPO_SPELLING: 'Lite' may be misspelled - perhaps 'Light'?
#77: 
Due to Amber-Lite's significant differences from our 10G NICs, we split

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#78: 
link configuration components (setup_link, check_link, etc.) into new files.

CHECK:BRACES: braces {} should be used on all arms of this statement
#182: FILE: drivers/net/txgbe/base/txgbe_aml.c:66:
+	if (link_up) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#193: FILE: drivers/net/txgbe/base/txgbe_aml.c:77:
+	} else

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_25GB_FULL'
#347: FILE: drivers/net/txgbe/base/txgbe_aml.c:231:
+		if ((link_speed == TXGBE_LINK_SPEED_25GB_FULL) && link_up)

WARNING:TYPO_SPELLING: 'repeatly' may be misspelled - perhaps 'repeatedly'?
#359: FILE: drivers/net/txgbe/base/txgbe_aml.c:243:
+		/*aml wait link in setup,no need to repeatly wait*/

CHECK:BRACES: Blank lines aren't necessary before a close brace '}'
#366: FILE: drivers/net/txgbe/base/txgbe_aml.c:250:
+
+	}

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'link_speed == TXGBE_LINK_SPEED_10GB_FULL'
#376: FILE: drivers/net/txgbe/base/txgbe_aml.c:260:
+		if ((link_speed == TXGBE_LINK_SPEED_10GB_FULL) && link_up)

WARNING:TYPO_SPELLING: 'repeatly' may be misspelled - perhaps 'repeatedly'?
#387: FILE: drivers/net/txgbe/base/txgbe_aml.c:271:
+		/*aml wait link in setup,no need to repeatly wait*/

CHECK:BRACES: braces {} should be used on all arms of this statement
#540: FILE: drivers/net/txgbe/base/txgbe_aml40.c:67:
+	if (link_up) {
[...]
+	} else
[...]

CHECK:BRACES: Unbalanced braces around else statement
#544: FILE: drivers/net/txgbe/base/txgbe_aml40.c:71:
+	} else

total: 0 errors, 4 warnings, 7 checks, 740 lines checked