From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A8F1546A53
	for <public@inbox.dpdk.org>; Wed, 25 Jun 2025 14:54:52 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A4916402AB;
	Wed, 25 Jun 2025 14:54:52 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 59455402AB
 for <test-report@dpdk.org>; Wed, 25 Jun 2025 14:54:51 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 5CBA21252CF; Wed, 25 Jun 2025 14:53:38 +0200 (CEST)
Subject: |WARNING| pw154702 [PATCH v2 02/15] net/txgbe: add new SW-FW mailbox
 interface
In-Reply-To: <20250625125047.18072-3-zaiyuwang@trustnetic.com>
References: <20250625125047.18072-3-zaiyuwang@trustnetic.com>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Zaiyu Wang <zaiyuwang@trustnetic.com>
Message-Id: <20250625125338.5CBA21252CF@dpdk.org>
Date: Wed, 25 Jun 2025 14:53:38 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/154702

_coding style issues_


WARNING:TYPO_SPELLING: 'Lite' may be misspelled - perhaps 'Light'?
#75: 
Amber-Lite NICs adopt new mailbox interface for software-firmware

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'recv_hdr->cmd == send_cmd'
#219: FILE: drivers/net/txgbe/base/txgbe_mng.c:169:
+			if ((recv_hdr->cmd == send_cmd) &&
+			    (recv_hdr->cksum_or_index.index == hw->swfw_index))

CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'recv_hdr->cksum_or_index.index == hw->swfw_index'
#219: FILE: drivers/net/txgbe/base/txgbe_mng.c:169:
+			if ((recv_hdr->cmd == send_cmd) &&
+			    (recv_hdr->cksum_or_index.index == hw->swfw_index))

total: 0 errors, 1 warnings, 2 checks, 402 lines checked
Warning in drivers/net/txgbe/base/txgbe_mng.c:
Using rte_atomicNN_xxx