From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Jie Liu <liujie5@linkdatatechnology.com>
Subject: |WARNING| pw155035 [PATCH v3 04/14] net/sxe: add link, flow ctrl, mac ops, mtu ops function
Date: Mon, 7 Jul 2025 13:59:25 +0200 (CEST) [thread overview]
Message-ID: <20250707115925.9579F125304@dpdk.org> (raw)
In-Reply-To: <20250707115819.12826-4-liujie5@linkdatatechnology.com>
Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155035
_coding style issues_
WARNING:TYPO_SPELLING: 'unsupport' may be misspelled - perhaps 'unsupported'?
#367: FILE: drivers/net/sxe/pf/sxe_ethdev.c:273:
+ PMD_LOG_ERR(INIT, "unsupport loopback mode:%u.",
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#809: FILE: drivers/net/sxe/pf/sxe_filter.c:19:
+#define SXE_STRIP_BITMAP_SET(h, q) \
+ do { \
+ u32 idx = (q) / (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \
+ u32 bit = (q) % (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \
+ (h)->strip_bitmap[idx] |= 1 << bit;\
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#816: FILE: drivers/net/sxe/pf/sxe_filter.c:26:
+#define SXE_STRIP_BITMAP_CLEAR(h, q) \
+ do {\
+ u32 idx = (q) / (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \
+ u32 bit = (q) % (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \
+ (h)->strip_bitmap[idx] &= ~(1 << bit);\
+ } while (0)
CHECK:MACRO_ARG_REUSE: Macro argument reuse 'q' - possible side-effects?
#823: FILE: drivers/net/sxe/pf/sxe_filter.c:33:
+#define SXE_STRIP_BITMAP_GET(h, q, r) \
+ do {\
+ u32 idx = (q) / (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \
+ u32 bit = (q) % (sizeof((h)->strip_bitmap[0]) * BYTE_BIT_NUM); \
+ (r) = (h)->strip_bitmap[idx] >> bit & 1;\
+ } while (0)
CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#1319: FILE: drivers/net/sxe/pf/sxe_irq.c:78:
+ (eicr & SXE_EICR_LSC)) {
+
WARNING:TYPO_SPELLING: 'exsit' may be misspelled - perhaps 'exist'?
#1586: FILE: drivers/net/sxe/pf/sxe_phy.c:124:
+ PMD_LOG_INFO(INIT, "other link config thread exsit");
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#2146: FILE: drivers/net/sxe/pf/sxe_phy.c:684:
+ PMD_LOG_INFO(INIT, "link down, dont fc autoneg");
WARNING:TYPO_SPELLING: 'dont' may be misspelled - perhaps 'don't'?
#2152: FILE: drivers/net/sxe/pf/sxe_phy.c:690:
+ "dont fc autoneg", link_speed);
total: 0 errors, 4 warnings, 4 checks, 2299 lines checked
parent reply other threads:[~2025-07-07 12:00 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20250707115819.12826-4-liujie5@linkdatatechnology.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707115925.9579F125304@dpdk.org \
--to=checkpatch@dpdk.org \
--cc=liujie5@linkdatatechnology.com \
--cc=test-report@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).