automatic DPDK test reports
 help / color / mirror / Atom feed
From: checkpatch@dpdk.org
To: test-report@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: |WARNING| pw155115 [RFC v2 06/12] ethdev: add port mirroring feature
Date: Wed,  9 Jul 2025 19:37:10 +0200 (CEST)	[thread overview]
Message-ID: <20250709173710.9D4C0125307@dpdk.org> (raw)
In-Reply-To: <20250709173611.6390-7-stephen@networkplumber.org>

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155115

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#158: FILE: lib/ethdev/ethdev_private.c:283:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#159: FILE: lib/ethdev/ethdev_private.c:284:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#424: FILE: lib/ethdev/rte_ethdev_core.h:105:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#433: FILE: lib/ethdev/rte_ethdev_core.h:125:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#452: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#504: FILE: lib/ethdev/rte_mirror.c:61:
+	if (rte_mbuf_dyn_tx_timestamp_register(&mbuf_timestamp_offset, &mbuf_timestamp_dynflag) < 0) {

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#587: FILE: lib/ethdev/rte_mirror.c:144:
+	    conf->direction > (RTE_ETH_MIRROR_DIRECTION_INGRESS | RTE_ETH_MIRROR_DIRECTION_EGRESS)) {

total: 4 errors, 3 warnings, 723 lines checked

           reply	other threads:[~2025-07-09 17:38 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <20250709173611.6390-7-stephen@networkplumber.org>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250709173710.9D4C0125307@dpdk.org \
    --to=checkpatch@dpdk.org \
    --cc=stephen@networkplumber.org \
    --cc=test-report@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).