From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0C6F746A86
	for <public@inbox.dpdk.org>; Wed,  9 Jul 2025 19:38:42 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 04ABA402DF;
	Wed,  9 Jul 2025 19:38:42 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id 7F38140E1C
 for <test-report@dpdk.org>; Wed,  9 Jul 2025 19:38:40 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 9D4C0125307; Wed,  9 Jul 2025 19:37:10 +0200 (CEST)
Subject: |WARNING| pw155115 [RFC v2 06/12] ethdev: add port mirroring feature
In-Reply-To: <20250709173611.6390-7-stephen@networkplumber.org>
References: <20250709173611.6390-7-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20250709173710.9D4C0125307@dpdk.org>
Date: Wed,  9 Jul 2025 19:37:10 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155115

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#158: FILE: lib/ethdev/ethdev_private.c:283:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#159: FILE: lib/ethdev/ethdev_private.c:284:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#424: FILE: lib/ethdev/rte_ethdev_core.h:105:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#433: FILE: lib/ethdev/rte_ethdev_core.h:125:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#452: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

WARNING:LONG_LINE: line length of 102 exceeds 100 columns
#504: FILE: lib/ethdev/rte_mirror.c:61:
+	if (rte_mbuf_dyn_tx_timestamp_register(&mbuf_timestamp_offset, &mbuf_timestamp_dynflag) < 0) {

WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#587: FILE: lib/ethdev/rte_mirror.c:144:
+	    conf->direction > (RTE_ETH_MIRROR_DIRECTION_INGRESS | RTE_ETH_MIRROR_DIRECTION_EGRESS)) {

total: 4 errors, 3 warnings, 723 lines checked