From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <test-report-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4853546BAC
	for <public@inbox.dpdk.org>; Fri, 18 Jul 2025 18:40:14 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 438B740DCA;
	Fri, 18 Jul 2025 18:40:14 +0200 (CEST)
Received: from dpdk.org (dpdk.org [92.243.24.197])
 by mails.dpdk.org (Postfix) with ESMTP id A614F40DCA
 for <test-report@dpdk.org>; Fri, 18 Jul 2025 18:40:12 +0200 (CEST)
Received: by dpdk.org (Postfix, from userid 65534)
 id 201FC12530F; Fri, 18 Jul 2025 18:38:32 +0200 (CEST)
Subject: |WARNING| pw155341 [PATCH v5 07/13] ethdev: add port mirroring feature
In-Reply-To: <20250718163236.9870-8-stephen@networkplumber.org>
References: <20250718163236.9870-8-stephen@networkplumber.org>
To: test-report@dpdk.org
From: checkpatch@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Message-Id: <20250718163832.201FC12530F@dpdk.org>
Date: Fri, 18 Jul 2025 18:38:32 +0200 (CEST)
X-BeenThere: test-report@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: automatic DPDK test reports <test-report.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/test-report>,
 <mailto:test-report-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/test-report/>
List-Post: <mailto:test-report@dpdk.org>
List-Help: <mailto:test-report-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/test-report>,
 <mailto:test-report-request@dpdk.org?subject=subscribe>
Errors-To: test-report-bounces@dpdk.org

Test-Label: checkpatch
Test-Status: WARNING
http://dpdk.org/patch/155341

_coding style issues_


ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#154: FILE: lib/ethdev/ethdev_private.c:292:
+	fpo->rx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->rx_mirror;

ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#155: FILE: lib/ethdev/ethdev_private.c:293:
+	fpo->tx_mirror = (struct rte_eth_mirror * __rte_atomic *)(uintptr_t)&dev->tx_mirror;

ERROR:SPACING: exactly one space required after that #ifdef
#397: FILE: lib/ethdev/rte_ethdev.h:6706:
+#ifdef  RTE_ETHDEV_MIRROR

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#433: FILE: lib/ethdev/rte_ethdev_core.h:111:
+	RTE_ATOMIC(struct rte_eth_mirror *) *rx_mirror;
 	                                    ^

ERROR:SPACING: need consistent spacing around '*' (ctx:WxV)
#442: FILE: lib/ethdev/rte_ethdev_core.h:131:
+	RTE_ATOMIC(struct rte_eth_mirror *) *tx_mirror;
 	                                    ^

WARNING:TYPO_SPELLING: 'stdio' may be misspelled - perhaps 'studio'?
#461: FILE: lib/ethdev/rte_mirror.c:9:
+#include <stdio.h>

ERROR:SPACING: space prohibited after that open parenthesis '('
#570: FILE: lib/ethdev/rte_mirror.c:118:
+	while ( (mirror = *top) != NULL) {

total: 6 errors, 1 warnings, 730 lines checked